[Bug 1313155] New: Review Request: gluster-nagios-addons - Plugins to monitor gluster services on hosts

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313155

Bug ID: 1313155
           Summary: Review Request: gluster-nagios-addons - Plugins to
                    monitor gluster services on hosts
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://rnachimu.fedorapeople.org/gluster-nagios-addons.spec

SRPM URL:
https://rnachimu.fedorapeople.org/gluster-nagios-addons-0.2.5-1.el6.src.rpm

Description: Gluster-nagios-addons package contains a set of Nagios plugins,
scripts and configurations files which helps to monitor Gluster services
running on a Glusterfs server. These plugins will be used by the nagios server
extensions available in 'nagios-server-addons' packages.

Fedora Account System Username: rnachimu

[Bug 1313155] Review Request: gluster-nagios-addons - Plugins to monitor gluster services on hosts

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313155

Ramesh N  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=1313157

[Bug 1313155] Review Request: gluster-nagios-addons - Plugins to monitor gluster services on hosts

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313155

Ramesh N  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=1313159

[Bug 1313155] Review Request: gluster-nagios-addons - Plugins to monitor gluster services on hosts

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313155

Patrick Uiterwijk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Patrick Uiterwijk  ---
I've been asked to pick this review up.
Do note that you do need a packager sponsor, which I am, so if we pass review
I'll sponsor you.

[Bug 1313155] Review Request: gluster-nagios-addons - Plugins to monitor gluster services on hosts

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313155

--- Comment #2 from Patrick Uiterwijk  ---
Please note that the URL needs to be the link to the upstream project, and
Source needs to be the link to the upstream source file.

Also, remove Vendor.

You are not allowed to automatically enable services.

Why do you modify global system files (/etc/nrpe.cfg) rather than creating an
/etc/nrpe.d/whatever.cfg?

Instead of "make", use %make, so that the optflags get injected.

You need to ship a license for the sources: if it's in the tarball, install it
as %doc. If it's not, add it.

Please fix these issues first, and then I'll look further.