[Bug 2262767] New: Review Request: ghc-config-value - Simple, layout-based value language similar to YAML or JSON

https://bugzilla.redhat.com/show_bug.cgi?id=2262767

Bug ID: 2262767
           Summary: Review Request: ghc-config-value - Simple,
                    layout-based value language similar to YAML or JSON
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://fdedden.fedorapeople.org/ghc-config-value.spec
SRPM URL:
https://fdedden.fedorapeople.org/ghc-config-value-0.8.3-1.fc40.src.rpm

Description:
This package implements a language similar to YAML or JSON but with fewer
special cases and fewer dependencies. It emphasizes layout structure for
sections and lists, and requires quotes around strings.

Fedora Account System Username: fdedden

[Bug 2262767] Review Request: ghc-config-value - Simple, layout-based value language similar to YAML or JSON

https://bugzilla.redhat.com/show_bug.cgi?id=2262767

--- Comment #1 from Frank Dedden  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=112967138

[Bug 2262767] Review Request: ghc-config-value - Simple, layout-based value language similar to YAML or JSON

https://bugzilla.redhat.com/show_bug.cgi?id=2262767

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://hackage.haskell.org
                   |                            |/package/%{pkg_name}

--- Comment #3 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6986277
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more:
https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2262767] Review Request: ghc-config-value - Simple, layout-based value language similar to YAML or JSON

https://bugzilla.redhat.com/show_bug.cgi?id=2262767

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]

--- Comment #4 from Jens Petersen  ---
Thanks, overall looks fine to me.

The package complies with the packaging guidelines, builds and installs.
Spec file is generated with cabal-rpm.

However the license file is MIT, but many of the source files say ISC (except
.cabal).
Could you confirm the license with the upstream maintainer, please?
(I know ISC and MIT are quite similar but we need to be precise in Fedora:
in the worst case we could possibly go with "MIT AND ISC" as workaround but
that feels wrong:
maybe ISC is more correct actually here by the looks of it.)

[Bug 2262767] Review Request: ghc-config-value - Simple, layout-based value language similar to YAML or JSON

https://bugzilla.redhat.com/show_bug.cgi?id=2262767

--- Comment #5 from Jens Petersen  ---
(In reply to Jens Petersen from comment #4)
> Thanks, overall looks fine to me.
>
> The package complies with the packaging guidelines, builds and installs.
> Spec file is generated with cabal-rpm.
>
> However the license file is MIT, but many of the source files say ISC
> (except .cabal).
> Could you confirm the license with the upstream maintainer, please?
> (I know ISC and MIT are quite similar but we need to be precise in Fedora:
> in the worst case we could possibly go with "MIT AND ISC" as workaround but
> that feels wrong:
> maybe ISC is more correct actually here by the looks of it.)

Indeed: https://github.com/glguy/config-value/issues/13

So either add a link to this issue above the corrected License field,
or update to the newer release if that comes out first and is compatible.

[Bug 2262767] Review Request: ghc-config-value - Simple, layout-based value language similar to YAML or JSON

https://bugzilla.redhat.com/show_bug.cgi?id=2262767

--- Comment #6 from Frank Dedden  ---
[fedora-review-service-build]

Thanks Jens, I have updated the .spec file.

[Bug 2262767] Review Request: ghc-config-value - Simple, layout-based value language similar to YAML or JSON

https://bugzilla.redhat.com/show_bug.cgi?id=2262767

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #8 from Jens Petersen  ---
Thanks - looks good now, Frank.

BTW next time it better to bump the release field with a changelog comment when
revising a package review

Package is APPROVED

[Bug 2262767] Review Request: ghc-config-value - Simple, layout-based value language similar to YAML or JSON

https://bugzilla.redhat.com/show_bug.cgi?id=2262767

--- Comment #9 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-config-value

[Bug 2262767] Review Request: ghc-config-value - Simple, layout-based value language similar to YAML or JSON

https://bugzilla.redhat.com/show_bug.cgi?id=2262767

Frank Dedden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NEXTRELEASE
             Status|POST                        |CLOSED
        Last Closed|                            |2024-07-01 09:47:11