Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: rubygem-mustache - Mustache is a framework-agnostic way to render logic-free views
https://bugzilla.redhat.com/show_bug.cgi?id=644335
Summary: Review Request: rubygem-mustache - Mustache is a framework-agnostic way to render logic-free views Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jzigmund@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache.spec SRPM URL: http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache-0.11.2-1.fc13.sr...
Description:
Think of Mustache as a replacement for your views. Instead of views consisting of ERB or HAML with random helpers and arbitrary logic, your views are broken into two parts: a Ruby class and an HTML template.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
Jozef Zigmund jzigmund@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
Michal Fojtik mfojtik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mfojtik@redhat.com QAContact|extras-qa@fedoraproject.org |mfojtik@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #1 from Michal Fojtik mfojtik@redhat.com 2010-10-20 10:08:44 EDT --- Some notes for -1:
- Source0: http://rubygems.org/gems/%%7Bgemname%7D-%%7Bversion%7D.gem
Please this URL to: Source0: http://rubygems.org/downloads/%%7B%7D-%%7Bversion%7D.gem
- Summary
Please remove "Mustache is", it's unnecessarily here.
- Require
Please add rubygem-sinatra to requires:
./lib/mustache/sinatra.rb:require 'sinatra/base
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #2 from Jozef Zigmund jzigmund@redhat.com 2010-10-20 12:56:09 EDT --- (In reply to comment #1)
Some notes for -1:
Please this URL to: Source0: http://rubygems.org/downloads/%%7B%7D-%%7Bversion%7D.gem
I repair URL to Source0: http://rubygems.org/downloads/%%7Bgemname%7D-%%7Bversion%7D.gem, because in your URL was typo.
- Summary
Please remove "Mustache is", it's unnecessarily here.
Removed.
- Require
Please add rubygem-sinatra to requires:
./lib/mustache/sinatra.rb:require 'sinatra/base
Add to spec file, Require: rubygem(sinatra)
NEW SPEC URL: http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache.spec NEW SRPM URL: http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache-0.11.2-2.fc13.sr...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mfojtik@redhat.com QAContact|mfojtik@redhat.com |extras-qa@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
Michal Fojtik mfojtik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Michal Fojtik mfojtik@redhat.com 2010-11-04 13:42:16 EDT --- (In reply to comment #2)
(In reply to comment #1)
NEW SPEC URL: http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache.spec NEW SRPM URL: http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache-0.11.2-2.fc13.sr...
Notes for -2:
[!] Please mark man, README.md and LICENSE with %doc
%defattr(-, root, root, -) %{_bindir}/mustache %{gemdir}/gems/%{gemname}-%{version}/ %doc %{gemdir}/doc/%{gemname}-%{version} %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec
[!] Please replace "%{gemdir}/gems/%{gemname}-%{version}/" with %{geminstdir} Also please make sure you have %dir %{geminstdir}
Please fix these two issues before importing package to Fedora Packages.
REVIEW+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
Jozef Zigmund jzigmund@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #4 from Jozef Zigmund jzigmund@redhat.com 2010-11-08 11:43:20 EST --- (In reply to comment #3)
(In reply to comment #2)
(In reply to comment #1)
NEW SPEC URL: http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache.spec NEW SRPM URL: http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache-0.11.2-2.fc13.sr...
Notes for -2:
[!] Please mark man, README.md and LICENSE with %doc
%defattr(-, root, root, -) %{_bindir}/mustache %{gemdir}/gems/%{gemname}-%{version}/ %doc %{gemdir}/doc/%{gemname}-%{version} %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec
[!] Please replace "%{gemdir}/gems/%{gemname}-%{version}/" with %{geminstdir} Also please make sure you have %dir %{geminstdir}
Please fix these two issues before importing package to Fedora Packages.
REVIEW+
* Mon Nov 8 2010 Jozef Zigmund jzigmund@redhat.com - 0.11.2-3 - Added README.md, LICENSE with macro doc - Replaced macro {gemdir}/gems/{gemname}-{version}/ by macro dir {geminstdir} - Added lib, bin to macro {geminstdir} - Added subpackage doc with folders: man, test, doc and one file: Rakefile
NEW SPEC URL: http://people.redhat.com/jzigmund/rubygem-mustache.spec NEW SRPM URL: http://people.redhat.com/jzigmund/rubygem-mustache-0.11.2-3.fc13.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
Jozef Zigmund jzigmund@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #5 from Jozef Zigmund jzigmund@redhat.com 2010-11-08 11:47:51 EST --- (In reply to comment #3)
(In reply to comment #2)
(In reply to comment #1)
NEW SPEC URL: http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache.spec NEW SRPM URL: http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache-0.11.2-2.fc13.sr...
Notes for -2:
[!] Please mark man, README.md and LICENSE with %doc
%defattr(-, root, root, -) %{_bindir}/mustache %{gemdir}/gems/%{gemname}-%{version}/ %doc %{gemdir}/doc/%{gemname}-%{version} %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec
[!] Please replace "%{gemdir}/gems/%{gemname}-%{version}/" with %{geminstdir} Also please make sure you have %dir %{geminstdir}
Please fix these two issues before importing package to Fedora Packages.
REVIEW+
Thank for the review.
New Package SCM Request ======================= Package Name: rubygem-mustache Short Description: Think of Mustache as a replacement for your views Owners: jzigmund Branches: f13 f14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #6 from Jason Tibbitts tibbs@math.uh.edu 2010-11-09 08:04:33 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2010-11-09 11:18:49 EST --- rubygem-mustache-0.11.2-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-mustache-0.11.2-3.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2010-11-09 11:37:19 EST --- rubygem-mustache-0.11.2-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-mustache-0.11.2-3.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2010-11-09 20:07:17 EST --- rubygem-mustache-0.11.2-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-mustache'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-mustache-0.11.2-3.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-11-10 07:10:13 EST --- rubygem-mustache-0.11.2-4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-mustache-0.11.2-4.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-11-10 07:11:16 EST --- rubygem-mustache-0.11.2-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-mustache-0.11.2-4.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-11-23 16:51:48 EST --- rubygem-mustache-0.11.2-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |rubygem-mustache-0.11.2-4.f | |c13 Resolution| |ERRATA Last Closed| |2010-11-23 16:51:53
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-11-23 16:53:16 EST --- rubygem-mustache-0.11.2-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|rubygem-mustache-0.11.2-4.f |rubygem-mustache-0.11.2-4.f |c13 |c14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #14 from Vít Ondruch vondruch@redhat.com 2012-04-17 07:43:57 EDT --- Package Change Request ====================== Package Name: rubygem-mustache New Branches: el6 Owners: vondruch
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644335
--- Comment #15 from Jon Ciesla limburgher@gmail.com 2012-04-17 09:25:43 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org