https://bugzilla.redhat.com/show_bug.cgi?id=876404
Bug ID: 876404 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: php-channel-aws - Adds the Amazon Web Services channel to PEAR Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: jmarrero@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://marreroj.com/fedora/review-packages/php-channel-aws.spec SRPM URL: http://marreroj.com/fedora/review-packages/php-channel-aws-1.3-2.fc18.src.rp... Description: This package adds the Amazon Web Services channel which allows PEAR packages from this channel to be installed. Fedora Account System Username: jmarrero
https://bugzilla.redhat.com/show_bug.cgi?id=876404
--- Comment #1 from Joseph Marrero jmarrero@gmail.com --- successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4686415
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
--- Comment #2 from Gregor Tätzner gregor@freenet.de --- Created attachment 645398 --> https://bugzilla.redhat.com/attachment.cgi?id=645398&action=edit pre-review
minor issues: php-channel-aws.src:60: W: macro-in-%changelog %clean php-channel-aws.src:41: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 41)
I think the version should start with 1.0 since this is the initial package for aws channel. Well, at least that looks less arbitrary than 1.3. Make also sure to adjust the version strings in the changelog (note that this is nothing you would ever do in an already imported package :) )
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
Gregor Tätzner gregor@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |gregor@freenet.de
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com
--- Comment #3 from Remi Collet fedora@famillecollet.com --- @Gregor: version have no sense for channel packages, but we are used to take the REST version provided (from the channel.xml).
So, as this channel provides REST1.3, I think 1.3 is right. But of course, there is no Guildelines, so this is a packager choice.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
--- Comment #4 from Joseph Marrero jmarrero@gmail.com --- old packages in: http://marreroj.com/fedora/review-packages/old/*
Spec URL: http://marreroj.com/fedora/review-packages/php-channel-aws.spec SRPM URL: http://marreroj.com/fedora/review-packages/php-channel-aws-1.3-3.fc18.src.rp...
I agree with Remi on the version numbers thingy. fixed the two rpmlint issues.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
Gregor Tätzner gregor@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #5 from Gregor Tätzner gregor@freenet.de --- we're good to go then
LICENSE: OK BUILD & INSTALL: OK
Rpmlint ------- Checking: php-channel-aws-1.3-3.fc19.noarch.rpm php-channel-aws-1.3-3.fc19.src.rpm php-channel-aws.noarch: W: no-documentation php-channel-aws.src:19: W: unversioned-explicit-provides php-channel(%{channelname}) 2 packages and 0 specfiles checked; 0 errors, 2 warnings.
MD5-sum check ------------- http://pear.amazonwebservices.com/channel.xml : CHECKSUM(SHA256) this package : 7fe130dd50bbfcce6fb15df93eb2b22fe235e06b590b8a2067ebc688ec6daa16 CHECKSUM(SHA256) upstream package : 7fe130dd50bbfcce6fb15df93eb2b22fe235e06b590b8a2067ebc688ec6daa16
APPROVED ========
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
Joseph Marrero jmarrero@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from Joseph Marrero jmarrero@gmail.com --- New Package SCM Request ======================= Package Name: php-channel-aws Short Description: Adds the Amazon Web Services channel to PEAR Owners: jmarrero Branches: f17 f18 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- php-channel-aws-1.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-channel-aws-1.3-3.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- php-channel-aws-1.3-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-channel-aws-1.3-3.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- php-channel-aws-1.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-channel-aws-1.3-3.el6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- php-channel-aws-1.3-3.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-03-12 04:48:05
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- php-channel-aws-1.3-3.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- php-channel-aws-1.3-3.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876404
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- php-channel-aws-1.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org