[Bug 837688] New: Review Request: python-cliff - Command Line Interface Formulation Framework
https://bugzilla.redhat.com/show_bug.cgi?id=837688
Bug ID: 837688 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: python-cliff - Command Line Interface Formulation Framework Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: rbean@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://threebean.org/rpm/python-cliff.spec SRPM URL: http://threebean.org/rpm/python-cliff-1.0-1.fc17.src.rpm Description: cliff is a framework for building command line programs. It uses setuptools entry points to provide subcommands, output formatters, and other extensions.
Documentation for cliff is hosted on readthedocs.org at http://readthedocs.org/docs/cliff/en/latest/
Fedora Account System Username: ralph
rpmlint ------- --- ~/rpmbuild ยป rpmlint {SPECS,SRPMS}/python-cliff* python-cliff.src: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, toadstools python-cliff.src: W: spelling-error %description -l en_US subcommands -> sub commands, sub-commands, commands python-cliff.src: W: spelling-error %description -l en_US formatters -> for matters, for-matters, formatted python-cliff.src: W: spelling-error %description -l en_US readthedocs -> headteachers 1 packages and 1 specfiles checked; 0 errors, 4 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=837688
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |837687, 837686, 837087
https://bugzilla.redhat.com/show_bug.cgi?id=837688
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |837689
https://bugzilla.redhat.com/show_bug.cgi?id=837688
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|837087 |
--- Comment #1 from Ralph Bean rbean@redhat.com --- Spec URL: http://threebean.org/rpm/python-cliff.spec SRPM URL: http://threebean.org/rpm/python-cliff-1.0-2.fc17.src.rpm
Revised spec that manually disables python3 support until https://bugzilla.redhat.com/show_bug.cgi?id=837087 is resolved.
https://bugzilla.redhat.com/show_bug.cgi?id=837688
Bug 837688 depends on bug 837687, which changed state.
Bug 837687 Summary: Review Request: python-cmd2 - Extra features for standard library's cmd module https://bugzilla.redhat.com/show_bug.cgi?id=837687
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=837688
Bug 837688 depends on bug 837686, which changed state.
Bug 837686 Summary: Review Request: python-tablib - Format agnostic tabular data library (XLS, JSON, YAML, CSV) https://bugzilla.redhat.com/show_bug.cgi?id=837686
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=837688
Matthias Runge mrunge@matthias-runge.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mrunge@matthias-runge.de Flags| |fedora-review?
--- Comment #2 from Matthias Runge mrunge@matthias-runge.de --- I'll take this
https://bugzilla.redhat.com/show_bug.cgi?id=837688
Matthias Runge mrunge@matthias-runge.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Matthias Runge mrunge@matthias-runge.de --- Package Review ==============
Key: - = N/A x = Pass ! = Fail ? = Not evaluated
==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: The package did not built BR could therefore not be checked or the package failed to build because of missing BR [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Fully versioned dependency in subpackages, if present. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint output is silent. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/mrunge/review/837688/cliff-1.0.tar.gz : MD5SUM this package : d65d1a190f8cf05a709bb27ab451f6dd MD5SUM upstream package : d65d1a190f8cf05a709bb27ab451f6dd
[x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [-]: SHOULD Reviewer should test that the package builds in mock. [!]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [?]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define.
one minor: - bundled egg-info needs to get removed in %prep section rm -rf cliff.egg-info
That can be done during import.
Package APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=837688
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from Ralph Bean rbean@redhat.com --- Thanks again, Matthias!
https://bugzilla.redhat.com/show_bug.cgi?id=837688
--- Comment #5 from Ralph Bean rbean@redhat.com --- New Package SCM Request ======================= Package Name: python-cliff Short Description: Command Line Interface Formulation Framework Owners: ralph Branches: f17 f16 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=837688
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=837688
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=837688
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-cliff-1.0-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-cliff-1.0-3.el6
https://bugzilla.redhat.com/show_bug.cgi?id=837688
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2012-07-06 12:57:13
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla