[Bug 469280] New: Review Request: fedora-business-cards - A tool for rendering Fedora contributor business cards

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: fedora-business-cards - A tool for rendering Fedora contributor business cards

https://bugzilla.redhat.com/show_bug.cgi?id=469280

Summary: Review Request: fedora-business-cards - A tool for
                    rendering Fedora contributor business cards
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL:
http://ianweller.fedorapeople.org/SRPMS/fedora-business-cards/0.2.1-1/fedora...
SRPM URL:
http://ianweller.fedorapeople.org/SRPMS/fedora-business-cards/0.2.1-1/fedora...

Description:
fedora-business-cards is a tool written in Python to generate business cards
for Fedora Project contributors.

[Bug 469280] Review Request: fedora-business-cards - A tool for rendering Fedora contributor business cards

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469280

Jon Stanley  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

--- Comment #1 from Jon Stanley   2008-10-30 22:37:41 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK- Sources match upstream md5sum:
ee675049982acdc520530020d2b75f0d  fedora-business-cards-0.2.1.tar.gz
ee675049982acdc520530020d2b75f0d 
build/SOURCES/fedora-business-cards-0.2.1.tar.gz

N/A - Package needs ExcludeArch
OK - BuildRequires correct
N/A - Spec handles locales/find_lang
OK - Package is relocatable and has a reason to be.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
OK - Package is code or permissible content.
N/A - Doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.

N/A - Headers/static libs in -devel subpackage.
N/A - Spec has needed ldconfig in post and postun
N/A - .pc files in -devel subpackage/requires pkgconfig
N/A - .so files in -devel subpackage.
N/A - -devel package Requires: %{name} = %{version}-%{release}
N/A - .la files are removed.

N/A - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have sane scriptlets.
N/A - Should have subpackages require base package with fully versioned depend.
OK - Should have dist tag
OK - Should package latest version
N/A - check for outstanding bugs on package. (For core merge review

APPROVED

[Bug 469280] Review Request: fedora-business-cards - A tool for rendering Fedora contributor business cards

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469280

Ian Weller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #2 from Ian Weller   2008-10-30 22:40:28 EDT ---
Thanks, Jon.

New Package CVS Request
=======================
Package Name: fedora-business-cards
Short Description: A tool for rendering Fedora contributor business cards
Owners: ianweller
Branches: F-9 F-10 devel
InitialCC:

[Bug 469280] Review Request: fedora-business-cards - A tool for rendering Fedora contributor business cards

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469280

Ian Weller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 469280] Review Request: fedora-business-cards - A tool for rendering Fedora contributor business cards

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469280

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #3 from Kevin Fenzi   2008-10-31 12:55:13 EDT ---
Please remember to assign to the reviewer. ;)

cvs done.

[Bug 469280] Review Request: fedora-business-cards - A tool for rendering Fedora contributor business cards

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469280

--- Comment #4 from Fedora Update System   2008-10-31 17:21:57 EDT ---
fedora-business-cards-0.2.1-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/fedora-business-cards-0.2.1-1.fc9

[Bug 469280] Review Request: fedora-business-cards - A tool for rendering Fedora contributor business cards

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469280

Ian Weller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |ERRATA

[Bug 469280] Review Request: fedora-business-cards - A tool for rendering Fedora contributor business cards

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469280

--- Comment #5 from Fedora Update System   2008-11-05 23:05:30 EDT ---
fedora-business-cards-0.2.1-1.fc9 has been pushed to the Fedora 9 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 469280] Review Request: fedora-business-cards - A tool for rendering Fedora contributor business cards

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469280

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|ERRATA                      |NEXTRELEASE