https://bugzilla.redhat.com/show_bug.cgi?id=2064142
Bug ID: 2064142 Summary: Review Request: rust-twox-hash - Rust implementation of the XXHash and XXH3 algorithms Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: alebastr89@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://alebastr.fedorapeople.org/review/mercurial-rs/rust-twox-hash.spec SRPM URL: https://alebastr.fedorapeople.org/review/mercurial-rs/rust-twox-hash-1.6.2-1... Description: Rust implementation of the XXHash and XXH3 algorithms. Fedora Account System Username: alebastr
Changes from generated spec: - dropped feature `digest` - requires `digest` 0.8 (retired in rawhide) - added patches from two pending PRs to fix build failures on non-x86
https://bugzilla.redhat.com/show_bug.cgi?id=2064142
Aleksei Bavshin alebastr89@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2063941
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2063941 [Bug 2063941] Feature request: Enable Mercurial rust extensions
https://bugzilla.redhat.com/show_bug.cgi?id=2064142
Mads Kiilerich mads@kiilerich.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |mads@kiilerich.com
--- Comment #1 from Mads Kiilerich mads@kiilerich.com --- I verified that the spec and source is exactly as generated with "rust2rpm -as twox-hash", except
@@ -12,6 +12,9 @@ License: MIT URL: https://crates.io/crates/twox-hash Source: %{crates_source} +# Address test failures on non-x86 platforms +Patch0: https://github.com/shepmaster/twox-hash/pull/86.patch#/twox-hash-1.6.2-Suppo... +Patch1: https://github.com/shepmaster/twox-hash/pull/87.patch#/twox-hash-1.6.2-Fix-X...
ExclusiveArch: %{rust_arches}
@@ -58,18 +61,6 @@ %files -n %{name}+default-devel %ghost %{crate_instdir}/Cargo.toml
-%package -n %{name}+digest-devel -Summary: %{summary} -BuildArch: noarch - -%description -n %{name}+digest-devel %{_description} - -This package contains library source intended for building other packages which -use the "digest" feature of the "%{crate}" crate. - -%files -n %{name}+digest-devel -%ghost %{crate_instdir}/Cargo.toml - %package -n %{name}+digest_0_10-devel Summary: %{summary} BuildArch: noarch
*Why are the main digest packages dropped? I think it deserves a comment in the spec why the digests are dropped.*
The MIT license is OK.
The package builds locally on f35, installs, and works for enabling experimental build of Mercurial with Rust extensions.
rpmlint is clean, except "W: no-documentation".
https://bugzilla.redhat.com/show_bug.cgi?id=2064142
--- Comment #2 from Aleksei Bavshin alebastr89@gmail.com --- (In reply to Mads Kiilerich from comment #1)
*Why are the main digest packages dropped? I think it deserves a comment in the spec why the digests are dropped.*
The comment is in .rust2rpm.conf which would be imported along with the spec: ``` [fedora] # The compat package for `digest` = 0.8 is not available in Fedora unwanted-features = digest ```
Btw, it's not the main digest package. There are 3 features which provide support for different versions of the `digest` crate: `digest` - 0.8 `digest_0_9 - 0.9 `digest_0_10` - 0.10
https://bugzilla.redhat.com/show_bug.cgi?id=2064142
--- Comment #3 from Mads Kiilerich mads@kiilerich.com --- Ok - I didn't look closely and thought the explicit version was for the old compat packages.
(But FWIW, .rust2rpm.conf seems a bit secret. It is not in -h and there is no man page - only mentioned on https://pagure.io/fedora-rust/rust2rpm . And I find no such file in https://copr-dist-git.fedorainfracloud.org/cgit/alebastr/rhg/rust-twox-hash.... or elsewhere. And when the crate name is provided as rust2rpm argument, it seems odd to have feature tweaks for that crate in a hidden configuration file in the local directory - that seems like a confusing feature.)
https://bugzilla.redhat.com/show_bug.cgi?id=2064142
Mads Kiilerich mads@kiilerich.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2064142
Mads Kiilerich mads@kiilerich.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mads@kiilerich.com
https://bugzilla.redhat.com/show_bug.cgi?id=2064142
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-twox-hash
https://bugzilla.redhat.com/show_bug.cgi?id=2064142
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-c7ededf903 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c7ededf903
https://bugzilla.redhat.com/show_bug.cgi?id=2064142
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-c7ededf903 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-c7ededf903 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c7ededf903
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2064142
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2022-05-07 04:17:45
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-c7ededf903 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org