Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=314161
Summary: Review Request: noip - Dynamic DNS client for no-ip.com Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: brcha@gna.org QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://brcha.no-ip.org/repo/SPECS/noip.spec SRPM URL: http://brcha.no-ip.org/repo/SRPMS/noip-2.1.7-1.f7.src.rpm Description: This is the dynamic DNS update client for no-ip.com. When installed, you must first run /etc/init.d/noip config to configure the client and afterwards you may put it into the /etc/rc.d/rcX.d directory (chkconfig --levels 35 noip on). This spec is ported from PLD Linux, but the newer version is used than in PLD Linux.
This is my first package and I would be grateful if somebody would like to be my sponsor.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: noip - Dynamic DNS client for no-ip.com
https://bugzilla.redhat.com/show_bug.cgi?id=314161
brcha@gna.org changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: noip - Dynamic DNS client for no-ip.com
https://bugzilla.redhat.com/show_bug.cgi?id=314161
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-07 06:14 EST ------- Well,
* For general packaging issue, you can refer to http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines * You can also check your rpms using rpmlint (in rpmlint package) as "rpmlint *.rpm" "rpmlint noip" to detect general packaging mistakes.
A. For spec file: A-1 Description section * Epoch - Please don't introduce Epoch from first.
* License - License tag is now invalid. Please refer to http://fedoraproject.org/wiki/Packaging/LicensingGuidelines http://fedoraproject.org/wiki/Licensing
* Group - Group "Networking/Daemons" is invalid. You can check this by "rpmlint noip-*.src.rpm". And please refer to "rpmlint -I non-standard-group".
* Initscripts related dependency - Please refer to the section "Services" of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
* BuildRoot - The valid BuildRoot for Fedora is also written on http://fedoraproject.org/wiki/Packaging/Guidelines
A-2 %prep, %build, %install, %clean section * Macros consistency - If you want to use macros for commands, please use them consistently. For example, you use %__make, but you don't use %__rm or %__install. - And please use %_initrddir for /etc/rc.d/init.d
A-3 scriptlets section * service-default-enabled - service should not be enabled by default - Please remove "service noip restart" from %post. If you want to do this, this must be "condrestart". - And the line ---------------------------------------------------------- # chkconfig: 2345 15 89 ---------------------------------------------------------- in %_initrddir/noip should be ---------------------------------------------------------- # chkconfig: - 15 89 ---------------------------------------------------------- * Typo? - What is %service in %preun scriptlet?
A-4 %files entry * nobody owner - Usually a daemon should be run as a unique owner. For this package, you should create "noip" user/group for example and noip script should be run as noip user. Please also refer to: http://fedoraproject.org/wiki/Packaging/UsersAndGroups for how to create user/group.
B. The rest rpmlint issue: - For rpmlint issue, you can see the explanation of them by "rpmlint -I mixed-use-of-spaces-and-tabs", for example Please remove rpmlint issue as much as possible.
If you have some reasons the rpmlint complaint should not be fixed, please write the reasons on this bug.
C. Some notes * For %_initrddir/noip: - For example, perhaps the line: ---------------------------------------------------------- noip=${NOIP-/usr/sbin/noip} ---------------------------------------------------------- is the typo of ---------------------------------------------------------- noip=${NOIP:-/usr/sbin/noip} ---------------------------------------------------------- , isn't it?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: noip - Dynamic DNS client for no-ip.com
https://bugzilla.redhat.com/show_bug.cgi?id=314161
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Flag| |needinfo?(brcha@gna.org)
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-17 08:20 EST ------- ping?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: noip - Dynamic DNS client for no-ip.com
https://bugzilla.redhat.com/show_bug.cgi?id=314161
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-26 07:53 EST ------- ping again?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: noip - Dynamic DNS client for no-ip.com
https://bugzilla.redhat.com/show_bug.cgi?id=314161
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-12-03 07:48 EST ------- This bug will be closed if no response from the reporter is received by 2007-Dec-14 (last my comment 1 + 1 month + 1 week)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: noip - Dynamic DNS client for no-ip.com
https://bugzilla.redhat.com/show_bug.cgi?id=314161
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 |201449 nThis| | Status|NEEDINFO |CLOSED Resolution| |NOTABUG Flag|needinfo?(brcha@gna.org) |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-12-14 01:33 EST ------- Closing.
If someone wants to import this package info Fedora, please submit a new review request, thank you!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=314161
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@iki.fi
--- Comment #6 from Jussi Lehtola jussi.lehtola@iki.fi 2008-11-06 15:25:54 EDT --- New package review request at:
https://bugzilla.redhat.com/show_bug.cgi?id=470354
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla