https://bugzilla.redhat.com/show_bug.cgi?id=2238233
Bug ID: 2238233 Summary: Review Request: libdatachannel - WebRTC network library featuring Data Channels, Media Transport, and WebSockets Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ngompa13@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://ngompa.fedorapeople.org/for-review/libdatachannel.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/libdatachannel-0.19.1-1.fc38.src....
Description: libdatachannel is a standalone implementation of WebRTC Data Channels, WebRTC Media Transport, and WebSockets in C++17 with C bindings for POSIX platforms (including GNU/Linux, Android, FreeBSD, Apple macOS and iOS) and Microsoft Windows.
Fedora Account System Username: ngompa
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2238232 Blocks| |2218117 (MultimediaSIG), | |2233012 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2218117 [Bug 2218117] Tracker for multimedia-sig https://bugzilla.redhat.com/show_bug.cgi?id=2233012 [Bug 2233012] obs-studio-30.0.0-beta3 is available https://bugzilla.redhat.com/show_bug.cgi?id=2238232 [Bug 2238232] Review Request: plog - Portable, simple and extensible C++ logging library
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |davide@cavalca.name
--- Comment #1 from Davide Cavalca davide@cavalca.name ---
#BuildRequires: cmake(LibJuice)
Did you mean to leave this commented out? Add a comment explaining why if it's on purpose
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- (In reply to Davide Cavalca from comment #1)
#BuildRequires: cmake(LibJuice)
Did you mean to leave this commented out? Add a comment explaining why if it's on purpose
Yes. I added a comment about it not being needed yet and not being packaged in Fedora yet.
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
--- Comment #3 from Davide Cavalca davide@cavalca.name --- Created attachment 1988195 --> https://bugzilla.redhat.com/attachment.cgi?id=1988195&action=edit review
Attaching the fedora-review review as it's too long for a comment due to rpmlint output
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |POST Assignee|nobody@fedoraproject.org |davide@cavalca.name
--- Comment #4 from Davide Cavalca davide@cavalca.name --- - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 105225510 bytes in 2544 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation
[!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 57600000 bytes in /usr/share libdatachannel-devel-0.19.1-1.fc40.x86_64.rpm:57579520 See:
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Gui...
These should be fixed by making the appropriate subpackages. There's also a ton of rpmlint warnings as it tries to parse binary samples as text files. Not sure what the right course of action is here, but probably worth reporting to rpmlint at least. Besides this, APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- I think I'll just not ship the examples then, I didn't expect it to be quite so angry about it...
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
--- Comment #6 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/libdatachannel
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-9024d60a5e has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9024d60a5e
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-543c5612db has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-543c5612db
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-5123efa972 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5123efa972
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-543c5612db has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-543c5612db` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-543c5612db
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-9024d60a5e has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-9024d60a5e *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9024d60a5e
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-5123efa972 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5123efa972 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5123efa972
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2238233 Bug 2238233 depends on bug 2238232, which changed state.
Bug 2238232 Summary: Review Request: plog - Portable, simple and extensible C++ logging library https://bugzilla.redhat.com/show_bug.cgi?id=2238232
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2023-09-14 00:43:46
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-5123efa972 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-9024d60a5e has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2238233
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-543c5612db has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org