https://bugzilla.redhat.com/show_bug.cgi?id=2264206
Bug ID: 2264206 Summary: Review Request: rocm-validation-suite - ROCm Validation Test Suite Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: trix@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://trix.fedorapeople.org/rocm-validation-suite.spec SRPM URL: https://trix.fedorapeople.org/rocm-validation-suite-6.0.2-1.fc40.src.rpm
The ROCm Validation Suite (RVS) is a system validation and diagnostics tool for monitoring, stress testing, detecting and troubleshooting issues that affects the functionality and performance of AMD GPU(s) operating in a high-performance/AI/ML computing environment. RVS is enabled using the ROCm software stack on a compatible software and hardware platform.
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2264206
--- Comment #1 from Tom Rix trix@redhat.com --- This package is only intended for testing. I do not believe it was ever ment to be packaged and has a lot of rough parts so I hope it will get a pass on the usual expected quality. I expect the package to be used by users to test their particular card and report problems or by some to be defined fedora c/i.
https://bugzilla.redhat.com/show_bug.cgi?id=2264206
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/ROCm/ROC | |mValidationSuite
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7015749 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2264206
--- Comment #3 from Tom Rix trix@redhat.com --- Spec URL: https://trix.fedorapeople.org/rocm-validation-suite.spec SRPM URL: https://trix.fedorapeople.org/rocm-validation-suite-6.0.2-1.fc41.src.rpm
Updated for the llvm17 change
https://bugzilla.redhat.com/show_bug.cgi?id=2264206
Sergey Bostandzhyan jin@mediatomb.cc changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jin@mediatomb.cc
--- Comment #4 from Sergey Bostandzhyan jin@mediatomb.cc --- I tried out the src.rpm
The line in the spec:
%global build_cxxflags %(echo %{optflags} | sed -e 's/-fcf-protection// -e 's/-fcf-protection//' -e 's/-ffat-lto-objects//')
is missing an aphostrophe at the end of the second sed:
%global build_cxxflags %(echo %{optflags} | sed -e 's/-fcf-protection//' -e 's/-fcf-protection//' -e 's/-ffat-lto-objects//')
After fixing this locally and building the package I can confirm that rvs ran through without errors on my gfx900
https://bugzilla.redhat.com/show_bug.cgi?id=2264206
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2021523 --> https://bugzilla.redhat.com/attachment.cgi?id=2021523&action=edit The .spec file difference from Copr build 7015749 to 7156062
https://bugzilla.redhat.com/show_bug.cgi?id=2264206
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7156062 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2264206
--- Comment #7 from Tom Rix trix@redhat.com --- The spec has been fixed Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2264206
--- Comment #8 from Germano Massullo germano.massullo@gmail.com --- Hello, do you still need help with the package review?
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com