[Bug 904328] New: Review Request: perl-Config-ApacheFormat - Use Apache format config files - package-review

List overview All Threads
Download

newer

[Bug 904328] New: Review Request: perl-Config-ApacheFormat - Use Apache format config files

older

[Bug 904330] New: Review Request:...

[Bug 903829] New: Review Request:...

Red Hat Bugzilla

26 Jan 2013 26 Jan '13

10:02 a.m.

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

Bug ID: 904328 Summary: Review Request: perl-Config-ApacheFormat - Use Apache format config files Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: unspecified Reporter: long@rule.lv

Spec URL: http://unibackup.rule.lv/FedoraRPM/perl-Config-ApacheFormat.spec SRPM URL: http://unibackup.rule.lv/FedoraRPM/perl-Config-ApacheFormat-1.2-1.fc16.src.r... Description: This module is designed to parse a configuration file in the same syntax used by the Apache web server (see http://httpd.apache.org for details). This allows you to build applications which can be easily managed by experienced Apache admins. Also, by using this module, you'll benefit from the support for nested blocks with built-in parameter inheritance. This can greatly reduce the amount or repeated information in your configuration files.

Fedora Account System Username: normunds

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cf0Q1fvLqq&a=cc_unsubscribe

Show replies by date

Red Hat Bugzilla

26 Jan 26 Jan

10:10 a.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

Normunds long@rule.lv changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZRmpUuzPZa&a=cc_unsubscribe

Red Hat Bugzilla

10:19 a.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #1 from Normunds long@rule.lv --- All packages mentioned below were tested with rpmlint, mock (for i386 arch) and koji (16, 17, 18, 19, rawhide). These are my first packages for Fedora, so if you find something to improve in one of them, don't bother, I'll check other packages for reported problems.

Need sponsor.

bug 903824 perl-Convert-Age.spec bug 903826 perl-Net-Domain-TLD.spec bug 903829 perl-Time-Interval.spec bug 904328 perl-Config-ApacheFormat.spec bug 904329 perl-Data-Validate-Domain.spec bug 904330 perl-Data-Validate-IP.spec bug 904331 perl-Shell.spec

Thanks.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iqQkvnQwEI&a=cc_unsubscribe

Red Hat Bugzilla

28 Jan 28 Jan

1:29 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

Petr Šabata psabata@redhat.com changed:

--- Comment #2 from Petr Šabata psabata@redhat.com --- Taking the review.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lzcI2o3mwz&a=cc_unsubscribe

Red Hat Bugzilla

2:01 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #3 from Petr Šabata psabata@redhat.com --- Issues similar to those of other reviews...

Missing build-time dependency: perl(Carp)

Unneeded runtime dependencies: perl(Class::MethodMaker) perl(File::Spec) perl(Scalar::Util) perl(Text::Balanced) Those are automatically picked up by rpmbuild.

Lines 40 and 41 are unneeded. None of the files has executable bits set. Line 52 is also unneeded (done by rpmbuild).

And the command macros could be replaced with simple calls.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pMbzQ2uH3A&a=cc_unsubscribe

Red Hat Bugzilla

10:02 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #4 from Normunds long@rule.lv --- Spec file and src package updated.

* Fixed dependencies. * Replaced macros with simple commands. * Removed useless lines

New package overwritten in original location.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h4A7YUnRMF&a=cc_unsubscribe

Red Hat Bugzilla

29 Jan 29 Jan

2:54 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

Petr Šabata psabata@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |

--- Comment #5 from Petr Šabata psabata@redhat.com --- Removing FE-NEEDSPONSOR.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D4MI2vZakE&a=cc_unsubscribe

Red Hat Bugzilla

3:31 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #6 from Petr Šabata psabata@redhat.com --- I see you also added the Data::Dumper dependency. Its only used in the dump() subroutine which is not called from the tests at all. You may drop this again :)

And again, that %{__perl} macro in MODULE_COMPAT...

Not approving yet.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Bp0IPsZK4X&a=cc_unsubscribe

Red Hat Bugzilla

31 Jan 31 Jan

10:06 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #7 from Normunds long@rule.lv --- Moved Data::Dumper to Requires, removed macro. Please check.

Thanks.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Zwq4ysuegL&a=cc_unsubscribe

Red Hat Bugzilla

1 Feb 1 Feb

9:38 a.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #8 from Petr Šabata psabata@redhat.com --- (In reply to comment #7)

...

Moved Data::Dumper to Requires

Good. Indeed, it wasn't autodetected in this case. perl(Class::MethodMaker), on the other hand, is. Why did you add it now?

I see you've removed your email address from the changelog here too; why? https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#...

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6jCidnQHgj&a=cc_unsubscribe

Red Hat Bugzilla

2 Feb 2 Feb

6:57 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #9 from Normunds long@rule.lv ---

...

[...] wasn't autodetected in this case. perl(Class::MethodMaker), on the other hand, is. Why did you add it now?

Still getting used to rpmbuild behavior. I was assuming that if rpmbuild detects Requirement and requirement is specified in spec file, it will show duplicate Requirement in rpm --requires output.

* perl(Class::MethodMaker) removed from Requirements. * Added obfuscated e-mail.

Thanks.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AYLrl6bG7L&a=cc_unsubscribe

Red Hat Bugzilla

4 Feb 4 Feb

2:22 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #10 from Petr Šabata psabata@redhat.com --- (In reply to comment #9)

...

...
[...] wasn't autodetected in this case. perl(Class::MethodMaker), on the other hand, is. Why did you add it now?

Still getting used to rpmbuild behavior. I was assuming that if rpmbuild detects Requirement and requirement is specified in spec file, it will show duplicate Requirement in rpm --requires output.

It used to be like that. Not anymore. The duplicates get filtered out.

...

perl(Class::MethodMaker) removed from Requirements.

Ok.

...

Added obfuscated e-mail.

*sigh* If you must... enclose it with qw(< >) at least.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R3Un2bCJae&a=cc_unsubscribe

Red Hat Bugzilla

4:24 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #11 from Normunds fedorapkg@rule.lv --- Spec file/srpm updated, added <> to e-mail.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1gNj0cuutk&a=cc_unsubscribe

Red Hat Bugzilla

5 Feb 5 Feb

6:52 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #12 from Normunds fedorapkg@rule.lv --- Another reviewer suggested to use simpler e-mail obfuscation, so, to be consistent, I changed it for all packages.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lMn6BMwyXb&a=cc_unsubscribe

Red Hat Bugzilla

15 Feb 15 Feb

11:09 a.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

Petr Šabata psabata@redhat.com changed:

--- Comment #13 from Petr Šabata psabata@redhat.com --- Alright, approving.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cVdW2JcogZ&a=cc_unsubscribe

Red Hat Bugzilla

12:41 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

Normunds fedorapkg@rule.lv changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #14 from Normunds fedorapkg@rule.lv --- Thanks.

Adding fedora-cvs flag.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6XDNvogz1U&a=cc_unsubscribe

Red Hat Bugzilla

1:31 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #15 from Jon Ciesla limburgher@gmail.com --- No SCM request found, unsetting flag.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=popLHmiUVw&a=cc_unsubscribe

Red Hat Bugzilla

1:54 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

Normunds fedorapkg@rule.lv changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #16 from Normunds fedorapkg@rule.lv --- Sorry for that. Re-trying.

New Package SCM Request ======================= Package Name: perl-Config-ApacheFormat Short Description: Use Apache format config files. Owners: normunds psabata Branches: f17 f18 InitialCC: perl-sig

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ghx3tdZxIw&a=cc_unsubscribe

Red Hat Bugzilla

1:58 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #17 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W1lhSwmkfb&a=cc_unsubscribe

Red Hat Bugzilla

3:21 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0RD0nrexhJ&a=cc_unsubscribe

Red Hat Bugzilla

3:21 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #18 from Fedora Update System updates@fedoraproject.org --- perl-Config-ApacheFormat-1.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Config-ApacheFormat-1.2-1.fc17

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LJgN6axOTc&a=cc_unsubscribe

Red Hat Bugzilla

6:38 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #19 from Fedora Update System updates@fedoraproject.org --- perl-Config-ApacheFormat-1.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Config-ApacheFormat-1.2-1.fc18

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fKMeIZggn7&a=cc_unsubscribe

Red Hat Bugzilla

26 Feb 26 Feb

2:34 a.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #20 from Fedora Update System updates@fedoraproject.org --- perl-Config-ApacheFormat-1.2-1.fc18 has been pushed to the Fedora 18 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3pPvhioxTM&a=cc_unsubscribe

Red Hat Bugzilla

2:55 a.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904328

--- Comment #21 from Fedora Update System updates@fedoraproject.org --- perl-Config-ApacheFormat-1.2-1.fc17 has been pushed to the Fedora 17 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fM2ygbZtYx&a=cc_unsubscribe

Red Hat Bugzilla

3 Apr 3 Apr

4:18 p.m.

New subject: [Bug 904328] Review Request: perl-Config-ApacheFormat - Use Apache format config files

https://bugzilla.redhat.com/show_bug.cgi?id=904328

Petr Šabata psabata@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

4128

Age (days ago)

4560

Last active (days ago)

package-review@lists.fedoraproject.org

24 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla