[Bug 784525] New: Review Request: libcmis - a C++ client library for the CMIS interface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: libcmis - a C++ client library for the CMIS interface

https://bugzilla.redhat.com/show_bug.cgi?id=784525

Summary: Review Request: libcmis - a C++ client library for the
                    CMIS interface
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---
        Regression: ---
        Mount Type: ---
     Documentation: ---

Spec URL: http://dtardon.fedorapeople.org/libcmis.spec
SRPM URL: http://dtardon.fedorapeople.org/libcmis-0.1.0-1.fc16.src.rpm
Description:

LibCMIS is a C++ client library for the CMIS interface. This allows C++
applications to connect to any ECM behaving as a CMIS server like
Alfresco, Nuxeo for the open source ones.

It is a dependency of libreoffice 3.5 .

[Bug 784525] Review Request: libcmis - a C++ client library for the CMIS interface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=784525

Caolan McNamara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 784525] Review Request: libcmis - a C++ client library for the CMIS interface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=784525

Caolan McNamara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Caolan McNamara  2012-01-27 04:52:01 EST ---
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review

SRPMS/libcmis-0.1.0-1.fc16.src.rpm RPMS/*/libcmis*
libcmis.i686: E: incorrect-fsf-address
/usr/share/doc/libcmis-0.1.0/COPYING.LGPL
libcmis-devel.i686: W: no-documentation
libcmis-tools.i686: W: no-documentation
libcmis-tools.i686: W: no-manual-page-for-binary cmis-client

ok, we should send a patch to Cedric to update the archaic COPYING.LGPL

MUST: The package must be named according to the Package Naming Guidelines
ok

MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption
ok

MUST: The package must meet the Packaging Guidelines
ok

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines
ok

MUST: The License field in the package spec file must match the actual license
ok

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc
ok

MUST: The spec file must be written in American English
ok

MUST: The spec file for the package MUST be legible
ok

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
ok

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture
ok

MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line
ok

MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
ok

MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden
ok

MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun
ok

MUST: Packages must NOT bundle copies of system libraries
ok

MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker
ok

MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory
ok

MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)
ok

MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example
ok

MUST: Each package must consistently use macros
ok

MUST: The package must contain code, or permissable content
ok

MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity)
ok

MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present
ok

MUST: Header files must be in a -devel package
ok

MUST: Static libraries must be in a -static package
ok

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel package
ok

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release}
ok

MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built
ok

MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
ok

MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time
ok

MUST: All filenames in rpm packages must be valid UTF-8
ok

[Bug 784525] Review Request: libcmis - a C++ client library for the CMIS interface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=784525

David Tardon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #2 from David Tardon  2012-01-27 07:38:25 EST ---
New Package SCM Request
=======================
Package Name: libcmis
Short Description: A C++ client library for the CMIS interface
Owners: caolanm dtardon
Branches: 
InitialCC:

[Bug 784525] Review Request: libcmis - a C++ client library for the CMIS interface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=784525

--- Comment #3 from Jon Ciesla  2012-01-27 08:10:29 EST ---
Git done (by process-git-requests).

[Bug 784525] Review Request: libcmis - a C++ client library for the CMIS interface

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=784525

David Tardon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE
        Last Closed|                            |2012-01-27 08:33:31