[Bug 226424] New: Merge Review: sound-juicer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226424

Summary: Merge Review: sound-juicer
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: sound-juicer

http://cvs.fedora.redhat.com/viewcvs/devel/sound-juicer/
Initial Owner: [e-mail]

[Bug 226424] Merge Review: sound-juicer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: sound-juicer

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226424

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 226424] Merge Review: sound-juicer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: sound-juicer

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226424

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]      |[e-mail]
               Flag|fedora-review?              |fedora-review-

------- Additional Comments From [e-mail]  2007-02-03 12:19 EST -------
Good:
* Tarball matches upstream.
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* All paths begin with macros
* All necessary BuildRequires listed.
* Package builds in Mock.

Must Fix:
* Source URL is not canonical.
* Missing Package URL. http://www.burtonini.com/blog/computers/sound-juicer
* Sound Juicer shouldn't own the following directories (hicolor-icon-theme
should be the sole owner):
/usr/share/icons/hicolor/16x16
/usr/share/icons/hicolor/16x16/apps
/usr/share/icons/hicolor/22x22
/usr/share/icons/hicolor/22x22/apps
/usr/share/icons/hicolor/22x22
/usr/share/icons/hicolor/22x22/apps
/usr/share/icons/hicolor/scalable
/usr/share/icons/hicolor/scalable/apps

Minor:
* Doesn't use the preferred buildroot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Duplicate BuildRequires: GConf2-devel (by gnome-media-devel), gtk2-devel (by
gnome-media-devel), gnome-vfs2-devel (by libgnomeui-devel), glib2-devel (by
libgnomeui-devel), hal-devel (by gnome-vfs2-devel)
* Unnecessary Requires on gstreamer, gtk, libmusicbrainz, and glib2. The BR on
the devel packages should pull these in automatically.

[Bug 226424] Merge Review: sound-juicer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: sound-juicer

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226424

------- Additional Comments From [e-mail]  2007-02-03 20:13 EST -------
* Sat Feb  3 2007 Matthias Clasen  - 2.16.2-3
- Minor fixes from package review:
 * Remove unnecessary Requires
 * Add URL
 * Correct Source, BuildRoot
 * Fix directory ownership

[Bug 226424] Merge Review: sound-juicer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: sound-juicer

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226424

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]            |[e-mail]
               Flag|fedora-review-              |fedora-review?

[Bug 226424] Merge Review: sound-juicer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: sound-juicer

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226424

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]      |[e-mail]
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-02-04 13:11 EST -------
Changes look good.  +1 Approved.

[Bug 226424] Merge Review: sound-juicer

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: sound-juicer

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226424

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |CURRENTRELEASE

------- Additional Comments From [e-mail]  2007-08-10 21:31 EST -------
Review done.