[Bug 2143583] New: Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

Bug ID: 2143583
           Summary: Review Request: lua-ev - Lua integration with libev
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://download.copr.fedorainfracloud.org/results/fed500/lua-ev/fedora-rawh...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/fed500/lua-ev/fedora-rawh...

Description:
Event loop programming with Lua.

Fedora Account System Username: fed500

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

Jonny Heggheim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

--- Comment #1 from Jonny Heggheim  ---
The module is not loading, the install location seems strange.

$ rpm -ql lua-ev
/usr/lib/.build-id
/usr/lib/.build-id/f2
/usr/lib/.build-id/f2/c3f640879d3e057d274a2318e4db45eda2237b
/usr/lib64/lua/5.45.4/cmod/ev.so
/usr/share/doc/lua-ev
/usr/share/doc/lua-ev/README
/usr/share/doc/lua-ev/example.lua
/usr/share/licenses/lua-ev
/usr/share/licenses/lua-ev/LICENSE

$ lua -e 'require "ev"'
lua: (command line):1: module 'ev' not found:
        no field package.preload['ev']
        no file '/usr/share/lua/5.4/ev.lua'
        no file '/usr/share/lua/5.4/ev/init.lua'
        no file '/usr/lib64/lua/5.4/ev.lua'
        no file '/usr/lib64/lua/5.4/ev/init.lua'
        no file './ev.lua'
        no file './ev/init.lua'
        no file '/usr/lib64/lua/5.4/ev.so'
        no file '/usr/lib64/lua/5.4/loadall.so'
        no file './ev.so'
stack traceback:
        [C]: in function 'require'
        (command line):1: in main chunk
        [C]: in ?

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

--- Comment #2 from Jonny Heggheim  ---
This steps/changes are working on my laptop:

---

%build
%cmake -DINSTALL_CMOD=%{lua_libdir}
%cmake_build

%install
%cmake_install

%check
LUA_CPATH=%{buildroot}%{lua_libdir}/?.so \
lua example.lua

%files
%license LICENSE
%doc README
%doc example.lua
%{lua_libdir}/ev.so

---

$ lua -e 'ev = require "ev"; print(ev.version())'
4.0     33.0

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

--- Comment #3 from Jonny Heggheim  ---
$ lua /usr/share/doc/lua-ev/example.lua
Register build_all_timers callback
Run the event loop
Run build_all_timers callback
Thu Nov 17 23:54:44 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:44 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:45 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:45 2022        CB 2    interval: 2.0
Thu Nov 17 23:54:45 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:46 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:46 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:47 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:47 2022        CB 2    interval: 2.0
Thu Nov 17 23:54:47 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:48 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:48 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:48 2022        CB 1    interval: 5.0
Thu Nov 17 23:54:49 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:49 2022        CB 2    interval: 2.0
Thu Nov 17 23:54:49 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:50 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:50 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:51 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:51 2022        CB 2    interval: 2.0
Thu Nov 17 23:54:51 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:52 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:52 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:53 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:53 2022        CB 2    interval: 2.0
Thu Nov 17 23:54:53 2022        CB 3    interval: 0.5
Thu Nov 17 23:54:53 2022        CB 1    interval: 5.0
Thu Nov 17 23:54:53 2022        CB 4    interval: 10.0

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

Jonny Heggheim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review-
                   |                            |needinfo?(benson_muite@emai
                   |                            |lplus.org)

--- Comment #4 from Jonny Heggheim  ---
I will start again at the review once a functional package have been
re-submitted

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

Jonny Heggheim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review-              |fedora-review?

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

Benson Muite  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(benson_muite@emai |
                   |lplus.org)                  |

--- Comment #5 from Benson Muite  ---
Updated.
spec:
https://download.copr.fedorainfracloud.org/results/fed500/lua-ev/fedora-rawh...
srpm:
https://download.copr.fedorainfracloud.org/results/fed500/lua-ev/fedora-rawh...

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

--- Comment #6 from Jonny Heggheim  ---
> License:        Apache-2.0

The license file and README says it is MIT licensed.

You could use the README as %license, since the license/copyright is in-lined.

Not having a verbatim URL is annoying, I can not open the link directly and
have to manual string replacement.

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

--- Comment #7 from Benson Muite  ---
Thanks for the suggestions. Implemented.

spec:
https://download.copr.fedorainfracloud.org/results/fed500/lua-ev/fedora-rawh...
srpm:
https://download.copr.fedorainfracloud.org/results/fed500/lua-ev/fedora-rawh...

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

Jonny Heggheim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #8 from Jonny Heggheim  ---
Approved!

Please fix %changelog before import:
> lua-ev.x86_64: W: incoherent-version-in-changelog 1.5-1 ['1.5-2.fc38', '1.5-2']

Suggestion, feel free to keep as is:
I think it would be nice to also include the readme in the %doc (duplicated, in
addition to %license). Users wanting to save space can always install with
--nodocs.

I do not think there is a best practice, but we had some discussion in the
review of lua-cosmo bug 2142671#c4

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

--- Comment #9 from Benson Muite  ---
A softlink from license directory to docs directory seems ok.

Given that SUSE has managed to integrate lua_rocks into their
build process, it would be good to do the same for Fedora. It
would also make package maintenance easier.

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

--- Comment #10 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/lua-ev

[Bug 2143583] Review Request: lua-ev - Lua integration with libev

https://bugzilla.redhat.com/show_bug.cgi?id=2143583

Benson Muite  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2023-01-08 20:00:30