[Bug 1194897] New: Review Request: nodejs-grunt-util-propery - Grunt util for getting and setting properties
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
Bug ID: 1194897 Summary: Review Request: nodejs-grunt-util-propery - Grunt util for getting and setting properties Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: piotr1212@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://piotrp.fedorapeople.org/nodejs-grunt-util-property.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-grunt-util-property-0.0.1-1.fc21.src.... Description: Grunt util for getting and setting properties Fedora Account System Username: piotrp
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1194902
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1194902 [Bug 1194902] Review Request: nodejs-grunt-util-options - Grunt util for getting options
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tom@compton.nu Summary|Review Request: |Review Request: |nodejs-grunt-util-propery - |nodejs-grunt-util-property |Grunt util for getting and |- Grunt util for getting |setting properties |and setting properties
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |tom@compton.nu Flags| |fedora-review?
--- Comment #1 from Tom Hughes tom@compton.nu --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/tom/1194897-nodejs-grunt-util- property/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file Note: Found : Packager: Tom Hughes tom@compton.nu See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-grunt-util-property-0.0.1-1.fc23.noarch.rpm nodejs-grunt-util-property-0.0.1-1.fc23.src.rpm nodejs-grunt-util-property.noarch: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- nodejs-grunt-util-property.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Requires -------- nodejs-grunt-util-property (rpmlib, GLIBC filtered): nodejs(engine)
Provides -------- nodejs-grunt-util-property: nodejs-grunt-util-property npm(grunt-util-property)
Source checksums ---------------- https://registry.npmjs.org/grunt-util-property/-/grunt-util-property-0.0.1.t... : CHECKSUM(SHA256) this package : bf9a665f7e0a536815b0485832f92f3f163e2ddcaef1fe1e2e24b159f3403988 CHECKSUM(SHA256) upstream package : bf9a665f7e0a536815b0485832f92f3f163e2ddcaef1fe1e2e24b159f3403988
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 1194897 Buildroot used: compton-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
--- Comment #2 from Tom Hughes tom@compton.nu --- As this is MIT licensed you will need to add the license text yourself until upstream responds to your request to add it.
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
--- Comment #3 from Piotr Popieluch piotr1212@gmail.com --- Thank you, added the license.
new spec+srpm no version bump:
Spec URL: https://piotrp.fedorapeople.org/nodejs-grunt-util-property.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-grunt-util-property-0.0.1-1.fc22.src....
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Tom Hughes tom@compton.nu --- That looks good now - package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Piotr Popieluch piotr1212@gmail.com --- thank you
New Package SCM Request ======================= Package Name: nodejs-grunt-util-property Short Description: Grunt util for getting and setting properties Upstream URL: https://github.com/mikaelkaron/grunt-util-property Owners: piotrp Branches: f20 f21 f22 el6 epel7
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- nodejs-grunt-util-property-0.0.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/nodejs-grunt-util-property-0.0.1-1.f...
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- nodejs-grunt-util-property-0.0.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-grunt-util-property-0.0.1-1.f...
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- nodejs-grunt-util-property-0.0.1-1.fc21 has been pushed to the Fedora 21 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |nodejs-grunt-util-property- | |0.0.1-1.fc21 Resolution|--- |ERRATA Last Closed| |2015-07-03 14:44:02
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- nodejs-grunt-util-property-0.0.1-1.fc21 has been pushed to the Fedora 21 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1194897
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-grunt-util-property- |nodejs-grunt-util-property- |0.0.1-1.fc21 |0.0.1-1.fc22
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- nodejs-grunt-util-property-0.0.1-1.fc22 has been pushed to the Fedora 22 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla