Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-String-Formatter - Build sprintf-like functions of your own
https://bugzilla.redhat.com/show_bug.cgi?id=579060
Summary: Review Request: perl-String-Formatter - Build sprintf-like functions of your own Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/String-Formatter/ OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: iarnell@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedorapeople.org/~iarnell/review/perl-String-Formatter.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-String-Formatter-0.100720-1.fc1...
Description: String::Formatter is a tool for building sprintf-like formatting routines. It supports named or positional formatting, custom conversions, fixed string interpolation, and simple width-matching out of the box. It is easy to alter its behavior to write new kinds of format string expanders. For most cases, it should be easy to build all sorts of formatters out of the options built into String::Formatter.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2091038
*rt-0.10_01
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |cweyl@alumni.drew.edu
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
--- Comment #1 from Chris Weyl cweyl@alumni.drew.edu 2010-04-02 11:40:31 EDT --- Looks good!
Your sed syntax is interesting: "sed -i -e '1s~#!perl~#!%{__perl}~' bench.pl". Am I correct in thinking the leading "1" constrains sed to tinkering with the first line only? Or only one match?
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2091038
Spec looks sane, clean and consistent; license is correct (GPLv2); make test passes cleanly.
Source tarballs match upstream (sha1sum): 4ff6a1d173c7f51ef794a8c9d63e6e17a60f62d0 String-Formatter-0.100720.tar.gz 4ff6a1d173c7f51ef794a8c9d63e6e17a60f62d0 String-Formatter-0.100720.tar.gz.srpm
Final provides / requires are sane:
0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-String-Formatter-0.100720-1.fc14.noarch.rpm <===== ====> rpmlint perl-String-Formatter.noarch: W: spelling-error Summary(en_US) sprintf -> sprint, sprints, sprint f perl-String-Formatter.noarch: W: spelling-error %description -l en_US sprintf -> sprint, sprints, sprint f perl-String-Formatter.noarch: W: spelling-error %description -l en_US expanders -> ex panders, ex-panders, expands perl-String-Formatter.noarch: W: spelling-error %description -l en_US formatters -> for matters, for-matters, formatted 1 packages and 0 specfiles checked; 0 errors, 4 warnings. ====> provides for perl-String-Formatter-0.100720-1.fc14.noarch.rpm perl(String::Formatter) = 0.100720 perl-String-Formatter = 0.100720-1.fc14 perl(String::Formatter::Cookbook) = 0.100720 ====> requires for perl-String-Formatter-0.100720-1.fc14.noarch.rpm perl >= 0:5.006 perl(:MODULE_COMPAT_5.10.1) perl(Params::Util) perl(strict) perl(Sub::Exporter) perl(warnings)
=====> perl-String-Formatter-0.100720-1.fc14.src.rpm <===== ====> rpmlint perl-String-Formatter.src: W: spelling-error Summary(en_US) sprintf -> sprint, sprints, sprint f perl-String-Formatter.src: W: spelling-error %description -l en_US sprintf -> sprint, sprints, sprint f perl-String-Formatter.src: W: spelling-error %description -l en_US expanders -> ex panders, ex-panders, expands perl-String-Formatter.src: W: spelling-error %description -l en_US formatters -> for matters, for-matters, formatted 1 packages and 0 specfiles checked; 0 errors, 4 warnings. ====> provides for perl-String-Formatter-0.100720-1.fc14.src.rpm ====> requires for perl-String-Formatter-0.100720-1.fc14.src.rpm perl >= 0:5.006 perl(ExtUtils::MakeMaker) perl(Params::Util) perl(Pod::Coverage::TrustPod) perl(Sub::Exporter) perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage)
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #2 from Iain Arnell iarnell@gmail.com 2010-04-02 12:12:37 EDT --- Thanks, Chris. Yes, the leading "1" is an address that restricts the "s" command to the first line.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
--- Comment #3 from Iain Arnell iarnell@gmail.com 2010-04-02 12:21:43 EDT --- New Package CVS Request ======================= Package Name: perl-String-Formatter Short Description: Build sprintf-like functions of your own Owners: iarnell Branches: F-11 F-12 F-13 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
--- Comment #4 from Kevin Fenzi kevin@tummy.com 2010-04-03 13:43:43 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2010-04-04 03:07:26 EDT --- perl-String-Formatter-0.100720-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-String-Formatter-0.100720-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2010-04-04 03:07:30 EDT --- perl-String-Formatter-0.100720-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-String-Formatter-0.100720-1.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2010-04-04 03:07:35 EDT --- perl-String-Formatter-0.100720-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-String-Formatter-0.100720-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2010-04-06 15:56:30 EDT --- perl-String-Formatter-0.100720-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-String-Formatter'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-String-Formatter-0.100720-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2010-04-08 21:25:34 EDT --- perl-String-Formatter-0.100720-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-String-Formatter'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-String-Formatter-0.100720-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-04-08 21:38:46 EDT --- perl-String-Formatter-0.100720-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-String-Formatter'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-String-Formatter-0.100720-1.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-04-20 08:59:50 EDT --- perl-String-Formatter-0.100720-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |perl-String-Formatter-0.100 | |720-1.fc12 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-04-20 09:34:25 EDT --- perl-String-Formatter-0.100720-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|perl-String-Formatter-0.100 |perl-String-Formatter-0.100 |720-1.fc12 |720-1.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-04-20 09:35:09 EDT --- perl-String-Formatter-0.100720-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=579060
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|perl-String-Formatter-0.100 |perl-String-Formatter-0.100 |720-1.fc11 |720-1.fc13
package-review@lists.fedoraproject.org