https://bugzilla.redhat.com/show_bug.cgi?id=2233185
Bug ID: 2233185 Summary: Review Request: golang-modernc-cc-4 - A C99 compiler front end Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mike@flyn.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-cc-4.spec SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-cc-4-3.41.0-1.fc38.src.rpm Description: A C99 compiler front end Fedora Account System Username: mikep
https://bugzilla.redhat.com/show_bug.cgi?id=2233185
W. Michael Petullo mike@flyn.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2231928
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2231928 [Bug 2231928] Review Request: golang-modernc-ccgo-3 - ccgo is a C compiler targeting Go
https://bugzilla.redhat.com/show_bug.cgi?id=2233185
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value CC| |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Version: 3.41.0
We're packaging the v4, use the latest v4 tag:
Version: 4.13.0
- No docs, GO-LICENSE, or README.md in v4
%global golicenses LICENSE %global godocs AUTHORS CONTRIBUTORS
- copy the files before deleting the root:
%autopatch -p1 cp -aR LICENSE AUTHORS CONTRIBUTORS v4/. find . ! ( -name v4 -o -name _build ) -maxdepth 1 -exec rm -rvf {} ; mv v4/* .
Filed this upstream https://gitlab.com/cznic/cc/-/issues/159
- License ok - Builds in mock - Checks pass - No rpmlint errors - Conforms to Go Packaging Guidelines
Please fix the problems above.
https://bugzilla.redhat.com/show_bug.cgi?id=2233185
--- Comment #2 from W. Michael Petullo mike@flyn.org --- Wow, quick work on upstreaming the documentation change!
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-cc-4.spec SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-cc-4-4.13.2-1.fc38.src.rpm
- Package latest v4 version - Make use of upstreamed documentation change - Drop GO-LICENSE and README.md
https://bugzilla.redhat.com/show_bug.cgi?id=2233185
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2233185
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-cc-4
https://bugzilla.redhat.com/show_bug.cgi?id=2233185
W. Michael Petullo mike@flyn.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |ERRATA Last Closed| |2023-09-26 01:58:32
https://bugzilla.redhat.com/show_bug.cgi?id=2233185
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-f17646df46 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f17646df46
https://bugzilla.redhat.com/show_bug.cgi?id=2233185
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-f17646df46 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org