Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libverto - Main loop abstraction library
https://bugzilla.redhat.com/show_bug.cgi?id=752909
Summary: Review Request: libverto - Main loop abstraction library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nathaniel@natemccallum.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://npmccallum.fedorapeople.org/libverto/libverto.spec SRPM URL: http://npmccallum.fedorapeople.org/libverto/libverto-0.2.1-1.fc16.src.rpm
Description: libverto provides a way for libraries to expose asynchronous interfaces without having to choose a particular event loop, offloading this decision to the end application which consumes the library.
If you are packaging an application, not library, based on libverto, you should depend either on a specific implementation module or you can depend on the virtual provides 'libverto-module-base'. This will ensure that you have at least one module installed that provides io, timeout and signal functionality. Currently glib is the only module that does not provide these three because it lacks signal. However, glib will support signal in the future.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752909
--- Comment #1 from Nathaniel McCallum nathaniel@natemccallum.com 2011-11-10 14:01:40 EST --- Koji build against f17 available here: http://koji.fedoraproject.org/koji/taskinfo?taskID=3505386
Also, this package is a new dependency of mit krb5 1.10.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752909
Stephen Gallagher sgallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |sgallagh@redhat.com AssignedTo|nobody@fedoraproject.org |sgallagh@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752909
--- Comment #2 from Stephen Gallagher sgallagh@redhat.com 2011-11-10 16:46:09 EST --- [sgallagh@sgallagh520 review]$ rpmlint ~/rpmbuild/RPMS/x86_64/*.rpm libverto.x86_64: W: spelling-error %description -l en_US io -> oi, Io, ii libverto-devel.x86_64: W: no-documentation libverto-glib.x86_64: W: summary-not-capitalized C glib module for libverto libverto-glib.x86_64: W: no-documentation libverto-glib-devel.x86_64: W: no-documentation libverto-libev.x86_64: W: summary-not-capitalized C libev module for libverto libverto-libev.x86_64: W: spelling-error %description -l en_US io -> oi, Io, ii libverto-libev.x86_64: W: no-documentation libverto-libev-devel.x86_64: W: spelling-error %description -l en_US io -> oi, Io, ii libverto-libev-devel.x86_64: W: no-documentation libverto-libevent.x86_64: W: summary-not-capitalized C libevent module for libverto libverto-libevent.x86_64: W: no-documentation libverto-libevent-devel.x86_64: W: no-documentation libverto-tevent.x86_64: W: summary-not-capitalized C tevent module for libverto libverto-tevent.x86_64: W: spelling-error %description -l en_US io -> oi, Io, ii libverto-tevent.x86_64: W: no-documentation libverto-tevent-devel.x86_64: W: no-documentation 11 packages and 0 specfiles checked; 0 errors, 17 warnings.
MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
This is not met. The {?_isa} is missing.
So, fix that one minor issue and I will approve this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752909
--- Comment #3 from Nathaniel McCallum nathaniel@natemccallum.com 2011-11-11 12:34:46 EST --- Fixed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752909
--- Comment #4 from Nathaniel McCallum nathaniel@natemccallum.com 2011-11-11 13:23:03 EST --- Spec: http://npmccallum.fedorapeople.org/libverto/libverto.spec SRPM: http://npmccallum.fedorapeople.org/libverto/libverto-0.2.1-2.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3508201
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752909
Stephen Gallagher sgallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+, fedora-cvs?
--- Comment #5 from Stephen Gallagher sgallagh@redhat.com 2011-11-11 13:31:03 EST --- Package is approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752909
--- Comment #6 from Stephen Gallagher sgallagh@redhat.com 2011-11-11 13:32:44 EST --- New Package SCM Request ======================= Package Name: libverto Short Description: Main loop abstraction library Owners: npmccallum Branches: f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752909
--- Comment #7 from Jon Ciesla limb@jcomserv.net 2011-11-11 13:36:22 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752909
Nathaniel McCallum nathaniel@natemccallum.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE Last Closed| |2011-11-11 17:17:59
--- Comment #8 from Nathaniel McCallum nathaniel@natemccallum.com 2011-11-11 17:17:59 EST --- Thanks!
package-review@lists.fedoraproject.org