https://bugzilla.redhat.com/show_bug.cgi?id=1212699
Bug ID: 1212699 Summary: Review Request: mediawiki123-HTTP302Found - Forces an external HTTP 302 redirect instead of internal redirects Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: puiterwijk@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://puiterwijk.fedorapeople.org//mediawiki123-HTTP302Found.spec SRPM URL: http://puiterwijk.fedorapeople.org//mediawiki123-HTTP302Found-2.0.1-3.fc21.s...
Description: Pushes a HTTP code 302 (Found) to the browser when there is a redirect instead of handling it internally. The end user will not notice any difference (other than the address to the page having an ?rd=Redirecting_page bit at the end).
https://bugzilla.redhat.com/show_bug.cgi?id=1212699
--- Comment #1 from Patrick Uiterwijk puiterwijk@redhat.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9495628
Note: I'm only interrested in EPEL7, as the main package (mediawiki123) is also only for EPEL7. For Fedora, we have the main mediawiki package.
https://bugzilla.redhat.com/show_bug.cgi?id=1212699
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kevin@scrye.com Assignee|nobody@fedoraproject.org |kevin@scrye.com Flags| |fedora-review?
--- Comment #2 from Kevin Fenzi kevin@scrye.com --- I'll review this. Look for a full review in a bit...
https://bugzilla.redhat.com/show_bug.cgi?id=1212699
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Kevin Fenzi kevin@scrye.com --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: b6b5d50ae5b5b39a5590090e5f6e0bcb ../HTTP302Found-2.0.1.tar.gz
OK - BuildRequires correct OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK - No rpmlint output. 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
I see no issues with this package, so it's APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1212699
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1212699
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- mediawiki123-HTTP302Found-2.0.1-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/mediawiki123-HTTP302Found-2.0.1-3.el...
https://bugzilla.redhat.com/show_bug.cgi?id=1212699
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- mediawiki123-HTTP302Found-2.0.1-3.el7 has been pushed to the Fedora EPEL 7 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1212699
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |mediawiki123-HTTP302Found-2 | |.0.1-3.el7 Resolution|--- |ERRATA Last Closed| |2015-05-29 17:45:26
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- mediawiki123-HTTP302Found-2.0.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository.
package-review@lists.fedoraproject.org