https://bugzilla.redhat.com/show_bug.cgi?id=2332084
Bug ID: 2332084 Summary: Review Request: python-pytest-golden - Plugin for pytest that offloads expected outputs to data files Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/python-pytest-golden/python-pytest-... SRPM URL: https://dcavalca.fedorapeople.org/review/python-pytest-golden/python-pytest-...
Description: This package provides a plugin for pytest that offloads expected outputs to data files.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2332084
--- Comment #1 from Davide Cavalca davide@cavalca.name --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=126756741
https://bugzilla.redhat.com/show_bug.cgi?id=2332084
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2332078
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2332078 [Bug 2332078] Review Request: python-markdown-callouts - Markdown extension to provide a classier syntax for admonitions
https://bugzilla.redhat.com/show_bug.cgi?id=2332084
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |michel@michel-slm.name CC| |michel@michel-slm.name Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2332084
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/oprypin/ | |pytest-golden
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8384730 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packag...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2332084
Michel Lind michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Michel Lind michel@michel-slm.name --- Nit: please run %pytest -v instead of %pytest because it looks like upstream does not configure the tests to run verbosely by default
(so we don't see a list of tests being run)
Package was generated with pyp2spec, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the sotware is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with the Python Packaging Guidelines
Package APPROVED.
===
Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`:
- add @python-packagers-sig with "commit" access as package co-maintainer
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2332084
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-golden
https://bugzilla.redhat.com/show_bug.cgi?id=2332084
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-0c545848a1 (python-pytest-golden-0.2.2-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0c545848a1
https://bugzilla.redhat.com/show_bug.cgi?id=2332084
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-12-13 11:43:47
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-0c545848a1 (python-pytest-golden-0.2.2-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org