[Bug 2241989] New: Review Request: golang-fortio-assert - Minimalistic replacement for stretchr/testify/assert

https://bugzilla.redhat.com/show_bug.cgi?id=2241989

Bug ID: 2241989
           Summary: Review Request: golang-fortio-assert - Minimalistic
                    replacement for stretchr/testify/assert
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://solopasha.fedorapeople.org/for-review/golang-fortio-assert.spec
SRPM URL:
https://solopasha.fedorapeople.org/for-review/golang-fortio-assert-1.2.0-1.f...

Description:
Minimalistic replacement for
https://pkg.go.dev/github.com/stretchr/testify/assert.

Fedora Account System Username: solopasha

[Bug 2241989] Review Request: golang-fortio-assert - Minimalistic replacement for stretchr/testify/assert

https://bugzilla.redhat.com/show_bug.cgi?id=2241989

--- Comment #1 from Pavel Solovev  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=107025627

[Bug 2241989] Review Request: golang-fortio-assert - Minimalistic replacement for stretchr/testify/assert

https://bugzilla.redhat.com/show_bug.cgi?id=2241989

Pavel Solovev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2241991

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2241991
[Bug 2241991] Review Request: golang-fortio-sets - Sets and Set operations in
golang with helper/nicer names

[Bug 2241989] Review Request: golang-fortio-assert - Minimalistic replacement for stretchr/testify/assert

https://bugzilla.redhat.com/show_bug.cgi?id=2241989

Pavel Solovev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2241994

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2241994
[Bug 2241994] Review Request: golang-fortio-dflag - Golang Dynamic Flags

[Bug 2241989] Review Request: golang-fortio-assert - Minimalistic replacement for stretchr/testify/assert

https://bugzilla.redhat.com/show_bug.cgi?id=2241989

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1998778

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1998778
[Bug 1998778] Review Request: fortio - Fortio load testing library, command
line tool, advanced echo server and web UI in go (golang). Allows to specify a
set query-per-second load and record latency histograms and other useful stats

[Bug 2241989] Review Request: golang-fortio-assert - Minimalistic replacement for stretchr/testify/assert

https://bugzilla.redhat.com/show_bug.cgi?id=2241989

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #2 from Mikel Olasagasti Uranga  ---
spec has been created with go2rpm-1.9.0 and although it's correct, if you can
use the go2rpm-1.11.0 template it will be better for the future. This is the
diff, there are just some minimal changes:
> --- golang-fortio-assert.spec.1	2023-10-03 20:36:41.000000000 +0200
> +++ golang-fortio-assert.spec	2024-03-06 20:50:45.774730132 +0100
> @@ -1,4 +1,4 @@
> -# Generated by go2rpm 1.9.0
> +# Generated by go2rpm 1.10.0
>  %bcond_without check
>  %global debug_package %{nil}
>
> @@ -7,8 +7,7 @@
>  %global forgeurl        https://github.com/fortio/assert
>  Version:                1.2.0
>
> -%gometa -f
>
> +%gometa -L -f
>
> %global common_description %{expand:
>  Minimalistic replacement for
> @@ -17,7 +16,7 @@
>  %global golicenses      LICENSE
>  %global godocs          README.md
>
> -Name:           %{goname}
> +Name:           golang-fortio-assert
>  Release:        %autorelease
>  Summary:        Minimalistic replacement for stretchr/testify/assert
>
> @@ -30,7 +29,7 @@
>  %gopkg
>
> %prep
> -%goprep
> +%goprep -A
>  %autopatch -p1
>
> %generate_buildrequires

Please, update this and the other specs to the new template if possible.

I am not going to go through the whole fedora-review template, as this package
uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi
ticket.