[Bug 2335139] New: Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

Bug ID: 2335139
           Summary: Review Request: dmenu-wayland - An efficient dynamic
                    menu for wayland (wlroots)
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://wojnilowicz.fedorapeople.org/dmenu-wayland.spec
SRPM URL:
https://wojnilowicz.fedorapeople.org/dmenu-wayland-0.1%5E20241231.a380201-1....

Description:
An efficient dynamic menu for wayland (wlroots)

Fedora Account System Username: wojnilowicz

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged
                URL|                            |https://github.com/nyyManni
                   |                            |/dmenu-wayland

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8461129
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

wojnilowicz  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2335143

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2335143
[Bug 2335143] dmenu-wl not found on sway

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

Carlos Rodriguez-Fernandez  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carlosrodrifernandez@gmail.
                   |                            |com
           Doc Type|---                         |If docs needed, set a value
           Assignee|[e-mail]    |carlosrodrifernandez@gmail.
                   |                            |com
              Flags|                            |fedora-review?

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

Carlos Rodriguez-Fernandez  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

Carlos Rodriguez-Fernandez  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(lukasz.wojnilowic
                   |                            |[e-mail])

--- Comment #2 from Carlos Rodriguez-Fernandez  ---
Hi Lukasz,
The package is pretty complete.
I have one feedback, wouldn't you want to use pkgconfig instead?

$ diff -u dmenu-wayland.spec.orig dmenu-wayland.spec
--- dmenu-wayland.spec.orig     2025-01-01 15:40:07.432750735 -0700
+++ dmenu-wayland.spec  2025-01-01 16:03:38.828499401 -0700
@@ -13,12 +13,12 @@
 Source:         %{url}/archive/%{commit}/%{name}-%{short_commit}.tar.gz

BuildRequires:  gcc
-BuildRequires:  glib2-devel
+BuildRequires:  pkgconfig(glib-2.0)
 BuildRequires:  pango-devel
-BuildRequires:  cairo-devel
-BuildRequires:  libxkbcommon-devel
-BuildRequires:  wayland-devel
-BuildRequires:  wayland-protocols-devel
+BuildRequires:  pkgconfig(cairo)
+BuildRequires:  pkgconfig(xkbcommon)
+BuildRequires:  pkgconfig(wayland-client)
+BuildRequires:  pkgconfig(wayland-protocols)
 BuildRequires:  meson

%description

pango is the onle one that doesn't have one, but the rest do. This is the
reasoning behind it:
https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequ...

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

--- Comment #3 from Carlos Rodriguez-Fernandez  ---
I found that pango also has pkgconfig.

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

--- Comment #4 from Carlos Rodriguez-Fernandez  ---
Upstream meson build also expects that gobject-2.0, and pangocairo are provided
as well at build time, and there are pkg-configs for them both as well. That
way if something ever gets refactored in the actual packages providing those
dependencies, your package would not be affected.

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

wojnilowicz  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(lukasz.wojnilowic |
                   |[e-mail])                |

--- Comment #5 from wojnilowicz  ---
(In reply to Carlos Rodriguez-Fernandez from comment #2)
> Hi Lukasz,
> The package is pretty complete.
> I have one feedback, wouldn't you want to use pkgconfig instead?

Hi Carlos, sure. I learned something new. Thanks. I corrected the spec file
in-place. Could your approve now?

[fedora-review-service-build]

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

--- Comment #6 from Fedora Review Service  ---
Created attachment 2064545
  --> https://bugzilla.redhat.com/attachment.cgi?id=2064545&action=edit
The .spec file difference from Copr build 8461129 to 8464552

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

--- Comment #7 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8464552
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

--- Comment #8 from Carlos Rodriguez-Fernandez  ---
Thank you Lukasz!

Approved.

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

Carlos Rodriguez-Fernandez  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

Fedora Admin user for bugzilla script actions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RELEASE_PENDING

--- Comment #9 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/dmenu-wayland

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

--- Comment #10 from wojnilowicz  ---
Thanks to you too for the review :)

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RELEASE_PENDING             |MODIFIED

--- Comment #11 from Fedora Update System  ---
FEDORA-2025-8e0c872356 (dmenu-wayland-0.1^20241231.a380201-1.fc42) has been
submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-8e0c872356

[Bug 2335139] Review Request: dmenu-wayland - An efficient dynamic menu for wayland (wlroots)

https://bugzilla.redhat.com/show_bug.cgi?id=2335139

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2025-01-02 21:25:54

--- Comment #12 from Fedora Update System  ---
FEDORA-2025-8e0c872356 (dmenu-wayland-0.1^20241231.a380201-1.fc42) has been
pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.