https://bugzilla.redhat.com/show_bug.cgi?id=2259760
Bug ID: 2259760 Summary: Review Request: rust-oxipng - Lossless PNG compression optimizer Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: code@musicinmybrain.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Depends On: 2259758 Target Milestone: --- Classification: Fedora
Spec URL: https://music.fedorapeople.org/rust-oxipng.spec SRPM URL: https://music.fedorapeople.org/rust-oxipng-9.0.0-1.fc39.src.rpm
Description:
A lossless PNG compression optimizer.
Fedora Account System Username: music
PR to be merged after unretirement: https://src.fedoraproject.org/rpms/rust-oxipng/pull-request/1
Knowing this is sometimes a problem, I will check the changelog of the unretired package and make sure it is not broken.
COPR build (with fedora-review enabled): https://copr.fedorainfracloud.org/coprs/music/oxipng/build/6942075/
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2259758 [Bug 2259758] Review Request: rust-zopfli - Rust implementation of the Zopfli compression algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/ox | |ipng
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6942084 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2259760 Bug 2259760 depends on bug 2259758, which changed state.
Bug 2259758 Summary: Review Request: rust-zopfli - Rust implementation of the Zopfli compression algorithm https://bugzilla.redhat.com/show_bug.cgi?id=2259758
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value CC| |decathorpe@gmail.com Flags| |fedora-review+ Status|NEW |ASSIGNED
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass (there are no tests) - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
===
Note that the package includes a few files that should not be installed into the rust-oxipng-devel package:
- /scripts/ - /Dockerfile - /index.html
In particular, the files in the "scripts" folder cause the package to have a generated dependency on /usr/bin/bash.
Please exclude these two files and the "scripts" folder in some way from the -devel package. Option 1: Patching Cargo.toml to update the "exclude" list, or Option 2: Using the %exclude directive in the %files list. If you go with Option 1, that patch might be acceptable by upstream too. They already exclude benchmark and test sources, so they probably don't want to ship other development-only files either.
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
--- Comment #3 from Ben Beasley code@musicinmybrain.net --- Thank you for the review!
Regarding the extra files, I will go with Option 1 and offer the patch upstream.
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
--- Comment #4 from Ben Beasley code@musicinmybrain.net --- https://pagure.io/releng/issue/11960
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
--- Comment #5 from Ben Beasley code@musicinmybrain.net --- https://github.com/shssoichiro/oxipng/pull/591
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-c959cf9e20 (rust-oxipng-9.0.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c959cf9e20
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-02-17 12:26:52
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-c959cf9e20 (rust-oxipng-9.0.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-29e349ef66 (rust-oxipng-9.0.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-29e349ef66
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-29e349ef66 (rust-oxipng-9.0.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7fbc47eb79 (rust-oxipng-9.0.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7fbc47eb79
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-28c5dc0c42 (rust-oxipng-9.0.0-1.fc38) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-28c5dc0c42
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7fbc47eb79 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7fbc47eb79 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7fbc47eb79
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-28c5dc0c42 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-28c5dc0c42 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-28c5dc0c42
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-28c5dc0c42 (rust-oxipng-9.0.0-1.fc38) has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2259760
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7fbc47eb79 (rust-oxipng-9.0.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com