[Bug 2356940] New: Review Request: bootmac - Configures the MAC addresses of WLAN and Bluetooth interfaces at boot

https://bugzilla.redhat.com/show_bug.cgi?id=2356940

Bug ID: 2356940
           Summary: Review Request: bootmac - Configures the MAC addresses
                    of WLAN and Bluetooth interfaces at boot
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://samcday.fedorapeople.org/bootmac.spec
SRPM URL: https://samcday.fedorapeople.org/bootmac-0.6.0-1.fc43.src.rpm

Description:
Configures the MAC addresses of WLAN and Bluetooth interfaces at boot.

Fedora Account System Username: samcday

[Bug 2356940] Review Request: bootmac - Configures the MAC addresses of WLAN and Bluetooth interfaces at boot

https://bugzilla.redhat.com/show_bug.cgi?id=2356940

--- Comment #1 from Sam Day  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=131021522

[Bug 2356940] Review Request: bootmac - Configures the MAC addresses of WLAN and Bluetooth interfaces at boot

https://bugzilla.redhat.com/show_bug.cgi?id=2356940

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gitlab.postmarketos
                   |                            |.org/postmarketOS/bootmac/
           Keywords|                            |AutomationTriaged

--- Comment #2 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8853223
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2356940] Review Request: bootmac - Configures the MAC addresses of WLAN and Bluetooth interfaces at boot

https://bugzilla.redhat.com/show_bug.cgi?id=2356940

Alex Haydock  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Alex Haydock  ---
Hi!

I tried taking a look at this package as a non-binding review. I am not a
Fedora Packager yet, but as part of the pre-requisites to become one I am
trying to review existing packages in the queue to get familiar with the basics
and some of the philosophy behind various design decisions.

I spotted a few things so far in the current SPEC:

The line:
```
%global debug_package %{nil}
```

Should not be needed as the package is a `noarch` package without any ELF
objects with debuginfo, so there can be no debuginfo.

The `-p` flag should be used for `install` arguments to preserve timestamps,
e.g.:

```
install -Dpm755 bootmac -t %{buildroot}%{_bindir}/
```

At a package level, I'm not too familiar with the codebase here but I'm
wondering if there's a particular reason why the `bootmac-wifi.rules` from
upstream have been included, but the `bootmac-bluetooth.rules` equivalent for
Bluetooth has not?