https://bugzilla.redhat.com/show_bug.cgi?id=1917019
Bug ID: 1917019 Summary: Review request: vdr-mcli - DVB multicast stream client for the NetCeiver hardware for VDR Product: Fedora Version: rawhide Hardware: x86_64 OS: Linux Status: NEW Component: Package Review Severity: low Assignee: nobody@fedoraproject.org Reporter: pb@bieringer.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Full URLs to the spec file and source rpm of the package: ftp://ftp.bieringer.de/pub/tmp/vdr-mcli.spec ftp://ftp.bieringer.de/pub/tmp/vdr-mcli-0.9.4-2.fc33.src.rpm
A short description for the package: Multicast client plugin to access DVB-streams produced by the NetCeiver hardware for VDR
Why this package is not eligible to be included in Fedora
Potential user community of this RPM is too small to be included in Fedora, similar to other VDR plugins which are also available on rpmfusion and not in Fedora.
The output rpmlint gives on both the source and binary packages:
rpmlint /home/vdrdev/rpmbuild/RPMS/x86_64/vdr-mcli-0.9.4-2.fc33.x86_64.rpm vdr-mcli.x86_64: W: spelling-error Summary(en_US) multicast -> simulcast vdr-mcli.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast vdr-mcli.x86_64: W: spelling-error %description -l en_US pbiering -> piercing vdr-mcli.x86_64: W: no-manual-page-for-binary netcvdiag vdr-mcli.x86_64: W: no-manual-page-for-binary netcvlogview vdr-mcli.x86_64: W: no-manual-page-for-binary netcvupdate 1 packages and 0 specfiles checked; 0 errors, 6 warnings.
- spelling warnings: spell checker too strict, no proper sugestions - missing manual pages: not provided by upstream
rpmlint /home/vdrdev/rpmbuild/SRPMS/vdr-mcli-0.9.4-2.fc33.src.rpm vdr-mcli.src: W: spelling-error Summary(en_US) multicast -> simulcast vdr-mcli.src: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast vdr-mcli.src: W: spelling-error %description -l en_US pbiering -> piercing 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
-> see above
Fedora Account System Username: pbiering
https://bugzilla.redhat.com/show_bug.cgi?id=1917019
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mgansser@online.de Assignee|nobody@fedoraproject.org |mgansser@online.de Doc Type|--- |If docs needed, set a value
--- Comment #1 from MartinKG mgansser@online.de --- will take for review.
https://bugzilla.redhat.com/show_bug.cgi?id=1917019
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1917019
--- Comment #2 from MartinKG mgansser@online.de --- Please make sure that the package can also be created on the Koji Build Server with: $ koji build --scratch rawhide ../SRPMS/vdr-mcli-0.9.4-2.fc33.src.rpm
... ../common/defs.h:183:10: fatal error: zlib.h: No such file or directory 183 | #include <zlib.h> | ^~~~~~~~ compilation terminated.
... ../common/defs.h:232:10: fatal error: libxml/encoding.h: No such file or directory 232 | #include <libxml/encoding.h> | ^~~~~~~~~~~~~~~~~~~ compilation terminated.
please fix this by adding the necessary BR to your spec file.
BuildRequires: zlib-devel BuildRequires: libxml2-devel
https://bugzilla.redhat.com/show_bug.cgi?id=1917019
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1917019
--- Comment #3 from Peter Bieringer pb@bieringer.de --- sorry, had forgotten to create koji build in advance, now it's working: https://koji.fedoraproject.org/koji/taskinfo?taskID=59851402
https://bugzilla.redhat.com/show_bug.cgi?id=1917019
--- Comment #4 from MartinKG mgansser@online.de ---
rpmlint Checking: vdr-mcli-0.9.4-2.fc34.x86_64.rpm vdr-mcli-devel-0.9.4-2.fc34.x86_64.rpm vdr-mcli-debuginfo-0.9.4-2.fc34.x86_64.rpm vdr-mcli-debugsource-0.9.4-2.fc34.x86_64.rpm vdr-mcli-0.9.4-2.fc34.src.rpm vdr-mcli.x86_64: W: spelling-error Summary(en_US) multicast -> simulcast vdr-mcli.x86_64: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast vdr-mcli.x86_64: W: spelling-error %description -l en_US pbiering -> piercing vdr-mcli.x86_64: W: no-manual-page-for-binary netcvdiag vdr-mcli.x86_64: W: no-manual-page-for-binary netcvlogview vdr-mcli.x86_64: W: no-manual-page-for-binary netcvupdate vdr-mcli-devel.x86_64: W: spelling-error Summary(en_US) multicast -> simulcast vdr-mcli-devel.x86_64: E: summary-too-long C Header files for multicast client plugin to access DVB-streams produced by the NetCeiver hardware for VDR vdr-mcli-devel.x86_64: W: spelling-error %description -l en_US multicast -> simulcast vdr-mcli-devel.x86_64: W: spelling-error %description -l en_US pbiering -> piercing vdr-mcli-devel.x86_64: E: description-line-too-long C Header files for multicast client plugin to access DVB-streams produced by the NetCeiver hardware for VDR vdr-mcli-devel.x86_64: W: no-documentation vdr-mcli.src: W: spelling-error Summary(en_US) multicast -> simulcast vdr-mcli.src: W: spelling-error %description -l en_US Multicast -> Multics, Simulcast vdr-mcli.src: W: spelling-error %description -l en_US pbiering -> piercing 5 packages and 0 specfiles checked; 2 errors, 13 warnings.
Suggested fixes:
vdr-mcli-devel.x86_64: E: summary-too-long C Header files for multicast client plugin to access DVB-streams produced by the NetCeiver hardware for VDR vdr-mcli-devel.x86_64: E: description-line-too-long C Header files for multicast client plugin to access DVB-streams produced by the NetCeiver hardware for VDR
see fedora package guideline: https://fedoraproject.org/wiki/Common_Rpmlint_issues#description-line-too-lo...
https://bugzilla.redhat.com/show_bug.cgi?id=1917019
--- Comment #5 from Peter Bieringer pb@bieringer.de --- vdr-mcli-devel fixed now, overseen, sorry.
https://bugzilla.redhat.com/show_bug.cgi?id=1917019
--- Comment #6 from MartinKG mgansser@online.de --- think, that license field must include LGPLv2+ also
see HISTORY: 2010-06-23: - Moved the mcli-library to LGPL-2.1-license.
fix it to: License: GPLv2+ and LGPLv2+
https://bugzilla.redhat.com/show_bug.cgi?id=1917019
--- Comment #7 from MartinKG mgansser@online.de --- a nother issue:
the devel package includes only the following header file mcliheaders.h
$ rpm -ql vdr-mcli-devel /usr/include/vdr/mcliheaders.h
in this header file are following headers files included, but where are this header file in the rpm package ?
#include <mcast/common/defs.h> #include <mcast/common/version.h> #include <mcast/common/list.h> #include <mcast/common/satlists.h> #include <mcast/common/mcast.h> #include <mcast/common/recv_ccpp.h> #include <mcast/client/recv_tv.h> #include <mcast/client/mld_reporter.h> #include <mcast/client/tca_handler.h> #include <mcast/client/tra_handler.h> #include <mcast/common/tools.h> #include <mcast/client/api_server.h> #include <mcast/client/mmi_handler.h>
https://bugzilla.redhat.com/show_bug.cgi?id=1917019
--- Comment #8 from Peter Bieringer pb@bieringer.de --- License statement fixed in latest spec in ftp-server
regarding the vdr-mcli-devel, the only "external" used header file so found far is "mcliheaders.h" by the "vdr-netcv" plugin, other header files are only used inside the package to my knowledge.
https://bugzilla.redhat.com/show_bug.cgi?id=1917019
MartinKG mgansser@online.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2021-02-08 08:12:51
package-review@lists.fedoraproject.org