[Bug 730656] New: Review Request: perl-DateTime-Locale - Localization support for DateTime.pm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-DateTime-Locale - Localization support for DateTime.pm
https://bugzilla.redhat.com/show_bug.cgi?id=730656
Summary: Review Request: perl-DateTime-Locale - Localization support for DateTime.pm Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: iarnell@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://iarnell.home.xs4all.nl/review/perl-DateTime-Locale.spec SRPM URL: http://iarnell.home.xs4all.nl/review/perl-DateTime-Locale-0.45-1.fc17.src.rp... Description: DateTime::Locale is primarily a factory for the various locale sub-classes. It also provides some functions for getting information on all the available locales.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=730656
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |730658
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=730656
--- Comment #1 from Iain Arnell iarnell@gmail.com 2011-08-15 05:35:09 EDT --- Note that DateTime::Locale is currently bundled in perl-DateTime. Bug 730658 deals with the unbundling.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=730656
Petr Sabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com AssignedTo|nobody@fedoraproject.org |psabata@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=730656
Petr Sabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #2 from Petr Sabata psabata@redhat.com 2011-08-15 07:37:58 EDT --- Package: perl-DateTime-Locale Version: 0.45 Release: 1.fc17 Sources: DateTime-Locale-0.45.tar.gz Patches: ---------- Package successfully built in mock, fedora-rawhide-x86_64. Package successfully built in mock, fedora-rawhide-i386. Package successfully built in koji, dist-rawhide.
MUST items: [ OK ] Package does NOT include pre-built binaries or libraries [ OK ] Spec file is legible and written in American english [ OK ] Package successfully builds on at least one supported primary architecture [ -- ] All ExcludeArch tags valid, referencing proper bug reports [ OK ] Package obeys FHS (with _libexecdir and /srv exceptions) [ NOTE ] No errors reported by rpmlint [ OK ] Changelog present and properly formatted [ OK ] Package does NOT include Packager, Vendor, Copyright or PreReq tags [ OK ] Source tags are working URLs and sources match upstream or justified otherwise [ OK ] Requires correct or justified otherwise [ OK ] BuildRequires correct or justified otherwise [ OK ] All file names are in proper UTF-8 encoding [ OK ] All plain text failes are in proper UTF-8 encoding [ -- ] Large documentation files are located in doc subpackage [ OK ] All documentation prefixed with %doc [ OK ] Documentation is NOT executable [ OK ] No files in %doc are needed at run-time [ -- ] Compiler flags honor Fedora defaults or are justified [ -- ] Package generates useful debuginfo packages [ -- ] Header files are placed in devel subpackage [ -- ] Unversioned shared libraries are placed in devel subpackage [ -- ] Pkgconfig files are placed in devel subpackage [ -- ] Full-versioned Requires of the base package in subpackages [ -- ] Package calls ldconfig in post and postun sections for all subpackages, if applicable [ -- ] Static libraries are provided by static subpackage [ OK ] Package contains no static executables unless approved by FESCo [ OK ] Package does NOT bundle any system libraries [ -- ] RPath not used for anything besides internal libraries [ -- ] All config files are marked noreplace or justified otherwise [ OK ] No config files are located under /usr [ -- ] Package contains working systemd unit files and requires systemd-units [ -- ] All systemd unit files are named according to the Guidelines [ -- ] Package contains a SystemV-compatible initscript only as an optional addition to systemd unit files [ -- ] If package contains an initscript, it's placed in sysvinit subpackage [ -- ] A GUI application installs a proper desktop file [ -- ] All desktop files are installed by desktop-file-install or justified otherwise [ OK ] Package consistently uses macros [ -- ] makeinstall macro is used only if make install DESTDIR=%{buildroot} does NOT work [ -- ] Macros in Summary and description are expandable at build-time [ -- ] globals used in place of defines [ -- ] Locales handled correctly -- package requires gettext and uses find_lang, if applicable [ -- ] Scriptlets are sane [ OK ] Package is not relocatable unless justified [ OK ] Package contains only acceptable code or content [ OK ] Package owns all the files and directories it creates, installs and/or uses unless those are already owned by another package [ OK ] files sections do NOT contain duplicate files except for licenses [ NOTE ] Package does NOT cause any conflicts [ OK ] Package does NOT contain kernel modules [ OK ] Package does NOT bundle fonts or other general purpose data [ NOTE ] Final Requires and Provides are sane
SHOULD items: [ OK ] The Summary does NOT end with a period [ OK ] Package does NOT include BuildRoot tag, clean section or buildroot removal in install section [ OK ] Package should preserve files timestamps [ OK ] Package does NOT explicitly BuildRequire bash, bzip2, coreutils, cpio, diffutils, fedora-release, findutils, gawk, gcc, gcc-c++, grep, gzip, info, make, patch, redhat-rpm-config, rpm-build, sed, shadow-utils, tar, unzip, util-linux-ng, which or xz [ OK ] Description does NOT consist of lines longer than 80 characters [ -- ] Package uses parallel make [ -- ] In case of a web application, package installs date into /usr/share instead of /var/www [ -- ] All patches have a comment or an upstream bug link [ -- ] Package installs manpages for all executables [ OK ] Package contains check section and all tests pass [ ?? ] Package works as expected
NOTES: ------ NOTE: rpmlint reports incorrect FSF address again... let upstream know, please NOTE: The package conflicts with perl-DateTime; this is intentional NOTE: Add Requires: perl(Params::Validate) >= 0.91 for stricter dependencies
Anyhow, package is fine. Approving.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=730656
--- Comment #3 from Iain Arnell iarnell@gmail.com 2011-08-15 08:01:14 EDT --- (In reply to comment #2)
NOTE: rpmlint reports incorrect FSF address again... let upstream know, please
Upstream uses Dist-Zilla now, so should automatically get the correct license with the next release.
NOTE: Add Requires: perl(Params::Validate) >= 0.91 for stricter dependencies
Fedora 13 was released with perl-Params-Validate 0.95; every supported release already satisfies the dependency, so it's not really necessary. Only EL5 still has an older version, but this isn't at all likely to be pushed to EPEL.
Anyhow, package is fine. Approving.
Thanks for the review. Will wait for the rest of the bundle before proceeding.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=730656
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Iain Arnell iarnell@gmail.com 2011-08-18 08:36:14 EDT --- New Package SCM Request ======================= Package Name: perl-DateTime-Locale Short Description: Localization support for DateTime.pm Owners: iarnell Branches: f14 f15 f16 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=730656
--- Comment #5 from Jon Ciesla limb@jcomserv.net 2011-08-18 08:56:43 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=730656
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #6 from Iain Arnell iarnell@gmail.com 2011-08-18 12:09:44 EDT --- Imported and built for rawhide.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=730656
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Blocks| |730658 Depends on|730658 | Resolution| |RAWHIDE Last Closed| |2011-08-18 12:34:48
--- Comment #7 from Iain Arnell iarnell@gmail.com 2011-08-18 12:34:48 EDT --- Closing this. Track progress in bug 730658.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla