Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: mingw-gstreamer - MinGW Windows gstreamer library
https://bugzilla.redhat.com/show_bug.cgi?id=704635
Summary: Review Request: mingw-gstreamer - MinGW Windows gstreamer library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: tuxator@o2.pl QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://dl.dropbox.com/u/2448780/mingw-gstreamer.spec SRPM URL: http://dl.dropbox.com/u/2448780/mingw-gstreamer-0.10.32-1.fc15.src.rpm Description: MinGW Windows gstreamer library
This is my first package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
Paweł Forysiuk tuxator@o2.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora-mingw@lists.fedorapr | |oject.org Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
Kalev Lember kalev@smartlink.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lfarkas@lfarkas.org
--- Comment #1 from Kalev Lember kalev@smartlink.ee 2011-05-16 13:42:41 EDT --- *** Bug 491317 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
Kalev Lember kalevlember@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kalevlember@gmail.com AssignedTo|nobody@fedoraproject.org |kalevlember@gmail.com
--- Comment #2 from Kalev Lember kalevlember@gmail.com 2011-07-10 11:37:37 EDT --- Taking for review.
Note that you'll still need to find a sponsor. In order to convince a potential sponsor that you understand Fedora packaging guidelines, it would be a good idea to unofficially review at least one other package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
--- Comment #3 from Kalev Lember kalevlember@gmail.com 2011-07-10 11:47:16 EDT --- Koji rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3189548
The build failed with: gstelementfactory.c: In function 'gst_element_factory_create': gstelementfactory.c:393:8: error: size of array 'Compile_Time_Assertion' is negative gstelementfactory.c:393:8: error: invalid use of void expression gstelementfactory.c:393:8: error: incompatible type for argument 1 of '__sync_bool_compare_and_swap' make[4]: *** [libgstreamer_0.10_la-gstelementfactory.lo] Error 1
This is probably related to mingw32-gcc 4.6 update in rawhide and I'd expect it to be fixed in newer gstreamer releases. Can you update to 0.10.35?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
--- Comment #4 from Paweł Forysiuk tuxator@o2.pl 2011-07-16 13:29:51 EDT --- Updated for 0.10.35 Spec URL: http://dl.dropbox.com/u/2448780/mingw-gstreamer-0.10.35.spec SRPM URL: http://dl.dropbox.com/u/2448780/mingw-gstreamer-0.10.35-1.fc15.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
--- Comment #5 from Kalev Lember kalevlember@gmail.com 2011-07-16 14:23:09 EDT --- Fedora review mingw-gstreamer-0.10.35-1.fc15.src.rpm 2011-07-16
+ OK ! needs attention
rpmlint output: $ rpmlint mingw32-gstreamer \ mingw32-gstreamer-debuginfo-0.10.35-1.fc15.noarch.rpm \ mingw-gstreamer-0.10.35-1.fc15.src.rpm mingw32-gstreamer.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-gstreamer-0.10.35/COPYING mingw32-gstreamer-debuginfo.noarch: E: debuginfo-without-sources mingw-gstreamer.src:59: W: mixed-use-of-spaces-and-tabs (spaces: line 8, tab: line 59) 3 packages and 0 specfiles checked; 2 errors, 1 warnings.
! Please fix the mixed-use-of-spaces-and-tabs warning to make rpmlint happier. Other errors and warnings are harmless. + The package is named according to Fedora MinGW packaging guidelines ! The spec file name MUST match the base package name. The spec file name in the SRPM matches the package base name, but the one in dropbox is named 'mingw-gstreamer-0.10.35.spec'. Make sure that the spec file is named 'mingw-gstreamer.spec' when you import the package. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The stated license is the same as the one for the corresponding native Fedora package + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: 4a0a00edad7a2c83de5211ca679dfaf9 gstreamer-0.10.35.tar.bz2 4a0a00edad7a2c83de5211ca679dfaf9 Download/gstreamer-0.10.35.tar.bz2 + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane + The spec file MUST handle locales properly n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Fedora MinGW guidelines allow headers in main package n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files Fedora MinGW guidelines allow .la files n/a Packages containing GUI apps must include %{name}.desktop file + Directory ownership sane + Filenames are valid UTF-8
Issues: ! Would be nice to clean up the rpmlint warning about mixed-use-of-spaces-and-tabs ! Make sure you use the name the spec file 'mingw-gstreamer.spec' when importing the package. ! The following 3 lines are not needed on F15 and above and can be removed, unless you plan to build the package also for F14: %global _use_internal_dependency_generator 0 %global __find_requires %{_mingw32_findrequires} %global __find_provides %{_mingw32_findprovides}
Very nice work for first package, keep up the good work!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
--- Comment #6 from Paweł Forysiuk tuxator@o2.pl 2011-07-16 16:20:15 EDT --- Removed unneded macros and fixed use of tabs Spec URL: http://dl.dropbox.com/u/2448780/mingw-gstreamer.spec SRPM URL: http://dl.dropbox.com/u/2448780/mingw-gstreamer-0.10.35-2.fc15.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
Kalev Lember kalevlember@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #7 from Kalev Lember kalevlember@gmail.com 2011-07-16 16:35:39 EDT --- Looks good.
I'll mark the review as APPROVED (fedora-review+ flag), but you'll need a sponsor before you can import the package. I would suggest to do a review of some other package to show sponsors that you understand packaging guidelines and know how to review other packages.
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#R... http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
Paweł Forysiuk tuxator@o2.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
Paweł Forysiuk tuxator@o2.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Flag| |fedora-cvs?
--- Comment #8 from Paweł Forysiuk tuxator@o2.pl 2011-07-19 10:03:51 EDT --- New Package SCM Request ======================= Package Name: mingw-gstreamer Short Description: MinGW Windows gstreamer library Owners: pfor epienbro Branches: f15 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
--- Comment #9 from Jon Ciesla limb@jcomserv.net 2011-07-19 10:30:07 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-07-19 13:09:04 EDT --- mingw-gstreamer-0.10.35-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/mingw-gstreamer-0.10.35-2.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-07-22 15:36:22 EDT --- mingw-gstreamer-0.10.35-2.fc15 has been pushed to the Fedora 15 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-08-01 21:55:51 EDT --- mingw-gstreamer-0.10.35-2.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704635
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |mingw-gstreamer-0.10.35-2.f | |c15 Resolution| |ERRATA Last Closed| |2011-08-01 21:55:57
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla