[Bug 2132377] New: Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra integration with the fig shell

https://bugzilla.redhat.com/show_bug.cgi?id=2132377

Bug ID: 2132377
           Summary: Review Request:
                    golang-github-withfig-autocomplete-tools-integrations-
                    cobra - Cobra integration with the fig shell
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools-in...
SRPM URL:
https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools-in...
Description: Fig's integration with popular CLI framework Cobra.
Fedora Account System Username: anthr76

[Bug 2132377] Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra integration with the fig shell

https://bugzilla.redhat.com/show_bug.cgi?id=2132377

Anthony Rabbito  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
             Blocks|                            |2130734

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2130734
[Bug 2130734] Review Request: Chezmoi - Manage your dotfiles across multiple
diverse machines, securely.

[Bug 2132377] Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra integration with the fig shell

https://bugzilla.redhat.com/show_bug.cgi?id=2132377

--- Comment #1 from Anthony Rabbito  ---
Updated spec with `gosourcedir0`

Spec URL:
https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools-in...
SRPM URL:
https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools-in...

[Bug 2132377] Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra integration with the fig shell

https://bugzilla.redhat.com/show_bug.cgi?id=2132377

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #2 from Mikel Olasagasti Uranga  ---
Spec is correct, but there is one issue with the README.md files, as you've two
and it complains about duplicated file.

You can fix this by doing in %prep something like `mv
integrations/cobra/README.md README-cobra.md` and adjust `%global godocs` to
the new name.

[Bug 2132377] Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra integration with the fig shell

https://bugzilla.redhat.com/show_bug.cgi?id=2132377

--- Comment #3 from Anthony Rabbito  ---
Good catch :-)

I also added
> autorelease -p

The licenses was also an issue.

Spec URL:
https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools-in...
SRPM URL:
https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools-in...

[Bug 2132377] Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra integration with the fig shell

https://bugzilla.redhat.com/show_bug.cgi?id=2132377

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

--- Comment #4 from Mikel Olasagasti Uranga  ---
thanks for fixing also the Liencese and autorelease parts.

go2rpm package that requires changing gosourcedir0:

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi
ticket.

[Bug 2132377] Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra integration with the fig shell

https://bugzilla.redhat.com/show_bug.cgi?id=2132377

--- Comment #5 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-withfig-autocomplete-tools-...

[Bug 2132377] Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra integration with the fig shell

https://bugzilla.redhat.com/show_bug.cgi?id=2132377

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

--- Comment #6 from Fedora Update System  ---
FEDORA-2022-006cf951f8 has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2022-006cf951f8

[Bug 2132377] Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra integration with the fig shell

https://bugzilla.redhat.com/show_bug.cgi?id=2132377

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2022-10-13 17:54:03

--- Comment #7 from Fedora Update System  ---
FEDORA-2022-006cf951f8 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.