[Bug 690569] New: Review Request: perl-Task-Perl-Critic - Install everything Perl::Critic
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-Task-Perl-Critic - Install everything Perl::Critic
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Summary: Review Request: perl-Task-Perl-Critic - Install everything Perl::Critic Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: ppisar@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://ppisar.fedorapeople.org/perl-Task-Perl-Critic/perl-Task-Perl-Critic.s... SRPM URL: http://ppisar.fedorapeople.org/perl-Task-Perl-Critic/perl-Task-Perl-Critic-1... Description: This module does nothing but act as a placeholder. See Task.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |690566
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |672561, 672629, 673197, | |672811, 673099, 672582, | |672832, 672574, 673116
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |690580
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Petr Sabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com AssignedTo|nobody@fedoraproject.org |psabata@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |690746
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |690751
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
--- Comment #1 from Petr Pisar ppisar@redhat.com 2011-03-25 06:37:14 EDT --- New package fixing a run-time dependency version published:
Spec URL: http://ppisar.fedorapeople.org/perl-Task-Perl-Critic/perl-Task-Perl-Critic.s... SRPM URL: http://ppisar.fedorapeople.org/perl-Task-Perl-Critic/perl-Task-Perl-Critic-1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Bug 690569 depends on bug 672832, which changed state.
Bug 672832 Summary: Review Request: perl-Perl-Critic-PetPeeves-JTRAMMELL - Policies to prohibit/require my pet peeves https://bugzilla.redhat.com/show_bug.cgi?id=672832
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Bug 690569 depends on bug 690746, which changed state.
Bug 690746 Summary: Review Request: perl-Perl-Critic-Swift - Set of additional policies for Perl::Critic https://bugzilla.redhat.com/show_bug.cgi?id=690746
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Bug 690569 depends on bug 673099, which changed state.
Bug 673099 Summary: Review Request: perl-Perl-Critic-Lax - Policies that let you slide on common exceptions https://bugzilla.redhat.com/show_bug.cgi?id=673099
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Bug 690569 depends on bug 690751, which changed state.
Bug 690751 Summary: Review Request: perl-criticism - Perl pragma to enforce coding standards and best-practices https://bugzilla.redhat.com/show_bug.cgi?id=690751
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Bug 690569 depends on bug 690566, which changed state.
Bug 690566 Summary: Review Request: perl-Perl-Critic-StricterSubs - Perl::Critic plugin for stricter subroutine checks https://bugzilla.redhat.com/show_bug.cgi?id=690566
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Bug 690569 depends on bug 672561, which changed state.
Bug 672561 Summary: Review Request: perl-Perl-Critic-Pulp - Some add-on perlcritic policies https://bugzilla.redhat.com/show_bug.cgi?id=672561
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Bug 690569 depends on bug 690580, which changed state.
Bug 690580 Summary: Review Request: perl-Perl-Critic-More - Supplemental policies for Perl::Critic https://bugzilla.redhat.com/show_bug.cgi?id=690580
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Bug 690569 depends on bug 672629, which changed state.
Bug 672629 Summary: Review Request: perl-Perl-Critic-Tics - Policies for things that make me wince https://bugzilla.redhat.com/show_bug.cgi?id=672629
What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
--- Comment #2 from Petr Sabata psabata@redhat.com 2011-05-26 04:59:30 EDT --- Package: perl-Task-Perl-Critic Version: 1.007 Release: 1.fc16 Sources: Task-Perl-Critic-1.007.tar.gz Patches: ---------- Package successfully built in mock, fedora-15-x86_64. Package successfully built in mock, fedora-15-i386. Package successfully built in koji, dist-rawhide.
MUST items: [ OK ] Package does NOT include pre-built binaries or libraries [ OK ] Spec file is legible and written in American english [ OK ] Package successfully builds on at least one supported primary architecture [ -- ] All ExcludeArch tags valid, referencing proper bug reports [ NOTE ] Package obeys FHS (with _libexecdir and /srv exceptions) [ NOTE ] No errors reported by rpmlint [ OK ] Changelog present and properly formatted [ OK ] Package does NOT include Packager, Vendor, Copyright or PreReq tags [ OK ] Source tags are working URLs and sources match upstream or justified otherwise [ OK ] Requires correct or justified otherwise [ OK ] BuildRequires correct or justified otherwise [ OK ] All file names are in proper UTF-8 encoding [ OK ] All plain text failes are in proper UTF-8 encoding [ -- ] Large documentation files are located in doc subpackage [ OK ] All documentation prefixed with %doc [ OK ] Documentation is NOT executable [ OK ] No files in %doc are needed at run-time [ -- ] Compiler flags honor Fedora defaults or are justified [ -- ] Package generates useful debuginfo packages [ -- ] Header files are placed in devel subpackage [ -- ] Unversioned shared libraries are placed in devel subpackage [ -- ] Pkgconfig files are placed in devel subpackage [ -- ] Full-versioned Requires of the base package in subpackages [ -- ] Package calls ldconfig in post and postun sections for all subpackages, if applicable [ -- ] Static libraries are provided by static subpackage [ OK ] Package contains no static executables unless approved by FESCo [ OK ] Package does NOT bundle any system libraries [ -- ] RPath not used for anything besides internal libraries [ -- ] All config files are marked noreplace or justified otherwise [ OK ] No config files are located under /usr [ -- ] Package contains a SystemV-compatible initscript [ -- ] A GUI application installs a proper desktop file [ -- ] All desktop files are installed by desktop-file-install or justified otherwise [ OK ] Package consistently uses macros [ -- ] makeinstall macro is used only if make install DESTDIR=%{buildroot} does NOT work [ -- ] Macros in Summary and description are expandable at build-time [ -- ] globals used in place of defines [ -- ] Locales handled correctly -- package requires gettext and uses find_lang, if applicable [ -- ] Scriptlets are sane [ OK ] Package is not relocatable unless justified [ OK ] Package contains only acceptable code or content [ OK ] Package owns all the files and directories it creates, installs and/or uses unless those are already owned by another package [ OK ] files sections do NOT contain duplicate files except for licenses [ OK ] Package does NOT cause any conflicts [ OK ] Package does NOT contain kernel modules [ OK ] Package does NOT bundle fonts or other general purpose data [ OK ] Final Requires and Provides are sane
SHOULD items: [ OK ] The Summary does NOT end with a period [ FAIL ] Package does NOT include BuildRoot tag, clean section or buildroot removal in install section [ OK ] Package should preserve files timestamps [ OK ] Package does NOT explicitly BuildRequire bash, bzip2, coreutils, cpio, diffutils, fedora-release, findutils, gawk, gcc, gcc-c++, grep, gzip, info, make, patch, redhat-rpm-config, rpm-build, sed, shadow-utils, tar, unzip, util-linux-ng, which or xz [ OK ] Description does NOT consist of lines longer than 80 characters [ -- ] Package uses parallel make [ -- ] In case of a web application, package installs date into /usr/share instead of /var/www [ -- ] All patches have a comment or an upstream bug link [ -- ] Package installs manpages for all executables [ OK ] Package contains check section and all tests pass [ -- ] Package works as expected
NOTES: ------ 1. rpmlint reports wrong FSF address; there's nothing much you could do about it. 2. Please, install the package to vendor directory until Perl SIG really decides which way to go. 3. It seems like you forgot to remove the BuildRoot tag (it doesn't seem intentional since there's no %clean section). 4. %defattr is no longer needed but it's up to you, just mentioning.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
--- Comment #3 from Petr Pisar ppisar@redhat.com 2011-05-26 09:18:12 EDT --- Updated package is on following locators:
Spec URL: http://ppisar.fedorapeople.org/perl-Task-Perl-Critic/perl-Task-Perl-Critic.s... SRPM URL: http://ppisar.fedorapeople.org/perl-Task-Perl-Critic/perl-Task-Perl-Critic-1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Petr Sabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Petr Sabata psabata@redhat.com 2011-05-31 04:14:51 EDT --- --- a/perl-Task-Perl-Critic.spec +++ b/perl-Task-Perl-Critic.spec @@ -6,7 +6,6 @@ License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/Task-Perl-Critic/ Source0: http://www.cpan.org/authors/id/E/EL/ELLIOTJS/Task-Perl-Critic-%%7Bversion%7D... -BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildArch: noarch BuildRequires: perl(Module::Build) # Other requires from META.yml are not needed at build and check time. There @@ -40,7 +39,7 @@ This module does nothing but act as a placeholder. See Task. %setup -q -n Task-Perl-Critic-%{version}
%build -%{__perl} Build.PL installdirs=core +%{__perl} Build.PL installdirs=vendor ./Build
%install @@ -52,9 +51,8 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ; ./Build test
%files -%defattr(-,root,root,-) %doc Changes LICENSE README -%{perl_privlib}/* +%{perl_vendorlib}/* %{_mandir}/man3/*
%changelog @@ -63,5 +61,5 @@ find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ; - Do not BuildRequire run-time dependencies, they are not used at build and check time indeed. - Remove BuildRoot stuff -- Install into perl core directory +- Remove explicit defattr
--
Approving.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
--- Comment #5 from Petr Pisar ppisar@redhat.com 2011-05-31 05:02:00 EDT --- New Package SCM Request ======================= Package Name: perl-Task-Perl-Critic Short Description: Install everything Perl::Critic Owners: ppisar mmaslano psabata Branches: InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
--- Comment #6 from Jason Tibbitts tibbs@math.uh.edu 2011-05-31 15:15:29 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690569
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Task-Perl-Critic-1.007 | |-1.fc16 Resolution| |RAWHIDE Last Closed| |2011-06-01 03:32:40
--- Comment #7 from Petr Pisar ppisar@redhat.com 2011-06-01 03:32:40 EDT --- Thank you for the review and the repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla