[Bug 821802] New: Review Request: erlang-erlando - A set of syntax extensions for Erlang - package-review

List overview All Threads
Download

newer

[Bug 821802] New: Review Request: erlang-erlando - A set of syntax extensions for Erlang

older

[Bug 458952] Review Request: sems...

[Bug 217229] Review Request:...

Red Hat Bugzilla

15 May 2012 15 May '12

9:13 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Summary: Review Request: erlang-erlando - A set of syntax extensions for Erlang Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lemenkov@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---

Spec URL: http://peter.fedorapeople.org/erlang-erlando.spec SRPM URL: http://peter.fedorapeople.org/erlang-erlando-2.8.2-1.fc18.src.rpm Description: A set of syntax extensions for Erlang.

Koji scratchbuild for F-18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4078450

sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/erlang-erlando-2.8.2-1.fc18.ppc.rpm ../SRPMS/erlang-erlando-2.8.2-1.fc18.src.rpm erlang-erlando.ppc: E: explicit-lib-dependency erlang-stdlib

^^^ this one is a false positive (stdlib as a trigger)

erlang-erlando.ppc: E: no-binary erlang-erlando.ppc: W: only-non-binary-in-usr-lib

^^^ this one is tricky. All erlang packages must be installed into %{_libdir}/erlang/lib so despite of the fact that some of them contains only arch-independent data they all must be build as arch-dependent. I plan to fix than but I wouldn't hold my breath.

erlang-erlando.src: W: strange-permission rebar 0764L

^^^ minor issue. I'll report upstream.

erlang-erlando.src: W: invalid-url Source0: rabbitmq-erlando-rabbitmq_v2_8_2-0-g002ce5e.tar.gz

^^^ blame github for that, not me.

2 packages and 0 specfiles checked; 2 errors, 3 warnings. sulaco ~/rpmbuild/SPECS:

This app is growing popularity among Erlang developers quite fast (I'm using it as well).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

16 May 16 May

5:57 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Brendan Jones brendan.jones.it@gmail.com changed:

--- Comment #1 from Brendan Jones brendan.jones.it@gmail.com 2012-05-16 06:57:23 EDT --- I'll take this on

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:57 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Brendan Jones brendan.jones.it@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

18 May 18 May

4:50 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #2 from Brendan Jones brendan.jones.it@gmail.com 2012-05-18 05:50:06 EDT --- I note cut.erl and do.erl are licensed with ERPL while the others seem to be Mozilla public license. I believe you need to state this in the License tag.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:55 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #3 from Peter Lemenkov lemenkov@gmail.com 2012-05-18 05:55:50 EDT --- (In reply to comment #2)

...

I note cut.erl and do.erl are licensed with ERPL while the others seem to be Mozilla public license. I believe you need to state this in the License tag.

Yep, good catch.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:13 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #4 from Peter Lemenkov lemenkov@gmail.com 2012-05-18 06:13:18 EDT --- Fixed licensing info:

http://peter.fedorapeople.org/erlang-erlando.spec http://peter.fedorapeople.org/erlang-erlando-2.8.2-2.fc18.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:16 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Brendan Jones brendan.jones.it@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #5 from Brendan Jones brendan.jones.it@gmail.com 2012-05-18 07:16:33 EDT --- This package is APPROVED

Package Review ==============

Key: - = N/A x = Pass ! = Fail ? = Not evaluated

==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [-]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 [-]: MUST Large documentation files are in a -doc subpackage, if required. [-]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint output is silent.

rpmlint erlang-erlando-2.8.2-1.fc18.src.rpm

erlang-erlando.src: W: strange-permission rebar 0764L erlang-erlando.src: W: invalid-url Source0: rabbitmq-erlando-rabbitmq_v2_8_2-0-g002ce5e.tar.gz 1 packages and 0 specfiles checked; 0 errors, 2 warnings.

rpmlint erlang-erlando-2.8.2-1.fc18.i686.rpm

erlang-erlando.i686: E: explicit-lib-dependency erlang-stdlib erlang-erlando.i686: E: no-binary erlang-erlando.i686: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 2 errors, 1 warnings.

[x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. Package has no sources or they are generated by developer [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [-]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define.

Issues: [x]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf is only needed if supporting EPEL5 See: None [x]: MUST Rpmlint output is silent.

rpmlint erlang-erlando-2.8.2-1.fc18.src.rpm

rpmlint erlang-erlando-2.8.2-1.fc18.i686.rpm

See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint

Generated by fedora-review 0.1.3 External plugins:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:16 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Brendan Jones brendan.jones.it@gmail.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:17 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Brendan Jones brendan.jones.it@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:23 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Peter Lemenkov lemenkov@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #6 from Peter Lemenkov lemenkov@gmail.com 2012-05-18 07:23:58 EDT --- Thanks!

New Package SCM Request ======================= Package Name: erlang-erlando Short Description: A set of syntax extensions for Erlang Owners: peter Branches: el5 el6 f16 f17 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

19 May 19 May

1:36 p.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #7 from Jason Tibbitts tibbs@math.uh.edu 2012-05-19 14:36:46 EDT --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

20 May 20 May

1:22 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

1:23 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- erlang-erlando-2.8.2-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/erlang-erlando-2.8.2-2.fc16

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

1:23 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- erlang-erlando-2.8.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/erlang-erlando-2.8.2-2.el6

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

1:23 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- erlang-erlando-2.8.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/erlang-erlando-2.8.2-2.fc17

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

12:58 p.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- erlang-erlando-2.8.2-2.el6 has been pushed to the Fedora EPEL 6 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

29 May 29 May

5:22 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Fedora Update System updates@fedoraproject.org changed:

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- erlang-erlando-2.8.2-2.fc16 has been pushed to the Fedora 16 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

5:35 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- erlang-erlando-2.8.2-2.fc17 has been pushed to the Fedora 17 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

5 Jun 5 Jun

12:03 p.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- erlang-erlando-2.8.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

28 Jun 28 Jun

10:22 p.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- erlang-erlando-2.8.2-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/erlang-erlando-2.8.2-2.el5

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

15 Jul 15 Jul

1:25 p.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- erlang-erlando-2.8.2-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

13 Mar 13 Mar

5:48 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Peter Lemenkov lemenkov@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?

--- Comment #17 from Peter Lemenkov lemenkov@gmail.com --- Package Change Request ====================== Package Name: erlang-erlando New Branches: epel7 Owners: peter InitialCC: erlang-sig

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:56 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6:56 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #18 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:24 a.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

--- Comment #19 from Fedora Update System updates@fedoraproject.org --- erlang-erlando-2.8.7-4.gite3f115b.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/erlang-erlando-2.8.7-4.gite3f115b.el...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

31 Mar 31 Mar

8:54 p.m.

New subject: [Bug 821802] Review Request: erlang-erlando - A set of syntax extensions for Erlang

https://bugzilla.redhat.com/show_bug.cgi?id=821802

Fedora Update System updates@fedoraproject.org changed:

--- Comment #20 from Fedora Update System updates@fedoraproject.org --- erlang-erlando-2.8.7-4.gite3f115b.el7 has been pushed to the Fedora EPEL 7 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3766

Age (days ago)

4817

Last active (days ago)

package-review@lists.fedoraproject.org

25 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla