[Bug 754092] New: Review Request: python-restauth - Python RestAuth reference implementation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-restauth - Python RestAuth reference implementation
https://bugzilla.redhat.com/show_bug.cgi?id=754092
Summary: Review Request: python-restauth - Python RestAuth reference implementation Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jkaluza@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://jkaluza.fedorapeople.org/python-restauth.spec SRPM URL: http://jkaluza.fedorapeople.org/python-restauth-0.5.1-1.fc15.src.rpm Description:
Hi, I've finished packaging of python-mimeparse Python module. This module implements all features of the RestAuth specification and is a reference implementation. It is written in pure python. It generally works with python 2.6 or later (including python3).
It depends on python-restauth-common: https://bugzilla.redhat.com/show_bug.cgi?id=754088 Consider reviewing also python-restauth-common before reviewing this package please.
$ rpmlint python-restauth-0.5.1-1.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint python-restauth-0.5.1-1.fc15.noarch.rpm python3-restauth-0.5.1-1.fc15.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754092
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jskarvad@redhat.com AssignedTo|nobody@fedoraproject.org |jskarvad@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754092
--- Comment #1 from Jaroslav Škarvada jskarvad@redhat.com 2011-11-21 08:08:29 EST --- MUST items: [YES] rpmplint is silent [YES] Package meets naming guidelines. [YES] Package meets packaging guidelines I am not sure about the API/ABI compatibility policy of this project. Shouldn't be there version requirement for python-restauth-common? [YES] Spec file matches base package name. [YES] License file is present, matching with spec file. [YES] Licensing Guidelines are met. [!] Spec file is legible and in American English. I would prefer summary like: "Reference implementation of RestAuth specification in Python" or similar
I would tune the description a bit. I wouldn't note the python versions there and I would probably re-word the text. Maybe you could also very briefly describe what the RestAuth is (e.g. "The RestAuth project is a system providing shared authentication, authorization and preferences."). [YES] Sources match upstream. [YES] Package builds OK. [!] BuildRequires are correct. I cannot find the python-setuptools-devel in rawhide. Is the python-setuptools really needed? It seems to build OK without it.
[YES] Package doesn't bundle copies of system libraries. [YES] Package owns all the directories it creates. [YES] Package has no duplicity in %files. [YES] Permission on files are set properly. [NO] Spec file has consistant macro usage. Please use %{optflags} instead of $RPM_OPT_FLAGS or $RPM_BUILD_ROOT instead of %{buildroot}. [YES] Package is code or permissible content. [YES] %doc files don't affect runtime. [YES] Package doesn't own files/directories that other packages own. [YES] Spec file is valid UTF-8.
Should items: [YES] Package builds in mock. [YES] Package uses sane scriptlets.
Some more comments: There is extra space in the second %doc (only cosmetic issue :)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} is probably not needed any more.
The defattr is also not needed.
AFAIK the above have only sense if it is planned to package for RHEL-5 EPEL. If so there should be also more additions (e.g. %clean section, ...).
Please consider running the included test-suite as a part of the build process.
Please consider packaging the docs.
Please consider packaging the example script.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754092
--- Comment #2 from Mathias Ertl mati@fsinf.at 2011-11-21 08:36:15 EST --- Version 0.5.1 of python-restauth depends on python-restauth-common >= 0.5.1. (The versions are not by definition the same, they just happen to coincide).
greetings, Mati
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754092
--- Comment #3 from Jan Kaluža jkaluza@redhat.com 2011-11-30 02:17:57 EST --- Fixed specfile and srpm:
Spec URL: http://jkaluza.fedorapeople.org/python-restauth.spec SRPM URL: http://jkaluza.fedorapeople.org/python-restauth-0.5.1-2.fc16.src.rpm
I think all problems should be fixed. test-suite is not run, because it's currently broken. Upstream has been informed and I will use it when it will work again.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754092
--- Comment #4 from Jaroslav Škarvada jskarvad@redhat.com 2011-11-30 08:13:43 EST --- Is the BuildRequires: python3-setuptools needed? It seems to build OK without it. Also consider packaging demo script from examples (its shebang would probably require tweaking).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754092
--- Comment #5 from Jan Kaluža jkaluza@redhat.com 2011-12-01 04:10:59 EST --- Fixed specfile and srpm:
Spec URL: http://jkaluza.fedorapeople.org/python-restauth.spec SRPM URL: http://jkaluza.fedorapeople.org/python-restauth-0.5.1-3.fc16.src.rpm
Examples should be included and setuptools removed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754092
Jaroslav Škarvada jskarvad@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Flag| |fedora-review+
--- Comment #6 from Jaroslav Škarvada jskarvad@redhat.com 2011-12-01 07:50:40 EST --- Looks OK to me, giving fedora_review +. You could use the sed -i, to simplify the code for shebang removal.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754092
Jan Kaluža jkaluza@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Jan Kaluža jkaluza@redhat.com 2011-12-02 11:54:08 EST --- New Package SCM Request ======================= Package Name: python-restauth Short Description: reference implementation of RestAuth specification in Python Owners: jkaluza Branches: f15 f16 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754092
--- Comment #8 from Jon Ciesla limb@jcomserv.net 2011-12-02 11:55:11 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754092
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-12-05 04:48:22 EST --- python-restauth-0.5.1-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-restauth-0.5.1-3.fc16
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754092
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-12-05 20:04:31 EST --- python-restauth-0.5.1-3.fc16 has been pushed to the Fedora 16 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754092
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |python-restauth-0.5.1-3.fc1 | |6 Resolution| |ERRATA Last Closed| |2011-12-13 16:51:58
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-12-13 16:51:58 EST --- python-restauth-0.5.1-3.fc16 has been pushed to the Fedora 16 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla