[Bug 225734] New: Merge Review: esound

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225734

Summary: Merge Review: esound
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: esound

http://cvs.fedora.redhat.com/viewcvs/devel/esound/
Initial Owner: [e-mail]

[Bug 225734] Merge Review: esound

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: esound

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225734

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]            |[e-mail]

------- Additional Comments From [e-mail]  2007-02-08 06:10 EST -------
New Initial Owner: [e-mail]

[Bug 225734] Merge Review: esound

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225734

Toshio Ernie Kuratomi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #2 from Toshio Ernie Kuratomi   2009-04-24 06:28:45 EDT ---
Adding lennart as he's the current package owner.

[Bug 225734] Merge Review: esound

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225734

--- Comment #3 from Lennart Poettering   2009-04-24 11:09:27 EDT ---
Uh? What is this about?

[Bug 225734] Merge Review: esound

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225734

--- Comment #4 from Toshio Ernie Kuratomi   2009-04-24 12:26:10 EDT ---
You've done regular reviews before for pulseaudio stuff to get into the distro.
 A merge review is a review being done on a package that got pulled in from
Fedora Core without a review.

Until a reviewer picks this up, it's basically business as usual.  Once a
reviewer does start reviewing the package, someone needs to address the issues,
answer questions, and apply the changes from the review to the package in cvs. 
That's usually the package owner which is why I CC'd you.

Note that because we don't have enough reviewers, merge reviews have been
getting short shrift compared to new review requests.  At some point FESCo
might give us a deadline for having the merge reviews done but that hasn't
occurred yet.

[Bug 225734] Merge Review: esound

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225734

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail],
                   |                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #5 from Jon Ciesla  2012-04-06 11:24:38 EDT ---
Adding mclasen who's done the most recent changes.

- rpmlint checks return:

Errors about egrep, had to move the docs to the right place, and some unescaped
macros in the comments.  I have fixes for these ready.

esound.src: W: spelling-error %description -l en_US audiofile -> audiophile,
audio file, audio-file
The value of this tag appears to be misspelled. Please double-check.

Ignore.

esound-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/esound-0.2.41/getopt.h
esound-libs.x86_64: E: incorrect-fsf-address
/usr/share/doc/esound-libs-0.2.41/COPYING.LIB
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

File bugs upstream if you like.

esound-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libesddsp.so.0.2.39
exit@GLIBC_2.2.5
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.

Fix if possible.

esound-libs.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libesddsp.so.0.2.39 ['/usr/lib64']

And many more.

The binary or shared library defines `RPATH'. Usually this is a bad thing
because it hardcodes the path to search libraries and so makes it difficult to
move libraries around.  Most likely you will find a Makefile with a line like:
gcc test.o -o test -Wl,--rpath.  Also, sometimes configure scripts provide a
--disable-rpath flag to avoid this.

Fix.  The --disable-rpath flag at configure doesn't fix this.

esound-tools.x86_64: W: spelling-error Summary(en_US) Commandline -> Command
line, Command-line, Commandment
The value of this tag appears to be misspelled. Please double-check.

esound-tools.x86_64: W: spelling-error %description -l en_US commandline ->
command line, command-line, commandment
The value of this tag appears to be misspelled. Please double-check.

Ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license ( LGPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)  . . .once I moved the docs.
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r

Other than what's in rpmlint it looks good.  I'll commit the simple fixes soon
unless you object.

[Bug 225734] Merge Review: esound

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225734

--- Comment #6 from Jon Ciesla  2012-04-06 11:31:14 EDT ---
Moving the docs doesn't seem to be needed, or work, in rawhide.