[Bug 2101769] New: Review Request: pf-bb-config - PF BBDEV (baseband device) Configuration Application

https://bugzilla.redhat.com/show_bug.cgi?id=2101769

Bug ID: 2101769
           Summary: Review Request: pf-bb-config - PF BBDEV (baseband
                    device) Configuration Application
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://tredaell.fedorapeople.org/pf-bb-config/pf-bb-config.spec
SRPM URL:
https://tredaell.fedorapeople.org/pf-bb-config/pf-bb-config-22.03-1.fc36.src...
Description:
The PF BBDEV (baseband device) Configuration Application "pf_bb_config"
provides a means to configure the baseband device at the host-level.
The program accesses the configuration space and sets the various parameters
through memory-mapped IO read/writes.
Fedora Account System Username: tredaell

[Bug 2101769] Review Request: pf-bb-config - PF BBDEV (baseband device) Configuration Application

https://bugzilla.redhat.com/show_bug.cgi?id=2101769

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

--- Comment #1 from Neal Gompa  ---
Taking this review.

[Bug 2101769] Review Request: pf-bb-config - PF BBDEV (baseband device) Configuration Application

https://bugzilla.redhat.com/show_bug.cgi?id=2101769

--- Comment #2 from Neal Gompa  ---
> Source0:        https://github.com/intel/pf-bb-config/archive/refs/tags/v%%7Bversion%7D.tar....

This should be simplified to the following:
"%{url}/archive/v%{version}/pf-bb-config-%{version}.tar.gz"

You're also missing "BuildRequires: make"
> %{_bindir}/*
> %{_datadir}/*

This is not specific enough.

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists

[Bug 2101769] Review Request: pf-bb-config - PF BBDEV (baseband device) Configuration Application

https://bugzilla.redhat.com/show_bug.cgi?id=2101769

--- Comment #3 from Timothy Redaelli  ---
(In reply to Neal Gompa from comment #2)
> > Source0:        https://github.com/intel/pf-bb-config/archive/refs/tags/v%%7Bversion%7D.tar....
>
> This should be simplified to the following:
> "%{url}/archive/v%{version}/pf-bb-config-%{version}.tar.gz"
>
> You're also missing "BuildRequires: make"
> > %{_bindir}/*
> > %{_datadir}/*
>
> This is not specific enough.
>
> Cf.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists

I updated the spec file and the srpm with the required modifications and, in
the meanwhile, I also rebased it with the last upstream version.
I hope it's ok now

Spec URL: https://tredaell.fedorapeople.org/pf-bb-config/pf-bb-config.spec
SRPM URL:
https://tredaell.fedorapeople.org/pf-bb-config/pf-bb-config-22.07-1.fc38.src...

Thank you for your review

[Bug 2101769] Review Request: pf-bb-config - PF BBDEV (baseband device) Configuration Application

https://bugzilla.redhat.com/show_bug.cgi?id=2101769

Timothy Redaelli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |m)

[Bug 2101769] Review Request: pf-bb-config - PF BBDEV (baseband device) Configuration Application

https://bugzilla.redhat.com/show_bug.cgi?id=2101769

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |m)                          |

--- Comment #4 from Neal Gompa  ---
> %{_datadir}/pf-bb-config/acc100/acc100_config.cfg
> %{_datadir}/pf-bb-config/acc100/acc100_config_1vf_4g5g.cfg
> %{_datadir}/pf-bb-config/acc100/acc100_config_1vf_5g.cfg
> %{_datadir}/pf-bb-config/acc100/acc100_config_2vf_4g5g.cfg
> %{_datadir}/pf-bb-config/acc100/acc100_config_4vf_4g5g.cfg
> %{_datadir}/pf-bb-config/acc100/acc100_config_pf.cfg
> %{_datadir}/pf-bb-config/acc100/acc100_config_pf_4g5g.cfg
> %{_datadir}/pf-bb-config/acc100/acc100_config_vf.cfg
> %{_datadir}/pf-bb-config/acc100/acc100_config_vf_4g.cfg
> %{_datadir}/pf-bb-config/acc100/acc100_config_vf_5g.cfg

You can simplify this to just:

%{_datadir}/pf-bb-config/

[Bug 2101769] Review Request: pf-bb-config - PF BBDEV (baseband device) Configuration Application

https://bugzilla.redhat.com/show_bug.cgi?id=2101769

Timothy Redaelli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(tredaelli@redhat.
                   |                            |com)

--- Comment #5 from Timothy Redaelli  ---
Done, thank you

[Bug 2101769] Review Request: pf-bb-config - PF BBDEV (baseband device) Configuration Application

https://bugzilla.redhat.com/show_bug.cgi?id=2101769

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+
                   |needinfo?([e-mail] |
                   |m)                          |

--- Comment #6 from Neal Gompa  ---
Package review notes:

* Package follows packaging guidelines
* Package licensing is correct, license files installed correctly (though you
should swap "ASL 2.0" for "Apache-2.0" in the license tag)
* Package builds and installs correctly
* No serious rpmlint issues

PACKAGE APPROVED.

[Bug 2101769] Review Request: pf-bb-config - PF BBDEV (baseband device) Configuration Application

https://bugzilla.redhat.com/show_bug.cgi?id=2101769

--- Comment #7 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/pf-bb-config

[Bug 2101769] Review Request: pf-bb-config - PF BBDEV (baseband device) Configuration Application

https://bugzilla.redhat.com/show_bug.cgi?id=2101769

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #8 from Fedora Update System  ---
FEDORA-2022-13a7f2feb7 has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2022-13a7f2feb7

[Bug 2101769] Review Request: pf-bb-config - PF BBDEV (baseband device) Configuration Application

https://bugzilla.redhat.com/show_bug.cgi?id=2101769

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2022-10-07 10:03:22

--- Comment #9 from Fedora Update System  ---
FEDORA-2022-13a7f2feb7 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.