Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: gnome-do-docklets - Docklets for gnome-do
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Summary: Review Request: gnome-do-docklets - Docklets for gnome-do Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nushio@fedoraproject.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://nushio.fedorapeople.org/gnome-do-docklets/gnome-do-docklets.spec SRPM URL: http://nushio.fedorapeople.org/gnome-do-docklets/gnome-do-docklets-0.8.2-1.f... Description: This package contains various docklets for GNOME Do.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #1 from Juan Manuel Rodriguez nushio@fedoraproject.org 2009-08-24 11:21:02 EDT --- As a note: The Volume Control docklet appears to be broken. Perhaps I should remove it from the package?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Michel Alexandre Salim michael.silvanus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |michael.silvanus@gmail.com AssignedTo|nobody@fedoraproject.org |michael.silvanus@gmail.com Flag| |fedora-review?
--- Comment #2 from Michel Alexandre Salim michael.silvanus@gmail.com 2009-08-24 15:58:36 EDT --- It can probably be excluded for now, yes. Let me see if it works on F-12 (small chance, considering I'm packaging something right now that works fine in F-11 but breaks on F-12!)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #3 from Juan Manuel Rodriguez nushio@fedoraproject.org 2009-08-24 16:36:17 EDT --- I found the bug on gnome-do's launchpad: https://bugs.launchpad.net/do/+bug/395740
Its fixed in trunk, but they haven't released a fix to the public. Disabling until a new version ships it should be fine.
The same Volume Docklet bug affected some Ubuntu users I talked with, so its not distro related.
Updated the SPEC and SRPM to match.
Also note that I disabled the PPC* builds while the rebuild is going on Fedora 11.
Spec URL: http://nushio.fedorapeople.org/gnome-do-docklets/gnome-do-docklets.spec SRPM URL: http://nushio.fedorapeople.org/gnome-do-docklets/gnome-do-docklets-0.8.2-2.f...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #4 from Michel Alexandre Salim michael.silvanus@gmail.com 2009-08-24 17:24:25 EDT --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1630524
There are some things to fix: to sum up, spec file permission, and a directory ownership problem that's really a gnome-do packaging bug.
MUST
• rpmlint: gnome-do-docklets.src: W: strange-permission gnome-do-docklets.spec 0755 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
gnome-do-docklets.x86_64: E: no-binary gnome-do-docklets.x86_64: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 1 errors, 1 warnings.
spec permission needs to be fixed; the binary warnings are fine for Mono
• package name: OK • spec file name: OK • package guideline-compliant: OK • license complies with guidelines: OK • license field accurate: OK • license file not deleted: OK • spec in US English: OK • spec legible: OK • source matches upstream: OK
• builds under >= 1 archs, others excluded: OK
note: do you plan to get it into F-11 that fast? otherwise we can still enable ppc* builds, at least for Rawhide
• build dependencies complete: OK • locales handled using %find_lang, no %{_datadir}/locale: N/A
• own all directories: FAIL oops, bug. Nobody owns this! Could you update gnome-do so it creates %{_libdir}/gnome-do/plugins and own it?
• no dupes in %files: OK • permission: OK • %clean RPM_BUILD_ROOT: OK • macros used consistently: OK • Package contains code: OK • clean buildroot before install: OK • filenames UTF-8: OK
SHOULD • package build in mock on all architectures: PPC unknown
• package functioned as described: This one is problematic. On Rawhide x86_64, none of the docklets show up on the dock. I could configure the Weather docklet, after which it does show an icon in the list of docklets, but it does not appear on the dock. All the others have the package icon in the listing and do not show up.
• scriplets are sane: OK
• other subpackages should require versioned base • if main pkg is development-wise, pkgconfig can go in main package • require package not files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #5 from Michel Alexandre Salim michael.silvanus@gmail.com 2009-08-24 17:27:32 EDT --- Correction: I was not configuring the docklets properly. Confirmed that volume control is not working, everything else seems to work. I can't test workspace switcher as gnome-shell handles workspaces differently. The battery docklet hilariously misread my battery status as 109.7% but seems to work fine -- detecting plugging and unplugging.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #6 from Juan Manuel Rodriguez nushio@fedoraproject.org 2009-08-24 17:45:38 EDT --- Fixing gnome-do permissions. Now gnome-do will own the plugins dir. Also enabling PPC and PPC64 as requested. (Same SPEC URL)
As for the functional package? I had a bit of a hiccup too. I had to enable the 'docky' theme, then switch to classic, and switch back to 'docky'. The second time, the plugins showed up and worked.
I don't have a laptop, so I can't confirm the battery status personally, but I did read a blogpost where the KDE battery said 5800000% left, might be related?
The workspace switcher does work on Gnome.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Michel Alexandre Salim michael.silvanus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Michel Alexandre Salim michael.silvanus@gmail.com 2009-08-24 22:28:13 EDT --- Not sure; on mine it seems to be off by only about 10% or so. Though today yum shows me progress percentages of thousands of percents for each download, heh.
OK, everything else is fine -- APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #8 from Juan Manuel Rodriguez nushio@fedoraproject.org 2009-09-02 23:49:05 EDT --- New Package CVS Request ======================= Package Name: gnome-do-docklets Short Description: Docklets for GNOME-Do Owners: nushio salimma Branches: F-12 F-11 devel InitialCC: gnome-do-owner@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Julian Aloofi julian.fedora@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.fedora@googlemail.co | |m
--- Comment #9 from Julian Aloofi julian.fedora@googlemail.com 2010-01-02 07:51:05 EDT --- I suppose nobody will see this CVS request as the fedora-cvs flag is not set... Just pointing this out, as I'd like to see the docklets in the repos.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
BenjamÃn Valero Espinosa benjavalero@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |benjavalero@gmail.com
--- Comment #10 from BenjamÃn Valero Espinosa benjavalero@gmail.com 2010-08-05 11:16:12 EDT --- I hope to see this at least in F14.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #11 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-08-05 11:34:57 EDT --- Well, - I guess this review request needs re-review, because it is more than 3 months since the latest srpm are reviewed. - Also it is better to contact spot (FE-Legal) before importing this package into Fedora, because currently shipping "dock"-like application in Fedora is not allowed (and actually were removed before F-11) because of the possibility of infringing patents.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #12 from BenjamÃn Valero Espinosa benjavalero@gmail.com 2010-08-05 11:53:46 EDT --- (In reply to comment #11)
- Also it is better to contact spot (FE-Legal) before importing this package into Fedora, because currently shipping "dock"-like application in Fedora is not allowed (and actually were removed before F-11) because of the possibility of infringing patents.
It would be a pity, because gnome-do with docklets combined with Gnome Shell would be wonderful (IMHO).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Gen Zhang genneth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |genneth@gmail.com
--- Comment #13 from Gen Zhang genneth@gmail.com 2010-11-09 19:51:24 EST --- Can we get a re-review? And would people shout at me if I add spot to the CC list to get a legal okay? It seems odd that we have gnome-do itself, and the plugins, but not the docklets...?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #14 from Gen Zhang genneth@gmail.com 2010-11-09 20:03:04 EST --- Just rebuilt it for F14. Needed a patch to make things build with presumably updated C#.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #15 from Gen Zhang genneth@gmail.com 2010-11-09 20:03:50 EST --- Created attachment 459294 --> https://bugzilla.redhat.com/attachment.cgi?id=459294 patch to make 0.8.2 build on F14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #16 from Gen Zhang genneth@gmail.com 2010-11-09 20:04:16 EST --- Created attachment 459295 --> https://bugzilla.redhat.com/attachment.cgi?id=459295 Make it build on F14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #17 from Michel Alexandre Salim fedora@michelsylvain.info 2010-11-11 06:21:41 EST --- Gen, since Juan has not responded since filing his CVS request ( over a year ago!), I suggest you start a new review ticket and mark this one as a duplicate.
And as Mamoru suggested, please ask on the legal list whether this package is permissible or not
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #18 from Gen Zhang genneth@gmail.com 2010-11-11 09:00:40 EST --- I've opened https://bugzilla.redhat.com/show_bug.cgi?id=652266
But I can't close this one I don't think...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Michel Alexandre Salim fedora@michelsylvain.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |DUPLICATE Last Closed| |2010-11-11 10:59:45
--- Comment #19 from Michel Alexandre Salim fedora@michelsylvain.info 2010-11-11 10:59:45 EST --- Done
*** This bug has been marked as a duplicate of bug 652266 ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Michel Alexandre Salim fedora@michelsylvain.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Blocks| |182235(FE-Legal) Resolution|DUPLICATE | Keywords| |Reopened
--- Comment #20 from Michel Alexandre Salim fedora@michelsylvain.info 2010-11-11 11:07:18 EST --- Reopening since I've now heard back from Juan on IM. Blocking on FE-LEGAL until Mamoru's concerns are clarified by the legal team.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Michel Alexandre Salim fedora@michelsylvain.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review+ |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #21 from Michel Alexandre Salim fedora@michelsylvain.info 2010-11-11 11:07:47 EST --- *** Bug 652266 has been marked as a duplicate of this bug. ***
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@redhat.com
--- Comment #22 from Tom "spot" Callaway tcallawa@redhat.com 2010-11-11 11:15:36 EST --- Is there a current SRPM I can audit?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #23 from Juan Manuel Rodriguez nushio@fedoraproject.org 2010-11-11 13:28:30 EST --- SPEC: http://nushio.fedorapeople.org/gnome-do/gnome-do-docklets.spec SRPM: http://nushio.fedorapeople.org/gnome-do/gnome-do-docklets-0.8.2-3.fc14.src.r...
Based on Gen's patch, which I'll be submitting to upstream soon.
I feel very embarrassed about forgetting to set the flag, and then forgetting the package altogether.
You're right in that Docky would make Gnome-Shell usable.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #24 from Tom "spot" Callaway tcallawa@redhat.com 2010-11-11 14:54:16 EST --- All this package seems to do is add additional applets to gnome-do. It appears that the "dock" functionality is within gnome-do (in "docky" mode), and this package adds no additional dock functionality.
Is that correct?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #25 from Juan Manuel Rodriguez nushio@fedoraproject.org 2010-11-11 16:51:42 EST --- That's right. And in fact, we already removed the "Zoom" functionality from gnome-do's dock theme.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|182235(FE-Legal) |
--- Comment #26 from Tom "spot" Callaway tcallawa@redhat.com 2010-11-12 12:05:41 EST --- That was my impression from looking at this package as well. I see no legal concerns here, so I'm lifting FE-Legal.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #27 from Juan Manuel Rodriguez nushio@fedoraproject.org 2010-11-12 13:33:35 EST --- Alright, thanks Tom!
The package had already been reviewed and approved, should I just set the cvs flags this time?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #28 from Michel Alexandre Salim fedora@michelsylvain.info 2010-11-13 09:37:17 EST --- Since there is actually no newer version, and the patch looks sane, the package is re-APPROVED.
Please set the flag this time :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Juan Manuel Rodriguez nushio@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+, fedora-cvs?
--- Comment #29 from Juan Manuel Rodriguez nushio@fedoraproject.org 2010-11-13 12:11:44 EST --- New Package CVS Request ======================= Package Name: gnome-do-docklets Short Description: Docklets for GNOME-Do Owners: nushio salimma Branches: F-14 F-13 devel InitialCC: gnome-do-owner@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Michel Alexandre Salim michel+fdr@michelsylvain.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review+ |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Michel Alexandre Salim michel+fdr@michelsylvain.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #30 from Michel Alexandre Salim michel+fdr@michelsylvain.info 2010-11-13 12:30:43 EST --- Oops, I should have been the one setting the review flag.
Juan: you need to fix the branches. devel is never necessary, and the stable branches are now called f13 and f14 (same as the Git branch names).
And the -owner@fedoraproject.org alias is always Cc:ed, I think.
Could you remove me from the owner list? I tend not to use Mono nowadays, and my primary laptop unfortunately has a really weak graphics stack (ATi, no 3D or even transparency support yet) and my secondary laptop... is a netbook that probably wouldn't like running Mono that much.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #31 from Juan Manuel Rodriguez nushio@fedoraproject.org 2010-11-13 16:50:04 EST --- Sorry, I thought you might be interested in maintaining the package (As was set a while ago).
I forgot the branch names changed with the move to git.
The CC is for the gnome-do maintainers (Which is a different package than gnome-do-docklets :) )
New Package CVS Request ======================= Package Name: gnome-do-docklets Short Description: Docklets for GNOME-Do Owners: nushio Branches: f14 f13 InitialCC: gnome-do-owner@fedoraproject.org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #32 from Jason Tibbitts tibbs@math.uh.edu 2010-11-15 09:18:41 EST --- InitialCC must be a Fedora account name, not an email address. I have processed your request with InitialCC blank.
Git done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #33 from Fedora Update System updates@fedoraproject.org 2010-11-16 14:04:44 EST --- gnome-do-docklets-0.8.2-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/gnome-do-docklets-0.8.2-3.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #34 from Fedora Update System updates@fedoraproject.org 2010-11-16 14:05:38 EST --- gnome-do-docklets-0.8.2-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/gnome-do-docklets-0.8.2-3.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #35 from Fedora Update System updates@fedoraproject.org 2010-11-17 18:22:00 EST --- gnome-do-docklets-0.8.2-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gnome-do-docklets'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/gnome-do-docklets-0.8.2-3.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #36 from Fedora Update System updates@fedoraproject.org 2011-01-04 15:54:37 EST --- gnome-do-docklets-0.8.2-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |gnome-do-docklets-0.8.2-3.f | |c14 Resolution| |ERRATA Last Closed|2010-11-11 10:59:45 |2011-01-04 15:54:45
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
--- Comment #37 from Fedora Update System updates@fedoraproject.org 2011-01-25 16:01:34 EST --- gnome-do-docklets-0.8.2-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=519009
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|gnome-do-docklets-0.8.2-3.f |gnome-do-docklets-0.8.2-3.f |c14 |c13
package-review@lists.fedoraproject.org