[Bug 1608484] New: Review Request: android-file-transfer - Reliable Android MTP client with minimalistic UI
https://bugzilla.redhat.com/show_bug.cgi?id=1608484
Bug ID: 1608484 Summary: Review Request: android-file-transfer - Reliable Android MTP client with minimalistic UI Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mblaha@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://mblaha.fedorapeople.org/android-file-transfer.spec SRPM URL: https://mblaha.fedorapeople.org/android-file-transfer-3.4-1.fc28.src.rpm Description: Android File Transfer for Linux — reliable MTP client with minimalistic UI similar to Android File Transfer for Mac. Features: - Simple Qt UI with progress dialogs. - FUSE wrapper (If you'd prefer mounting your device), supporting partial read/writes, allowing instant access to your files. - No file size limits. - Automatically renames album cover to make it visible from media player. - USB 'Zerocopy' support found in recent Linux kernel - No extra dependencies (e.g. libptp/libmtp). - Command line tool (aft-mtp-cli)
Fedora Account System Username: mblaha
https://bugzilla.redhat.com/show_bug.cgi?id=1608484
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - You need to validate the .desktop file in %install or %check, see https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usa...
desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop
- You need to validate the Appdata file, see https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage
appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/%{name}.appdata.xml
- You must Requires: hicolor-icon-theme to own the icons directories.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file.
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2.1 or later)", "Unknown or generated". 36 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/android- file-transfer/review-android-file-transfer/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/icons/hicolor/512x512/apps(hicolor-icon-theme), /usr/share/icons/hicolor/512x512(hicolor-icon-theme), /usr/share/icons/hicolor(fedora-logos) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in android- file-transfer-debuginfo , android-file-transfer-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: android-file-transfer-3.4-1.fc29.x86_64.rpm android-file-transfer-debuginfo-3.4-1.fc29.x86_64.rpm android-file-transfer-debugsource-3.4-1.fc29.x86_64.rpm android-file-transfer-3.4-1.fc29.src.rpm android-file-transfer.x86_64: W: spelling-error Summary(en_US) minimalistic -> minimalist, minimalism, animistic android-file-transfer.x86_64: W: spelling-error %description -l en_US minimalistic -> minimalist, minimalism, animistic android-file-transfer.x86_64: W: spelling-error %description -l en_US libptp -> Lipton android-file-transfer.x86_64: W: spelling-error %description -l en_US libmtp -> Librium android-file-transfer.x86_64: W: spelling-error %description -l en_US mtp -> mt, mp, map android-file-transfer.x86_64: W: spelling-error %description -l en_US cli -> cl, clii, clip android-file-transfer.x86_64: W: no-manual-page-for-binary aft-mtp-cli android-file-transfer.x86_64: W: no-manual-page-for-binary aft-mtp-mount android-file-transfer.x86_64: W: no-manual-page-for-binary android-file-transfer android-file-transfer.src: W: spelling-error Summary(en_US) minimalistic -> minimalist, minimalism, animistic android-file-transfer.src: W: spelling-error %description -l en_US minimalistic -> minimalist, minimalism, animistic android-file-transfer.src: W: spelling-error %description -l en_US libptp -> Lipton android-file-transfer.src: W: spelling-error %description -l en_US libmtp -> Librium android-file-transfer.src: W: spelling-error %description -l en_US mtp -> mt, mp, map android-file-transfer.src: W: spelling-error %description -l en_US cli -> cl, clii, clip 4 packages and 0 specfiles checked; 0 errors, 15 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1608484
--- Comment #2 from Marek Blaha mblaha@redhat.com --- Hi, thanks for review. All three issues are now fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=1608484
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1608484
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/android-file-transfer
https://bugzilla.redhat.com/show_bug.cgi?id=1608484
Marek Blaha mblaha@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2018-07-31 02:08:43
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com