[Bug 2229406] New: Review Request: golang-github-container-orchestrated-devices-device-interface - CDI - The Container Device Interface
https://bugzilla.redhat.com/show_bug.cgi?id=2229406
Bug ID: 2229406 Summary: Review Request: golang-github-container-orchestrated-devices-device-in terface - CDI - The Container Device Interface Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: zebob.m@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-container-orchest... SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-container-orchest...
Description: CDI (Container Device Interface), is a specification, for container-runtimes, to support third-party devices. It introduces an abstract notion of a device as a resource. Such devices are uniquely specified by a fully-qualified name that is constructed from a vendor ID, a device class, and a name that is unique per vendor ID-device class pair.
Fedora Account System Username: eclipseo
https://bugzilla.redhat.com/show_bug.cgi?id=2229406
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=104409508
https://bugzilla.redhat.com/show_bug.cgi?id=2229406
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |sergio@serjux.com Doc Type|--- |If docs needed, set a value CC| |sergio@serjux.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2229406
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|NEW |ASSIGNED
--- Comment #2 from Sergio Basto sergio@serjux.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0". 24 files have unknown license. Detailed output of licensecheck in /home/sergio/fedora-scm/docker/2229406-golang-github-container- orchestrated-devices-device-interface/licensecheck.txt [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by:
[ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 31124 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-container-orchestrated-devices-device-interface-devel-0.6.0-1.fc40.noarch.rpm golang-github-container-orchestrated-devices-device-interface-0.6.0-1.fc40.src.rpm ===================================================================== rpmlint session starts ===================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0kmobtkt')] checks: 31, packages: 2
golang-github-container-orchestrated-devices-device-interface.spec: W: no-%build-section golang-github-container-orchestrated-devices-device-interface-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/container-orchestrated-devices/container-device-interface/.goipath golang-github-container-orchestrated-devices-device-interface-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/container-orchestrated-devices/container-device-interface/CONTRIBUTING.md /usr/share/doc/golang-github-container-orchestrated-devices-device-interface-devel/CONTRIBUTING.md golang-github-container-orchestrated-devices-device-interface-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/container-orchestrated-devices/container-device-interface/README.md /usr/share/doc/golang-github-container-orchestrated-devices-device-interface-devel/README.md golang-github-container-orchestrated-devices-device-interface-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/container-orchestrated-devices/container-device-interface/SPEC.md /usr/share/doc/golang-github-container-orchestrated-devices-device-interface-devel/SPEC.md ====================================== 2 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken 0.5 s ======================================
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
golang-github-container-orchestrated-devices-device-interface-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/container-orchestrated-devices/container-device-interface/.goipath golang-github-container-orchestrated-devices-device-interface-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/container-orchestrated-devices/container-device-interface/CONTRIBUTING.md /usr/share/doc/golang-github-container-orchestrated-devices-device-interface-devel/CONTRIBUTING.md golang-github-container-orchestrated-devices-device-interface-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/container-orchestrated-devices/container-device-interface/README.md /usr/share/doc/golang-github-container-orchestrated-devices-device-interface-devel/README.md golang-github-container-orchestrated-devices-device-interface-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/container-orchestrated-devices/container-device-interface/SPEC.md /usr/share/doc/golang-github-container-orchestrated-devices-device-interface-devel/SPEC.md 1 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.0 s
Source checksums ---------------- https://github.com/container-orchestrated-devices/container-device-interface... : CHECKSUM(SHA256) this package : 8dc1a09e8416fd419df9c0408b2659302c994a1d8189348f3e372057b131c5c8 CHECKSUM(SHA256) upstream package : 8dc1a09e8416fd419df9c0408b2659302c994a1d8189348f3e372057b131c5c8
Requires -------- golang-github-container-orchestrated-devices-device-interface-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/fsnotify/fsnotify) golang(github.com/opencontainers/runc/libcontainer/devices) golang(github.com/opencontainers/runtime-spec/specs-go) golang(github.com/opencontainers/runtime-tools/generate) golang(github.com/spf13/cobra) golang(github.com/xeipuuv/gojsonschema) golang(golang.org/x/mod/semver) golang(golang.org/x/sys/unix) golang(sigs.k8s.io/yaml)
Provides -------- golang-github-container-orchestrated-devices-device-interface-devel: golang(github.com/container-orchestrated-devices/container-device-interface/cmd/cdi/cmd) golang(github.com/container-orchestrated-devices/container-device-interface/internal/multierror) golang(github.com/container-orchestrated-devices/container-device-interface/internal/validation) golang(github.com/container-orchestrated-devices/container-device-interface/internal/validation/k8s) golang(github.com/container-orchestrated-devices/container-device-interface/pkg/cdi) golang(github.com/container-orchestrated-devices/container-device-interface/pkg/cdi/validate) golang(github.com/container-orchestrated-devices/container-device-interface/pkg/parser) golang(github.com/container-orchestrated-devices/container-device-interface/schema) golang(github.com/container-orchestrated-devices/container-device-interface/specs-go) golang-github-container-orchestrated-devices-device-interface-devel golang-ipath(github.com/container-orchestrated-devices/container-device-interface)
The package use %autorelease %autochangelog and go autogenerated macros to build and install, so all is fine, spec is fine , rpmlint is fine etc
Package APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=2229406
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@gmail.com | |)
https://bugzilla.redhat.com/show_bug.cgi?id=2229406
--- Comment #3 from Sergio Basto sergio@serjux.com --- please add this package to Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=2229406
--- Comment #4 from Sergio Basto sergio@serjux.com --- Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago
https://bugzilla.redhat.com/show_bug.cgi?id=2229406
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed| |2025-02-27 19:55:03
Product: Fedora Version: rawhide Component: Package Review
Red Hat Bugzilla bugzilla@redhat.com has canceled Package Review package-review@lists.fedoraproject.org's request for Robert-André Mauchin 🐧 eclipseo@mauchin.fr's needinfo: Bug 2229406: Review Request: golang-github-container-orchestrated-devices-device-interface - CDI - The Container Device Interface https://bugzilla.redhat.com/show_bug.cgi?id=2229406
--- Comment #6 from Red Hat Bugzilla bugzilla@redhat.com --- The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com