Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module Product: Fedora Extras Version: devel Platform: All URL: http://search.cpan.org/dist/Gtk2-Notify/ OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: fedora-package-review@redhat.com
SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify-0.02-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify.spec
Description: Perl bindings to libnotify. This module will allow one to use the notify functionality from within a perl application.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |163776 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
------- Additional Comments From cweyl@alumni.drew.edu 2006-11-22 15:24 EST ------- Tests now conditionalized -- they tend to die horribly under mock due to the lack of $DISPLAY.
SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify-0.02-2.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |panemade@gmail.com OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
------- Additional Comments From panemade@gmail.com 2006-11-23 23:21 EST ------- I just had a look for Source URL and found given source download link is not working.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
------- Additional Comments From cweyl@alumni.drew.edu 2006-11-24 01:14 EST ------- Ok, that's weird.
It is working from the by-authors perspective; I'll update the spec to use this one.
http://search.cpan.org/CPAN/authors/id/F/FL/FLORA/Gtk2-Notify-0.02.tar.gz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
------- Additional Comments From panemade@gmail.com 2006-11-25 12:44 EST ------- Till you take time to update new SRPM here comes review Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and but NOT for RPMS. But those warnings are ignored. + source files match upstream. 77a64c944cf1516bcc514456de22a82b Gtk2-Notify-0.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + .pc file present. + no -devel subpackage exists + no .la files. + no translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Followed perl packaging guidelines. APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
------- Additional Comments From panemade@gmail.com 2006-11-25 12:52 EST ------- I checked md5 against Source URL you provided. I can approve this package if you are going to include new source url while importing this package or submit new one . Will check it and then actually approve this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
------- Additional Comments From cweyl@alumni.drew.edu 2006-11-27 11:48 EST ------- Updated with new source url:
SRPM URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify-0.02-3.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
------- Additional Comments From panemade@gmail.com 2006-11-27 11:56 EST ------- You forget to add version in Changelog entry. rpmlint is complaining for it now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
------- Additional Comments From cweyl@alumni.drew.edu 2006-11-27 12:10 EST ------- Fixed.
SPEC URL: http://home.comcast.net/~ckweyl/perl-Gtk2-Notify.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From panemade@gmail.com 2006-11-27 12:20 EST ------- Thanks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216947
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From cweyl@alumni.drew.edu 2006-11-27 13:52 EST ------- Imported into cvs, branches requested, and building for devel.
Thanks for the review! :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Notify - Gtk2::Notify Perl module
https://bugzilla.redhat.com/show_bug.cgi?id=216947
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla