Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
Summary: Review Request: plotmm Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: karlthered@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: http://darkenphoenix.free.fr/RPMS/RPMS/Extras/SPECS/plotmm.spec SRPM URL: http://darkenphoenix.free.fr/RPMS/RPMS/Extras/SRPMS/plotmm-0.1.2-1.src.rpm Description: GTKmm plot widget for scientific applications. This is one of my first packages, I need a sponsor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: plotmm |Review Request: plotmm AssignedTo|bugzilla-sink@leemhuis.info |rc040203@freenet.de OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From rc040203@freenet.de 2006-05-26 00:02 EST ------- NEEDSWORK:
Blockers:
- The package ships example applications in %{_bindir} /usr/bin/simple /usr/bin/curve
To me this seems questionable twice: 1. These application names are too general and likely to conflict with other packages. 2. Installing example applications to %{_bindir} isn't necessarily a wise decision.
Wrt. 2, I'd propose to move these examples out of the base package into an *-examples package or to make them part of the *-devel package.
Wrt. 1., I'd propose to move these applications out of %{_bindir} and to install them into a different location (e.g. %{_libdir}/plotmm/examples), or to rename them into something less likely to conflict (e.g. plotmm-{simple|curve}).
Minor: - The sources contain devel docs (in doc/html/), but they are not being packages. I'd propose to ship these docs as part of the *-devel package
- Rpmlint complaints:
# rpmlint plotmm-0.1.2-1.i386.rpm W: plotmm summary-ended-with-dot GTKmm plot widget for scientific applications. E: plotmm description-line-too-long It contains widgets which are primarily useful for technical and scientifical purposes. E: plotmm zero-length /usr/share/doc/plotmm-0.1.2/NEWS E: plotmm zero-length /usr/share/doc/plotmm-0.1.2/INSTALL
# rpmlint plotmm-devel-0.1.2-1.i386.rpm W: plotmm-devel summary-ended-with-dot Headers for developing programs that will use plotmm. E: plotmm-devel description-line-too-long This package contains the headers that programmers will need to develop applications which will use plotmm. W: plotmm-devel no-documentation
General issue: You are using an Alias-name instead of your real name in %changelog. I am opposed to this practice.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From karlthered@gmail.com 2006-05-26 10:40 EST ------- new SRPM: http://darkenphoenix.free.fr/RPMS/RPMS/Extras/SRPMS/plotmm-0.1.2-2.src.rpm * Blockers: - samples applications are now in a separated package: plotmm-examples and moved them to %{_libdir}/plotmm/examples, and changed their name into plotmm-* - added the documentation in the devel package * rpmlint complaints: - the named issues were fixed - rpmlint output about current packages $ rpmlint plotmm-0.1.2-2.i386.rpm W: plotmm one-line-command-in-%post /sbin/ldconfig W: plotmm one-line-command-in-%postun /sbin/ldconfig $ rpmlint /home/isshin/rpmbuild/RPMS/i386/plotmm-devel-0.1.2-2.i386.rpm $ rpmlint /home/isshin/rpmbuild/RPMS/i386/plotmm-examples-0.1.2-2.i386.rpm W: plotmm-examples no-documentation * general issue - This was an oversight, I have corrected it in plotmm and other packages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From karlthered@gmail.com 2006-05-26 11:07 EST ------- new SRPM: http://darkenphoenix.free.fr/RPMS/RPMS/Extras/SRPMS/plotmm-0.1.2-2.src.rpm * Blockers: - samples applications are now in a separated package: plotmm-examples and moved them to %{_libdir}/plotmm/examples, and changed their name into plotmm-* - added the documentation in the devel package * rpmlint complaints: - the named issues were fixed - rpmlint output about current packages $ rpmlint plotmm-0.1.2-2.i386.rpm W: plotmm one-line-command-in-%post /sbin/ldconfig W: plotmm one-line-command-in-%postun /sbin/ldconfig $ rpmlint /home/isshin/rpmbuild/RPMS/i386/plotmm-devel-0.1.2-2.i386.rpm $ rpmlint /home/isshin/rpmbuild/RPMS/i386/plotmm-examples-0.1.2-2.i386.rpm W: plotmm-examples no-documentation * general issue - This was an oversight, I have corrected it in plotmm and other packages.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From cgoorah@yahoo.com.au 2006-06-12 19:00 EST ------- (In reply to comment #3)
- rpmlint complaints:
------------ chitlesh(i386)[0]$rpmlint -i plotmm-0.1.2-2.i386.rpm W: plotmm one-line-command-in-%post /sbin/ldconfig You should use %post -p <command> instead of using:
%post <command>
It will avoid the fork of a shell interpreter to execute your command as well as allows rpm to automatically mark the dependency on your command.
W: plotmm one-line-command-in-%postun /sbin/ldconfig You should use %postun -p <command> instead of using:
%postun <command>
It will avoid the fork of a shell interpreter to execute your command as well as allows rpm to automatically mark the dependency on your command. ------------
Use %post -p /sbin/ldconfig %postun -p /sbin/ldconfig to solve them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From rc040203@freenet.de 2006-06-13 01:51 EST ------- (In reply to comment #4)
(In reply to comment #3)
chitlesh(i386)[0]$rpmlint -i plotmm-0.1.2-2.i386.rpm W: plotmm one-line-command-in-%post /sbin/ldconfig You should use %post -p <command> instead of using:
Note the "should" - rpmlint is being stylish, here.
Sorry for not having completed the review earlier, some time, later today.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From karlthered@gmail.com 2006-06-13 08:30 EST ------- I applied the changes -this will be corrected in other packages too-, here's the new SRPM: /home/isshin/rpmbuild/RPMS/i386/plotmm-examples-0.1.2-3.i386.rpm - rpmlint output: $ rpmlint plotmm-0.1.2-2.i386.rpm $ rpmlint /home/isshin/rpmbuild/RPMS/i386/plotmm-devel-0.1.2-2.i386.rpm $ rpmlint /home/isshin/rpmbuild/RPMS/i386/plotmm-examples-0.1.2-2.i386.rpm W: plotmm-examples no-documentation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From rc040203@freenet.de 2006-06-13 10:10 EST ------- I am having a couple of issues with the spec:
- /usr/share/doc/plotmm-devel-0.1.2/doc/html/ That's at least one directory too much for my taste.
Using %doc doc/html instead of %doc will install the html docs to /usr/share/doc/plotmm-devel-0.1.2/html
- Empty %doc for the *-examples %doc Remove this line.
- You went a bit too far, as far as renaming the examples is concerned. My remark in comment #1 was addressing conflicts between real applications and example code. Therefore I had proposed to either "rename" or "move" the example applications. Now, you've done both.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From cgoorah@yahoo.com.au 2006-06-14 00:11 EST ------- Due to a bugzilla backup restored, Im copy/pasting what has been posted before:
- rpmlint complaints:
------------ chitlesh(i386)[0]$rpmlint -i plotmm-0.1.2-2.i386.rpm W: plotmm one-line-command-in-%post /sbin/ldconfig You should use %post -p <command> instead of using:
%post <command>
It will avoid the fork of a shell interpreter to execute your command as well as allows rpm to automatically mark the dependency on your command.
W: plotmm one-line-command-in-%postun /sbin/ldconfig You should use %postun -p <command> instead of using:
%postun <command>
It will avoid the fork of a shell interpreter to execute your command as well as allows rpm to automatically mark the dependency on your command. ------------
Use %post -p /sbin/ldconfig %postun -p /sbin/ldconfig to solve them
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From cgoorah@yahoo.com.au 2006-06-14 00:13 EST ------- ------- Additional Comments From rc040203@freenet.de 2006-06-13 01:51 EST ------- (In reply to comment #4)
(In reply to comment #3)
chitlesh(i386)[0]$rpmlint -i plotmm-0.1.2-2.i386.rpm W: plotmm one-line-command-in-%post /sbin/ldconfig You should use %post -p <command> instead of using:
Note the "should" - rpmlint is being stylish, here.
Sorry for not having completed the review earlier, some time, later today.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From cgoorah@yahoo.com.au 2006-06-14 00:14 EST ------- ------- Additional Comments From karlthered@gmail.com 2006-06-13 08:30 EST ------- I applied the changes -this will be corrected in other packages too-, here's the new SRPM: /home/isshin/rpmbuild/RPMS/i386/plotmm-examples-0.1.2-3.i386.rpm - rpmlint output: $ rpmlint plotmm-0.1.2-2.i386.rpm $ rpmlint /home/isshin/rpmbuild/RPMS/i386/plotmm-devel-0.1.2-2.i386.rpm $ rpmlint /home/isshin/rpmbuild/RPMS/i386/plotmm-examples-0.1.2-2.i386.rpm W: plotmm-examples no-documentation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From cgoorah@yahoo.com.au 2006-06-14 00:15 EST ------- ------- Additional Comments From rc040203@freenet.de 2006-06-13 10:10 EST ------- I am having a couple of issues with the spec:
- /usr/share/doc/plotmm-devel-0.1.2/doc/html/ That's at least one directory too much for my taste.
Using %doc doc/html instead of %doc will install the html docs to /usr/share/doc/plotmm-devel-0.1.2/html
- Empty %doc for the *-examples %doc Remove this line.
- You went a bit too far, as far as renaming the examples is concerned. My remark in comment #1 was addressing conflicts between real applications and example code. Therefore I had proposed to either "rename" or "move" the example applications. Now, you've done both.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From tibbs@math.uh.edu 2006-06-24 01:04 EST ------- Did someone agree to sponsor Haïkel?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From rc040203@freenet.de 2006-06-24 03:33 EST ------- I am already formally reviewing this package and could sponsor him, but he has not yet responded to my comment in comment #7.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From karlthered@gmail.com 2006-06-29 10:04 EST ------- Sorry for the delay, I had been quite busy. Here's the new SRPM with the suggested fixes. http://darkenphoenix.free.fr/RPMS/RPMS/Extras/SRPMS/plotmm-0.1.2-4.src.rpm Anyway, I have also other packages that need to be reviewed: bugs 193108 (libsexymm C++ bindings to libsexy ), 193109 (python-sexy python bindings to libsexy), 193103 (listen yet another music player)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From rc040203@freenet.de 2006-07-09 10:29 EST ------- I had preferred, if you installed the examples to somewhere outside of %{_bindir} instead of renaming them, because this would have helped to keep %{_bindir} free of "more or less useless examples", but ... this basically is a matter of personal preference.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From rc040203@freenet.de 2006-07-17 02:03 EST ------- Haïkel, are you still interested in pushing this package into FE?
Then I'd recommend you to proceed with processing this request as described on http://fedoraproject.org/wiki/Extras/Contributors
Shouldn't I hear from you within 14 days from now, I'll close this PR as FAILED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From karlthered@gmail.com 2006-07-18 08:18 EST ------- I'm still interested to maintain this package. I have signed the CLA, and added myself to cvsextras and fedorabugs groups (step 4.a/b of the howto)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
------- Additional Comments From rc040203@freenet.de 2006-07-24 02:14 EST ------- Haïkel, you have been sponsored, now you are supposed to import this package into CVS and build it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193109
karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From karlthered@gmail.com 2006-07-30 17:54 EST ------- The build has succeeded for both FC5 and developpement tree. Thanks for everything guys !
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: plotmm
https://bugzilla.redhat.com/show_bug.cgi?id=193109
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla