https://bugzilla.redhat.com/show_bug.cgi?id=2183742
Aleksei Bavshin <alebastr89(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Doc Type|--- |If docs needed, set a value
CC| |alebastr89(a)gmail.com
Flags| |fedora-review+
Status|NEW |POST
Assignee|nobody(a)fedoraproject.org |alebastr89(a)gmail.com
--- Comment #2 from Aleksei Bavshin <alebastr89(a)gmail.com> ---
Approved.
# * missing dev-dependencies: snapbox
Good thing: tests currently do not require snapbox.
Bad thing: that's because `include.workspace = true` in Cargo.toml resolves to
the list from
https://github.com/clap-rs/clap/blob/0.2.10/Cargo.toml#L17 which
does not include 'tests/**/*' ¯\_(ツ)_/¯
There are no tests to run, but if there were any, they would still require
snapbox. With that in mind, `%bcond_with check` seems fine to me.
You might want to check with the clap upstream if the omission was intentional
though.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2183742