[Bug 2183742] New: Review Request: rust-clap_mangen - Manpage generator for clap

https://bugzilla.redhat.com/show_bug.cgi?id=2183742

Bug ID: 2183742
           Summary: Review Request: rust-clap_mangen - Manpage generator
                    for clap
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://decathorpe.fedorapeople.org/rust-clap_mangen.spec
SRPM URL:
https://decathorpe.fedorapeople.org/rust-clap_mangen-0.2.10-1.fc38.src.rpm

Description:
A manpage generator for clap.

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=99404366

[Bug 2183742] Review Request: rust-clap_mangen - Manpage generator for clap

https://bugzilla.redhat.com/show_bug.cgi?id=2183742

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://crates.io/crates/cl
                   |                            |ap_mangen

--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5735589
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2183742] Review Request: rust-clap_mangen - Manpage generator for clap

https://bugzilla.redhat.com/show_bug.cgi?id=2183742

Aleksei Bavshin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[e-mail]
              Flags|                            |fedora-review+
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]

--- Comment #2 from Aleksei Bavshin  ---
Approved.
> # * missing dev-dependencies: snapbox

Good thing: tests currently do not require snapbox.
Bad thing: that's because `include.workspace = true` in Cargo.toml resolves to
the list from https://github.com/clap-rs/clap/blob/0.2.10/Cargo.toml#L17 which
does not include 'tests/**/*' ¯_(ツ)_/¯

There are no tests to run, but if there were any, they would still require
snapbox. With that in mind, `%bcond_with check` seems fine to me.
You might want to check with the clap upstream if the omission was intentional
though.

[Bug 2183742] Review Request: rust-clap_mangen - Manpage generator for clap

https://bugzilla.redhat.com/show_bug.cgi?id=2183742

--- Comment #3 from Fabio Valentini  ---
Thanks for the review! And good catch. I will update the comment before import.

[Bug 2183742] Review Request: rust-clap_mangen - Manpage generator for clap

https://bugzilla.redhat.com/show_bug.cgi?id=2183742

--- Comment #4 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-clap_mangen

[Bug 2183742] Review Request: rust-clap_mangen - Manpage generator for clap

https://bugzilla.redhat.com/show_bug.cgi?id=2183742

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #5 from Fedora Update System  ---
FEDORA-2023-bf649844fc has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-bf649844fc

[Bug 2183742] Review Request: rust-clap_mangen - Manpage generator for clap

https://bugzilla.redhat.com/show_bug.cgi?id=2183742

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |ERRATA
             Status|MODIFIED                    |CLOSED
        Last Closed|                            |2023-04-08 22:24:38

--- Comment #6 from Fedora Update System  ---
FEDORA-2023-bf649844fc has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.