[Bug 191622] New: Review Request: perl-Expect - Expect for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191622

Summary: Review Request: perl-Expect - Expect for Perl
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Expect.spec
SRPM URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Expect-1.16-1.src.rpm

Description: 
The Perl Expect module was inspired more by the functionality of
Tcl/Expect than any previous Expect-like tool such as Comm.pl or
chat2.pl.

[Bug 191622] Review Request: perl-Expect - Expect for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Expect - Expect for Perl

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191622

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |191623
              nThis|                            |

[Bug 191622] Review Request: perl-Expect - Expect for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Expect - Expect for Perl

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191622

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

[Bug 191622] Review Request: perl-Expect - Expect for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Expect - Expect for Perl

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191622

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-05-16 14:13 EST -------
That description is really suboptimal.  How about something like this, partially
stolen from the original Expect description:

This module provides Expect-like functionality to Perl.  Expect is a tool for
automating interactive applications such as telnet, ftp, passwd, fsck, rlogin,
tip, etc.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   f5f0ea179c6f19d9f08e22c6a0072292  Expect-1.16.tar.gz
   f5f0ea179c6f19d9f08e22c6a0072292  Expect-1.16.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   Passed 36 of 36 tests.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED, but please fix the description before checking in.

[Bug 191622] Review Request: perl-Expect - Expect for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Expect - Expect for Perl

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191622

------- Additional Comments From [e-mail]  2006-05-16 14:41 EST -------
(In reply to comment #1)
> That description is really suboptimal.  How about something like this, partially
> stolen from the original Expect description:
>
> This module provides Expect-like functionality to Perl.  Expect is a tool for
> automating interactive applications such as telnet, ftp, passwd, fsck, rlogin,
> tip, etc.

Done.

Importing the new SRPM (updated specfile in same location) 
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Expect-1.16-2.src.rpm

[Bug 191622] Review Request: perl-Expect - Expect for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Expect - Expect for Perl

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191622

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-05-17 12:51 EST -------
Thanks for the review.

Imported and built for FC-5 and devel.

[Bug 191622] Review Request: perl-Expect - Expect for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Expect - Expect for Perl

https://bugzilla.redhat.com/show_bug.cgi?id=191622

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

[Bug 191622] Review Request: perl-Expect - Expect for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=191622

Mark Chappell  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|                            |fedora-cvs?

--- Comment #4 from Mark Chappell  2010-03-17 12:12:43 EDT ---
Package Change Request
======================
Package Name: perl-Expect
New Branches: EL-5
Owners: tremble
> From IRC:

16:06 < tremble> cweyl: Any chance of perl-Expect for EPEL ?
16:07 < cweyl> tremble: probably not from me :)  If you want to branch and own
the EPEL bits, I'm ok with that

[Bug 191622] Review Request: perl-Expect - Expect for Perl

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=191622

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #5 from Kevin Fenzi  2010-03-17 14:01:25 EDT ---
cvs done.