[Bug 791312] New: Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

https://bugzilla.redhat.com/show_bug.cgi?id=791312

Summary: Review Request: jexcelapi - A Java API to read, write
                    and modify Excel spreadsheets
           Product: Fedora
           Version: rawhide
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: unspecified
          Priority: unspecified
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---
        Regression: ---
        Mount Type: ---
     Documentation: ---

Name        : jexcelapi
Version     : 2.6.12
Group       : Development/Libraries
License     : LGPLv3
URL         : http://www.andykhan.com/jexcelapi
Summary     : A Java API to read, write and modify Excel spreadsheets
Description :
Jexcelapi allows Java developers to read Excel spreadsheets and generate Excel
spreadsheets dynamically. In addition, it contains a mechanism which allows
Java applications to read a spreadsheet, modify some cells and write the
modified spreadsheet.

SPEC:
http://downloads.eucalyptus.com/devel/packages/fedora-17/SPECS/jexcelapi.spe...

SRPM:
http://downloads.eucalyptus.com/devel/packages/fedora-17/sources/jexcelapi-2...

[Bug 791312] Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=791312

Andy Grimm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |652183(FE-JAVASIG)

[Bug 791312] Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=791312

Juan Hernández  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Juan Hernández  2012-03-01 05:39:52 EST ---
I am taking this.

[Bug 791312] Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=791312

Juan Hernández  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

--- Comment #2 from Juan Hernández  2012-03-01 06:07:14 EST ---
=== REQUIRED ITEMS ===
[!]  Rpmlint output:

Result of rpmlint of the SRPM:

jexcelapi.src: W: spelling-error %description -l en_US servlet -> settler
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Result of rpmlint of the binary RPMs:

jexcelapi.noarch: W: spelling-error %description -l en_US servlet -> settler
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format
%{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3842979

[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[-]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[-]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates or must require other
packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x]  Package contains code, or permissable content.
[-]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[-]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc
subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[!]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[-]  If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [1] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when
building with ant
[x]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[-]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a
comment
[-]  If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why
it's needed in a comment
[x]  Package DOES NOT use %update_maven_depmap in %post/%postun
[x]  Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.
[x]  Reviewer should test that the package builds in mock.

=== Issues ===
1. The rpmlit warning about "servlet" is acceptable.
2. The javadoc package is missing "Required: jpackage-utils".

=== Final Notes ===
1. You may want to use %{_javadir} in the patch for the ant build file instead
of absolute path names, something like invoking ant with the
"-D_javadir=%{_javadir}" option and then use "${_javadir}/..." in the build
files.
2. Fix issue #2 and will approve.

[Bug 791312] Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=791312

--- Comment #3 from Andy Grimm  2012-03-01 15:27:24 EST ---
Fixed:

SPEC:
http://downloads.eucalyptus.com/devel/packages/fedora-17/SPECS/jexcelapi.spe...

SRPM:
http://downloads.eucalyptus.com/devel/packages/fedora-17/sources/jexcelapi-2...

[Bug 791312] Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=791312

Juan Hernández  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Juan Hernández  2012-03-06 10:12:29 EST ---
Looks good now.

================
*** APPROVED ***
================

[Bug 791312] Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=791312

Andy Grimm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #5 from Andy Grimm  2012-03-06 15:34:42 EST ---
New Package SCM Request
=======================
Package Name: jexcelapi
Short Description: A Java API to read, write and modify Excel spreadsheets
Owners: arg
Branches: f17

[Bug 791312] Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=791312

--- Comment #6 from Jon Ciesla  2012-03-06 16:26:15 EST ---
Git done (by process-git-requests).

[Bug 791312] Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=791312

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 791312] Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=791312

--- Comment #7 from Fedora Update System  2012-03-07 15:00:24 EST ---
jexcelapi-2.6.12-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/jexcelapi-2.6.12-3.fc17

[Bug 791312] Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=791312

Andy Grimm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
             Blocks|652183(FE-JAVASIG)          |
         Resolution|                            |RAWHIDE
        Last Closed|                            |2012-03-07 16:56:41

[Bug 791312] Review Request: jexcelapi - A Java API to read, write and modify Excel spreadsheets

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=791312

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |jexcelapi-2.6.12-3.fc17
         Resolution|RAWHIDE                     |ERRATA

--- Comment #8 from Fedora Update System  2012-03-11 21:42:17 EDT ---
jexcelapi-2.6.12-3.fc17 has been pushed to the Fedora 17 stable repository.