[Bug 703178] New: Review Request: rubygem-declarative_authorization - The declarative_authorization plug in provides readable auth rules for Rails.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-declarative_authorization - The declarative_authorization plug in provides readable auth rules for Rails.

https://bugzilla.redhat.com/show_bug.cgi?id=703178

Summary: Review Request: rubygem-declarative_authorization -
                    The declarative_authorization plug in provides
                    readable auth rules for Rails.
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---

Spec URL:
http://mcpierce.fedorapeople.org/rpms/rubygem-declarative_authorization.spec
SRPM URL:
http://mcpierce.fedorapeople.org/rpms/rubygem-declarative_authorization-0.5....
Description: The declarative_authorization plug in provides readable auth rules
for Rails.

[Bug 703178] Review Request: rubygem-declarative_authorization - The declarative_authorization plug in provides readable auth rules for Rails.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=703178

Daiki Ueno  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Daiki Ueno  2011-05-10 22:16:32 EDT ---
I'll take this as well as bug 703248 (actually I overlooked this in the NEW RR
list).

It looks that the issues mentioned in bug 703248 were already addressed. 
However, it fails to build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3064358

[Bug 703178] Review Request: rubygem-declarative_authorization - The declarative_authorization plug in provides readable auth rules for Rails.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=703178

--- Comment #2 from Darryl L. Pierce  2011-05-11 07:24:11 EDT ---
(In reply to comment #1)
> I'll take this as well as bug 703248 (actually I overlooked this in the NEW RR
> list).
>
> It looks that the issues mentioned in bug 703248 were already addressed. 
> However, it fails to build:
>
> http://koji.fedoraproject.org/koji/taskinfo?taskID=3064358

Maybe I'm misreading the log, but it looks like the build failure isn't due to
the RPM or specfile but something on the build system itself:

+ cd /usr/lib/ruby/gems/1.8/gems/declarative_authorization-0.5.2
/var/tmp/rpm-tmp.K4xWdp: line 29: cd:
/usr/lib/ruby/gems/1.8/gems/declarative_authorization-0.5.2: No such file or
directory
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.K4xWdp (%check)
    Bad exit status from /var/tmp/rpm-tmp.K4xWdp (%check)
Child returncode was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps
builddir/build/SPECS/rubygem-declarative_authorization.spec']
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/mock/trace_decorator.py", line 70, in
trace
    result = func(*args, **kw)
  File "/usr/lib/python2.6/site-packages/mock/util.py", line 325, in do
    raise mock.exception.Error, ("Command failed. See logs for output.\n # %s"
% (command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps
builddir/build/SPECS/rubygem-declarative_authorization.spec']
LEAVE do --> EXCEPTION RAISED

I can build the RPM both from spec and SRPM locally without a problem. So is
this something I can fix or something that needs to be fixed in Koji?

[Bug 703178] Review Request: rubygem-declarative_authorization - The declarative_authorization plug in provides readable auth rules for Rails.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=703178

--- Comment #3 from Daiki Ueno  2011-05-11 22:53:19 EDT ---
(In reply to comment #2)
> cd /usr/lib/ruby/gems/1.8/gems/declarative_authorization-0.5.2
>
> /var/tmp/rpm-tmp.K4xWdp: line 29: cd:
> /usr/lib/ruby/gems/1.8/gems/declarative_authorization-0.5.2: No such file or
> directory

It seems to be accessing a file outside of %buildroot.  I guess you need to
prepend %{buildroot} to %{geminstdir} like:

%check
 cd %{buildroot}%{geminstdir}
 rake test

However, even then it still fails to build on F-15:

Using Rails from RubyGems (> 2.1.0)
 /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:53:in
`gem_original_require': no such file to load -- initializer (LoadError)

Maybe the test suite cannot run with Rails 3 in standalone mode.  I think
enabling test suite could be postponed until the upstream fixes this.

[Bug 703178] Review Request: rubygem-declarative_authorization - The declarative_authorization plug in provides readable auth rules for Rails.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=703178

--- Comment #4 from Darryl L. Pierce  2011-05-12 07:55:48 EDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > cd /usr/lib/ruby/gems/1.8/gems/declarative_authorization-0.5.2
> >
> > /var/tmp/rpm-tmp.K4xWdp: line 29: cd:
> > /usr/lib/ruby/gems/1.8/gems/declarative_authorization-0.5.2: No such file or
> > directory
>
> It seems to be accessing a file outside of %buildroot.  I guess you need to
> prepend %{buildroot} to %{geminstdir} like:
>
> %check
>  cd %{buildroot}%{geminstdir}
>  rake test
>
> However, even then it still fails to build on F-15:
>
> Using Rails from RubyGems (> 2.1.0)
>  /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:53:in
> `gem_original_require': no such file to load -- initializer (LoadError)
>
> Maybe the test suite cannot run with Rails 3 in standalone mode.  I think
> enabling test suite could be postponed until the upstream fixes this.

I spoke with the upstream, Matthu Huggins, and he verified that the tests
depend on Rails 3. I'm going to work with him to fix them up to run on
F14/Rails 2.3.8 and F15/Rails 3 going forward.

[Bug 703178] Review Request: rubygem-declarative_authorization - The declarative_authorization plug in provides readable auth rules for Rails.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=703178

--- Comment #5 from Darryl L. Pierce  2011-05-13 12:39:00 EDT ---
(In reply to comment #3)
> Maybe the test suite cannot run with Rails 3 in standalone mode.  I think
> enabling test suite could be postponed until the upstream fixes this.

In that case, can we move forward with approving the package?

[Bug 703178] Review Request: rubygem-declarative_authorization - The declarative_authorization plug in provides readable auth rules for Rails.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=703178

--- Comment #6 from Darryl L. Pierce  2011-06-06 08:07:44 EDT ---
Ping reviewer - can we move forward with the package review, please?

[Bug 703178] Review Request: rubygem-declarative_authorization - The declarative_authorization plug in provides readable auth rules for Rails.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=703178

Daiki Ueno  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Daiki Ueno  2011-06-06 20:55:51 EDT ---
Sorry for not getting back to you earlier.  The packaging looks fine except
%check.
Also it would be nice to resolve "File listed twice" warning when building, as
noted in bug 703248.

APPROVED.

[Bug 703178] Review Request: rubygem-declarative_authorization - The declarative_authorization plug in provides readable auth rules for Rails.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=703178

Darryl L. Pierce  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #8 from Darryl L. Pierce  2011-06-07 10:07:08 EDT ---
New Package SCM Request
=======================
Package Name: rubygem-declarative_authorization
Short Description: The declarative_authorization plug in provides readable auth
rules for Rails.
Owners: mcpierce
Branches: F15
InitialCC: mcpierce

[Bug 703178] Review Request: rubygem-declarative_authorization - The declarative_authorization plug in provides readable auth rules for Rails.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=703178

--- Comment #9 from Jason Tibbitts  2011-06-07 11:10:12 EDT ---
Git done (by process-git-requests).

[Bug 703178] Review Request: rubygem-declarative_authorization - The declarative_authorization plug in provides readable auth rules for Rails.

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=703178

Darryl L. Pierce  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE
        Last Closed|                            |2011-06-07 13:36:02

--- Comment #10 from Darryl L. Pierce  2011-06-07 13:36:02 EDT ---
Thanks for the quick repo creation, Jason!