[Bug 2124361] New: Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references

https://bugzilla.redhat.com/show_bug.cgi?id=2124361

Bug ID: 2124361
           Summary: Review Request: rust-servo_arc - Fork of
                    std::sync::Arc with some extra functionality and
                    without weak references
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://kalev.fedorapeople.org/rust-servo_arc.spec
SRPM URL: https://kalev.fedorapeople.org/rust-servo_arc-0.1.1-1.fc38.src.rpm

Description:
Fork of std::sync::Arc with some extra functionality and without weak
references.

Fedora Account System Username: kalev

rust-servo_arc is a dependency for librsvg2 (I'm trying to get it to build
using system rust creates instead of vendored).

[Bug 2124361] Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references

https://bugzilla.redhat.com/show_bug.cgi?id=2124361

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2124365

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2124365
[Bug 2124365] Review Request: rust-selectors - CSS Selectors matching for Rust

[Bug 2124361] Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references

https://bugzilla.redhat.com/show_bug.cgi?id=2124361

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #1 from Fabio Valentini  ---
> # license file is missing from the crate

In the case of MIT and Apache-2.0 licenses, this is actually a problem.
Both require redistributed sources to ship a copy of the license text.

There are no license files in the upstream repo for this crate, either:
https://github.com/servo/servo/tree/master/components/servo_arc

But some crates in the /components/ directory seem to have LICENSE-MIT and
LICENSE-Apache files, so filing an issue with the project should hopefully get
this resolved.

[Bug 2124361] Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references

https://bugzilla.redhat.com/show_bug.cgi?id=2124361

--- Comment #2 from Kalev Lember  ---
Done: https://github.com/servo/servo/issues/28966

[Bug 2124361] Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references

https://bugzilla.redhat.com/show_bug.cgi?id=2124361

--- Comment #3 from Kalev Lember  ---
* Sat Oct 01 2022 Kalev Lember  0.1.1-2
- Backport upstream patch to add license files (rhbz#2124361)

Spec URL: https://kalev.fedorapeople.org/rust-servo_arc.spec
SRPM URL: https://kalev.fedorapeople.org/rust-servo_arc-0.1.1-2.fc38.src.rpm

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=92464208

[Bug 2124361] Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references

https://bugzilla.redhat.com/show_bug.cgi?id=2124361

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #4 from Fabio Valentini  ---
Sorry for the delay. Package looks good to me now, thanks for filing the
upstream issue.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable
for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

[Bug 2124361] Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references

https://bugzilla.redhat.com/show_bug.cgi?id=2124361

--- Comment #5 from Kalev Lember  ---
Thanks, Fabio!

[Bug 2124361] Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references

https://bugzilla.redhat.com/show_bug.cgi?id=2124361

--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-servo_arc

[Bug 2124361] Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references

https://bugzilla.redhat.com/show_bug.cgi?id=2124361

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #7 from Fedora Update System  ---
FEDORA-2022-acfeadddbd has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2022-acfeadddbd

[Bug 2124361] Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references

https://bugzilla.redhat.com/show_bug.cgi?id=2124361

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2022-10-13 18:44:59

--- Comment #8 from Fedora Update System  ---
FEDORA-2022-acfeadddbd has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2124361] Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references

https://bugzilla.redhat.com/show_bug.cgi?id=2124361

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |rust-servo_arc-0.1.1-2.fc38
                   |                            |rust-servo_arc-0.1.1-2.fc37

--- Comment #9 from Kalev Lember  ---
Package imported and built.