https://bugzilla.redhat.com/show_bug.cgi?id=1156967
Bug ID: 1156967 Summary: A bash implementation for 2048 for bash. Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: villadalmine@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Flags: fedora-review+ fedora-cvs+
Description of problem:
Version-Release number of selected component (if applicable):
How reproducible:
Steps to Reproduce: 1. 2. 3.
Actual results:
Expected results:
Additional info:
https://bugzilla.redhat.com/show_bug.cgi?id=1156967
--- Comment #1 from Rino Rondan villadalmine@gmail.com --- https://villadalmine.fedorapeople.org/bash2048-1.0-1.fc20.src.rpm https://villadalmine.fedorapeople.org/bash2048.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1156967
--- Comment #2 from Rino Rondan villadalmine@gmail.com --- https://villadalmine.fedorapeople.org/bash2048-1.0-2.fc20.src.rpm https://villadalmine.fedorapeople.org/bash2048.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1156967
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags|fedora-review+ fedora-cvs+ |fedora-review?
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Would be great to have .desktop and .appdata files for this. See http://people.freedesktop.org/~hughsient/appdata/ for a desription. Since this is a terminal app, it would start its own terminal if launched through the desktop file. See the bastet package for a nice example how to do this.
Please change %summary to something like "Add numbers by moving them with arrow keys to reach 2048" or something like that. Also please extend the %description, not everybody knows what 2048 is. %summary should be a phrase without a dot at the end.
Please consider using CC-0 as the license, it's more mainstream.
Use %license for the license file.
Change she-bang to /bin/sh.
Package looks good.
https://bugzilla.redhat.com/show_bug.cgi?id=1156967
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Ping?
https://bugzilla.redhat.com/show_bug.cgi?id=1156967
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DEFERRED Last Closed| |2015-05-16 19:27:17
--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Closing because of lack of response. Please reopen if you even want to pick this up again.
package-review@lists.fedoraproject.org