[Bug 1873373] New: Review Request: Gcore extension module(crash-gcore-command) for the crash utility

https://bugzilla.redhat.com/show_bug.cgi?id=1873373

Bug ID: 1873373
           Summary: Review Request: Gcore extension
                    module(crash-gcore-command) for the crash utility
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Description:

Spec URL:
https://github.com/lian-bo/fedora-crash-gcore-command/blob/master/crash-gcor...

SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/9727/50289727/crash-gcore-com...

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=50289726

Description: The crash-gcore-command packages contain an extension module for
the crash utility that adds a "gcore" command which can create a core dump file
of a user-space task that was running in a kernel dumpfile.

In addition, I also maintain the crash-utility in Fedora and upstream.

Thanks for your attention.

Fedora Account System Username: lijiang

[Bug 1873373] Review Request: crash-gcore-command - Gcore extension module for the crash utility

https://bugzilla.redhat.com/show_bug.cgi?id=1873373

--- Comment #1 from Robert-André Mauchin 🐧  ---
 - This is not used in Fedora:

Group: Development/Debuggers

- The link to the archive is not valid:

Source:
https://github.com/crash-utility/crash-extensions/raw/master/%%7Bname%7D-%%7...

Also uploading binary archive straight to git is a bad idea. It would be better
to tag a release.
Everyone cloning the repo wall have to download the binary even if you delete
it later. It could be purged from history but I don't know the exact procedure.

- Not needed:

ExclusiveOS: Linux

- ExclusiveArch: x86_64 %{ix86} arm aarch64 ppc64 ppc64le → ExclusiveArch:
x86_64 %{ix86} %{arm} aarch64 ppc64 ppc64le

- Split your BR one per line, consider using pkgconfig() for your devel
dependency:

BuildRequires: crash-devel >= 5.1.5
BuildRequires: pkgconfig(zlib)
BuildRequires: pkgconfig(lzo2)
BuildRequires: pkgconfig(snappy)

- Not needed:

rm -Rf $RPM_BUILD_ROO

%clean
rm -rf %{buildroot}
rm -Rf $RPM_BUILD_ROOT

%defattr(-,root,root)

- License file must be installed with %license not %doc

%license COPYING

- You need to make sure Fedora build flags are used for the build.

Use %set_build_flags to set them up.

%build
%set_build_flags
%make_build -f gcore.mk

- make -f gcore.mk → %make_build -f gcore.mk

- please use install to create and install file at the right place:

install -m 0755 -vd                    
%{buildroot}%{_libdir}/crash/extensions/
install -m 0755 -vp gcore.so           
%{buildroot}%{_libdir}/crash/extensions/

[Bug 1873373] Review Request: crash-gcore-command - Gcore extension module for the crash utility

https://bugzilla.redhat.com/show_bug.cgi?id=1873373

--- Comment #2 from [e-mail] ---
Hi, Robert-André Mauchin

Thank you for helping to review this.

Based on our internal team's discussion(and on upstream), we would like to give
up adding the crash extensions packages to the Fedora because no one uses them
in the Fedora, currently, only Fujitsu engineers use them in RHEL. So, I will
close this bug.

Thanks for your help, Robert-André Mauchin.

[Bug 1873373] Review Request: crash-gcore-command - Gcore extension module for the crash utility

https://bugzilla.redhat.com/show_bug.cgi?id=1873373

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |WONTFIX
        Last Closed|                            |2020-09-07 02:09:06