[Bug 1871765] New: Review Request: thoth-toolbox - This is a toolbox container image for Thoth tools
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
Bug ID: 1871765 Summary: Review Request: thoth-toolbox - This is a toolbox container image for Thoth tools Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: cgoern@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: n/a, its just a container image SRPM URL: n/a, its just a container image Description: This is a toolbox container image aggregating some of Thoth tools, including micropipenv and thamos Fedora Account System Username: goern
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
Christoph Görn cgoern@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: n/a, its just a container image SRPM URL: n/a, its just a container image Description: This is a toolbox container image aggregating some of Thoth tools, including micropipenv and thamos Fedora Account System Username: goern
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- I don't understand, what are you expecting from this bug in Review Request, if we don't have anything to review?
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
Qiyu Yan yanqiyu01@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |yanqiyu01@gmail.com
--- Comment #2 from Qiyu Yan yanqiyu01@gmail.com --- Container review request shouldn't be here. See: https://fedoraproject.org/wiki/Container:Review_Process
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
Qiyu Yan yanqiyu01@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: n/a, its just a container image SRPM URL: n/a, its just a container image Description: This is a toolbox container image aggregating some of Thoth tools, including micropipenv and thamos Fedora Account System Username: goern
additional information can be found at https://github.com/thoth-station/thoth-toolbox
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
Qiyu Yan yanqiyu01@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |container-review@lists.fedo | |raproject.org Component|Package Review |Container Review Product|Fedora |Fedora Container Images Summary|Review Request: |Container Review Request: |thoth-toolbox - This is a |thoth-toolbox - This is a |toolbox container image for |toolbox container image for |Thoth tools |Thoth tools
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
--- Comment #3 from Qiyu Yan yanqiyu01@gmail.com --- Changed format, this should make fedpkg happy.
Most thing are just in same structure as what [toolbox] it self do, expect the name part, which I think is of no importance.(which I will confirm later)
[toolbox]: https://src.fedoraproject.org/container/fedora-toolbox/blob/master/f/Dockerf...
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
Qiyu Yan yanqiyu01@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |yanqiyu01@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
--- Comment #4 from Qiyu Yan yanqiyu01@gmail.com --- While I think using pip is not a good idea,since you are using something that haven't packaged into package collection yet, this is not compliance with guideline: https://docs.fedoraproject.org/en-US/containers/guidelines/contents/#_allowe...
What you need to do then - check if those pip packages have already been packaged, if so, use dnf to install instead of pip - if not so, package them (you can look for help from devel list) - ping me if those are done :)
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |athoscribeiro@gmail.com
--- Comment #5 from Athos Ribeiro athoscribeiro@gmail.com --- - The .osbs-repo-config file is not needed: Fedora's OSBS has no autorebuilds enabled.
- pip content is not allowed, as per the guidelines as Qiyu pointed out.
- The version should be set to 0 according to the guidelines. Alternatively, you should install specific versions of the package so a rebuild won't turn your version into a bogus one.
- You could move the README.md to a help.md file and it should be converted to a man page in the image's root.
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
--- Comment #6 from Christoph Görn cgoern@redhat.com --- Hey all thanks for the review. I will work on the findings. I think I followed https://docs.fedoraproject.org/en-US/containers/guidelines/contents/#_allowe... and interpreted "SHOULD NOT container" as... should not, rather than MUST NOT.
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
Christoph Görn cgoern@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1871765
Christoph Görn cgoern@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Link ID| |Github | |thoth-station/thoth-toolbox | |/issues/2
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com