[Bug 1749751] New: Review Request: rubygem-kramdown-parser-gfm - Kramdown parser for GitHub-flavored markdown
https://bugzilla.redhat.com/show_bug.cgi?id=1749751
Bug ID: 1749751 Summary: Review Request: rubygem-kramdown-parser-gfm - Kramdown parser for GitHub-flavored markdown Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/packages/rubygem-kramdown-parser-gfm.spe... SRPM URL: https://decathorpe.fedorapeople.org/packages/rubygem-kramdown-parser-gfm-1.1...
Description: kramdown-parser-gfm provides a kramdown parser for the GFM dialect of Markdown.
Fedora Account System Username: decathorpe
COPR repo with working packages: https://copr.fedorainfracloud.org/coprs/decathorpe/jekyll4/monitor/
https://bugzilla.redhat.com/show_bug.cgi?id=1749751
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1743745 Depends On| |1749749
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1743745 [Bug 1743745] rubygem-jekyll-4.0.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1749749 [Bug 1749749] kramdown version 2.1.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1749751 Bug 1749751 depends on bug 1749749, which changed state.
Bug 1749749 Summary: kramdown version 2.1.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1749749
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1749751
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mtasaka@fedoraproject.org Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1749751
--- Comment #1 from Mamoru TASAKA mtasaka@fedoraproject.org --- 1. Review
* license okay - MIT for all files * spec file * mock build okay https://koji.fedoraproject.org/koji/taskinfo?taskID=37637054 * rpmlint okay for src.rpm, binary rpm, installed rpm * installable for F-32 * basic functionality okay (as documentated on "Usage" of https://github.com/kramdown/parser-gfm) ``` [mockbuild@1a996dddfd3e4efb85d341420b9e76a2 ~]$ ruby -e 'require "kramdown" ; require "kramdown-parser-gfm" ; text="This ~~is a complex strike through *test ~~with nesting~~ involved* here~~." ; puts Kramdown::Document.new(text, input: "GFM").to_html' <p>This <del>is a complex strike through *test ~~with nesting</del> involved* here~~.</p> ```
2. Advice * BR - I would recommend to write "BuildRequires: rubygem(kramdown) >= 2.0" because on F-31 and below rubygem-kramdown is still 1.7.x and this srpm is incompatible on those branches (not a blocker for review)
By the way do you plan to import this also on F-31? If so I will coordinate it.
https://bugzilla.redhat.com/show_bug.cgi?id=1749751
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Mamoru TASAKA mtasaka@fedoraproject.org --- ============================================================ This package (rubygem-kramdown-parser-gfm) is APPROVED by mtasaka ============================================================
https://bugzilla.redhat.com/show_bug.cgi?id=1749751
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Thanks for the review!
BuildRequires: rubygem(kramdown) >= 2.0.0 is already in the .spec file. ;)
I only intend to push this to fedora 32, since it's a breaking change (in both kramdown and jekyll 4). See: https://fedoraproject.org/wiki/Changes/Jekyll4
https://bugzilla.redhat.com/show_bug.cgi?id=1749751
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- https://pagure.io/releng/fedora-scm-requests/issue/16685
https://bugzilla.redhat.com/show_bug.cgi?id=1749751
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-kramdown-parser-gfm
https://bugzilla.redhat.com/show_bug.cgi?id=1749751
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |rubygem-kramdown-parser-gfm | |-1.1.0-1.fc32 Resolution|--- |RAWHIDE Last Closed| |2019-09-13 13:27:57
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Built for rawhide. https://koji.fedoraproject.org/koji/buildinfo?buildID=1377189
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com