Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: grnotify - Google Reader Notifier
https://bugzilla.redhat.com/show_bug.cgi?id=483116
Summary: Review Request: grnotify - Google Reader Notifier Product: Fedora Version: 10 Platform: noarch URL: http://grnotify.sourceforge.net/ OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: llaumgui@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
GrNotify is a simple Python written tray application that will allow you to know when there are new items in the Google Reader.
SPEC: http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec
SRPMS: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.0.2-2.fc10.noarc...
RPM: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.0.2-2.fc10.src.r...
Commment: rpmlint is silent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #1 from Guillaume Kulakowski llaumgui@gmail.com 2009-01-29 15:54:58 EDT --- Fredonnement… La version 1.1.1 a été libérée peu d'heures avant ma demande… Je fais aller rapidement la construction T/MN avant week-end :
SPEC: http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec
SRPMS: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.1-1.fc10.noarc...
RPM: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.1-1.fc10.src.r...
Commment: builder@enterprise ~> rpmlint rpmbuild/RPMS/noarch/grnotify-1.1.1-1.fc10.noarch.rpm 21:45 grnotify.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/grnotify/GoogleReader.py 0644
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #2 from Guillaume Kulakowski llaumgui@gmail.com 2009-02-03 13:38:58 EDT --- Version 1.1.2
SPEC: http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec
SRPMS: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.2-1.fc10.noarc...
RPM: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.2-1.fc10.src.r...
Commment: rpmlint is silent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #3 from Guillaume Kulakowski llaumgui@gmail.com 2009-02-07 09:59:18 EDT --- Version 1.1.2
SPEC: http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec
SRPMS: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.2-2.fc10.noarc...
RPM: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.2-2.fc10.src.r...
Commment: rpmlint is silent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
Joseph Smidt jsmidt@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jsmidt@fedoraproject.org Flag| |fedora-review?
--- Comment #4 from Joseph Smidt jsmidt@fedoraproject.org 2009-02-16 23:48:32 EDT --- I will take up reviewing this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #5 from Joseph Smidt jsmidt@fedoraproject.org 2009-02-17 01:01:07 EDT --- As packaging goes, it all seems good. :) (See attachment) However, are you sure you need gnome-icon-theme as a Requires? It is not mentioned on the webpage: http://grnotify.sourceforge.net/install.html or in the sources as a dependency.
When I run the package it seems to run just fine. However, when I close out and open it back up it does not remember my username and password. When I run in a terminal I get this output:
/usr/bin/grnotify:591: GtkWarning: GtkSpinButton: setting an adjustment with non-zero page size is deprecated self.xml = gtk.glade.XML(self.gladefile)
Then, when I hit "Save" to save my username and password I get this output
Traceback (most recent call last): File "/usr/bin/grnotify", line 711, in on_save_button_clicked grnotify_app.saveConfig() File "/usr/bin/grnotify", line 75, in saveConfig if not self.useKeyRing or not self.saveKeyRing(self.passwd): File "/usr/bin/grnotify", line 130, in saveKeyRing except gnomekeyring.AlreadyExistsError: UnboundLocalError: local variable 'gnomekeyring' referenced before assignment
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #6 from Joseph Smidt jsmidt@fedoraproject.org 2009-02-17 01:02:06 EDT --- Created an attachment (id=332179) --> (https://bugzilla.redhat.com/attachment.cgi?id=332179) Review of package
Here is the Review attachment.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #7 from Guillaume Kulakowski llaumgui@gmail.com 2009-02-17 02:49:53 EDT --- Hi,
Thx Joseph. I contact the author for this bug, and I propose a setup.py for a better clean installation and packaging.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #8 from Guillaume Kulakowski llaumgui@gmail.com 2009-02-17 13:58:52 EDT --- Hi,
gnome-icon-theme is an error of my part. I have proposed to the author a new setup.py for a easiers packaging : https://sourceforge.net/tracker2/?func=detail&aid=2609868&group_id=2...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #9 from Joseph Smidt jsmidt@fedoraproject.org 2009-02-18 11:38:05 EDT --- Has the author responded? Do you have a new Spec/Srpm that I could review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #10 from Guillaume Kulakowski llaumgui@gmail.com 2009-02-18 14:23:14 EDT --- Hi,
no response. But a new SPEC without path for install.py but a new setup.py that I proposed to the author
Version 1.1.2-3
SPEC: http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec
SRPMS: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.2-3.fc10.noarc...
RPM: http://llaumgui.fedorapeople.org/review/grnotify/grnotify-1.1.2-3.fc10.src.r...
Commment: rpmlint is silent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #11 from Joseph Smidt josephsmidt@gmail.com 2009-02-21 00:31:09 EDT --- Sorry, I got busy for a couple days. It looks good. Approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
Joseph Smidt josephsmidt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
Joseph Smidt josephsmidt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |josephsmidt@gmail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
Guillaume Kulakowski llaumgui@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #12 from Guillaume Kulakowski llaumgui@gmail.com 2009-02-22 05:43:45 EDT --- New Package CVS Request ======================= Package Name: grnotify Short Description: Google Reader Notifier Owners: llaumgui Branches: F-9 F-10 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #13 from Kevin Fenzi kevin@tummy.com 2009-02-22 14:23:43 EDT --- Can you fix your usage of --vendor here?
From the guidelines:
"For new packages, do not apply a vendor tag to desktop files"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #14 from Guillaume Kulakowski llaumgui@gmail.com 2009-02-22 14:36:31 EDT --- OK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #15 from Guillaume Kulakowski llaumgui@gmail.com 2009-02-22 14:50:45 EDT --- Correction made in http://llaumgui.fedorapeople.org/review/grnotify/grnotify.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #16 from Kevin Fenzi kevin@tummy.com 2009-02-24 15:59:24 EDT --- Thanks.
cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #17 from Fedora Update System updates@fedoraproject.org 2009-02-24 19:18:57 EDT --- grnotify-1.1.2-4.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/grnotify-1.1.2-4.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #18 from Fedora Update System updates@fedoraproject.org 2009-02-24 19:19:02 EDT --- grnotify-1.1.2-4.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/grnotify-1.1.2-4.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #19 from Fedora Update System updates@fedoraproject.org 2009-02-25 11:24:44 EDT --- grnotify-1.1.2-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update grnotify'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2075
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #20 from Fedora Update System updates@fedoraproject.org 2009-02-25 11:25:12 EDT --- grnotify-1.1.2-4.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update grnotify'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-2077
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #21 from Fedora Update System updates@fedoraproject.org 2009-03-09 18:56:30 EDT --- grnotify-1.1.2-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |1.1.2-4.fc9 Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
--- Comment #22 from Fedora Update System updates@fedoraproject.org 2009-03-09 19:06:15 EDT --- grnotify-1.1.2-4.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483116
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|1.1.2-4.fc9 |1.1.2-4.fc10
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla