https://bugzilla.redhat.com/show_bug.cgi?id=2138152
Bug ID: 2138152 Summary: Review Request: rust-prettyplease - Minimal `syn` syntax tree pretty-printer Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jamacku@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/jamacku/rust-prettyplease... SRPM URL: https://download.copr.fedorainfracloud.org/results/jamacku/rust-prettyplease... Description: Minimal `syn` syntax tree pretty-printer. Fedora Account System Username: jamacku
https://bugzilla.redhat.com/show_bug.cgi?id=2138152
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review? Status|NEW |ASSIGNED
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Taking this review, will probably get to it tomorrow.
https://bugzilla.redhat.com/show_bug.cgi?id=2138152
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Sorry for the delay, package looks good to me. Minor nit-pick: Please remove the Markdown markup from the package's Summary and this bug's title (i.e. the `code fences`).
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2138152
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2138152
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-prettyplease
https://bugzilla.redhat.com/show_bug.cgi?id=2138152
--- Comment #4 from Jan Macku jamacku@redhat.com --- Thank you Fabio, I have removed Markdown markup from the Summary and submitted builds.
https://bugzilla.redhat.com/show_bug.cgi?id=2138152
Jan Macku jamacku@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|POST |CLOSED Last Closed| |2022-11-01 09:14:25
package-review@lists.fedoraproject.org