https://bugzilla.redhat.com/show_bug.cgi?id=2160212
Bug ID: 2160212 Summary: Review Request: golang-github-hexops-gotextdiff - Unified text diffing in Go Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mike@flyn.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://www.flyn.org/SRPMS/golang-github-hexops-gotextdiff.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-hexops-gotextdiff-1.0.3-1.fc37.src.... Description: Unified text diffing in Go Fedora Account System Username: mikep
https://bugzilla.redhat.com/show_bug.cgi?id=2160212
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5218124 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2160212
W. Michael Petullo mike@flyn.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from W. Michael Petullo mike@flyn.org --- Spec URL: https://www.flyn.org/SRPMS/golang-github-hexops-gotextdiff.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-hexops-gotextdiff-1.0.3-1.fc37.src.... Description: Unified text diffing in Go Fedora Account System Username: mikep
This copy modifies the summary and description of the package.
https://bugzilla.redhat.com/show_bug.cgi?id=2160212
--- Comment #3 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1937598 --> https://bugzilla.redhat.com/attachment.cgi?id=1937598&action=edit The .spec file difference from Copr build 5218124 to 5223854
https://bugzilla.redhat.com/show_bug.cgi?id=2160212
--- Comment #4 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5223854 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2160212
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2148832 CC| |quantum.analyst@gmail.com
--- Comment #5 from Mikel Olasagasti Uranga mikel@olasagasti.info --- *** Bug 2148679 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2148832 [Bug 2148832] Review Request: golang-github-alecthomas-assert-2 - Simple assertion library using Go generics
https://bugzilla.redhat.com/show_bug.cgi?id=2160212
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mikel@olasagasti.info CC| |mikel@olasagasti.info Flags| |fedora-review+
--- Comment #6 from Mikel Olasagasti Uranga mikel@olasagasti.info --- I am not going to go through the whole fedora-review template, as this package uses go2rpm.
- [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
https://bugzilla.redhat.com/show_bug.cgi?id=2160212
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2160212
--- Comment #7 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-hexops-gotextdiff
https://bugzilla.redhat.com/show_bug.cgi?id=2160212
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-1a016340bb has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1a016340bb
https://bugzilla.redhat.com/show_bug.cgi?id=2160212
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-01-12 16:59:57
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-1a016340bb has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org